Re: [quicwg/base-drafts] Keys need to be available to QUIC earlier (#2992)

Kazuho Oku <notifications@github.com> Tue, 10 September 2019 23:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1283112006B for <quic-issues@ietfa.amsl.com>; Tue, 10 Sep 2019 16:14:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1aXrZP9CBkN8 for <quic-issues@ietfa.amsl.com>; Tue, 10 Sep 2019 16:14:34 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7CC72120013 for <quic-issues@ietf.org>; Tue, 10 Sep 2019 16:14:34 -0700 (PDT)
Date: Tue, 10 Sep 2019 16:14:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568157273; bh=3mgwTweEunLeF5lYqJPTTHx86+tznxXs98heXaG6Wak=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jv/iL8Lq28KVb1U/WFpDifJhgz3BchuNiXKkX3szSWk6b7DdI/bGzcJdxxqwog42B sowleQhLI9PC/AwhgwuEBMR7S0VIxvDImu6zcCR477J+pEvhATmfzUM5dmHQlOkOJ+ VHpMJKU5Gz0hrBeAx6ZlIykY9j9ll1VD3OCvHAs4=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2JXRJ4EEB5E3PYB4V3QVQNTEVBNHHBZ243UA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2992/review/286483236@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2992@github.com>
References: <quicwg/base-drafts/pull/2992@github.com>
Subject: Re: [quicwg/base-drafts] Keys need to be available to QUIC earlier (#2992)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d782e59a0b90_6efb3ff4b7ecd95c65745"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/inTlrtGlBuAiiN04_nS428ht7Sk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Sep 2019 23:14:36 -0000

kazuho commented on this pull request.

LGTM modulo the nitpick below.

>                                                     Get Handshake
                      <------------- Initial
+Handshake Received
+Install tx Handshake keys

s/Install tx Handshake keys/Install Handshake keys/?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2992#pullrequestreview-286483236