Re: [quicwg/base-drafts] Optimize definition IP addr in TP PreferredAddress (#1533)

Dmitri Tikhonov <notifications@github.com> Mon, 09 July 2018 13:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7FBC2130FA8 for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 06:00:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.109
X-Spam-Level:
X-Spam-Status: No, score=-6.109 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jQyRxjBrsx-H for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 06:00:51 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CAC77130EFF for <quic-issues@ietf.org>; Mon, 9 Jul 2018 06:00:51 -0700 (PDT)
Date: Mon, 09 Jul 2018 06:00:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531141250; bh=d+emtEvkWrIZpu7dNpHrR2GYj0p7M6YTkN+ht5PBUP0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=I0FCAs1SuuTWai68bCTnnXUYFpF7zlF4UMNYgEDpzLVyEMcM9D/8EggL+gpO4faUP jI6QvrlKRsRNhHWWbWgGGhrKHS/p0CHDSWwTbddHldndsRjOumRTsEvSJn7isXKxRf wG8BA+s5ccocSkOvAn3OYDRJDMhx8A7FKu0dFTDQ=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6d8c00e9183a1b8616caa4f7a63692e3afad97d692cf00000001175b1e8292a169ce1435a6cc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1533/review/135405345@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1533@github.com>
References: <quicwg/base-drafts/pull/1533@github.com>
Subject: Re: [quicwg/base-drafts] Optimize definition IP addr in TP PreferredAddress (#1533)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b435c82aaa10_5f9f3feb0eff4f7c1755b7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kFkwcbVIWpg73PyD91BKwTBCwLE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2018 13:00:54 -0000

dtikhonov commented on this pull request.



> @@ -1444,9 +1444,20 @@ language from Section 3 of {{!I-D.ietf-tls-tls13}}.
       TransportParameter parameters<22..2^16-1>;
    } TransportParameters;
 
+   struct {
+     uint8[4] addr;
+   } IPv4addr;
+
+   struct {
+     uint8[16] addr;
+   } IPv6addr;

There are no typedefs in the [TLS 1.3 draft](https://tools.ietf.org/html/draft-ietf-tls-tls13-28).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1533#discussion_r200992572