Re: [quicwg/base-drafts] Firm up language around stream termination (#2888)

Ryan Hamilton <notifications@github.com> Wed, 10 July 2019 13:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1A060120282 for <quic-issues@ietfa.amsl.com>; Wed, 10 Jul 2019 06:49:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ks-1Q7hhZU3s for <quic-issues@ietfa.amsl.com>; Wed, 10 Jul 2019 06:49:41 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2E9741202A0 for <quic-issues@ietf.org>; Wed, 10 Jul 2019 06:49:41 -0700 (PDT)
Date: Wed, 10 Jul 2019 06:49:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1562766579; bh=2aLozf8QLBGaRuEpsBccKFDfRRFoBFvLRn3aVo0DwoA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=16UvpxR4jJbgB3OsBlWdoTmaP8QNWBsXFzv/hZWuyT/WTqFBBFJK/G77ZYCrKCTlh 9uVTUgNjMlZKgQjTwteTBkrJlhSVy531A9ZaEHjxJgtSaNWf0CFFHdmYQYsaY58z9c k2B2tza6EU3l7C/5yUI2M2SV8Kf2PlTb3xRkLWg4=
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7GJOCP656QC2HUNSV3GMPXHEVBNHHBXSF4LQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2888/review/260105299@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2888@github.com>
References: <quicwg/base-drafts/pull/2888@github.com>
Subject: Re: [quicwg/base-drafts] Firm up language around stream termination (#2888)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d25ecf37fca7_4c163fc6608cd96028780ee"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kP7o1wFUqysOYtRzkBiSvevDwjo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jul 2019 13:49:50 -0000

RyanAtGoogle commented on this pull request.



> @@ -2601,12 +2601,17 @@ connection in a recoverable state, the endpoint can send a RESET_STREAM frame
 ({{frame-reset-stream}}) with an appropriate error code to terminate just the
 affected stream.
 
-RESET_STREAM MUST be instigated by the protocol using QUIC, either directly or
-through the receipt of a STOP_SENDING frame from a peer.  RESET_STREAM carries
-an application error code.  Resetting a stream without knowledge of the
-application protocol could cause the protocol to enter an unrecoverable state.
-Application protocols might require certain streams to be reliably delivered in
-order to guarantee consistent state between endpoints.
+RESET_STREAM MUST be instigated by the protocol using QUIC.  RESET_STREAM
+carries an application error code.  Only the application protocol is able to
+cause a stream to be terminated.  A local instance of the application protocol
+uses a direct API call and a remote instance uses the STOP_SENDING frame, which
+triggers an automatic RESET_STREAM.

Hm. The second sentence suggests that the determination of the application error code in the RESET_STREAM is the responsibility of the application. Fair enough. But in this last sentence, it sounds like the RESET_STREAM is generated by the transport (or some such) in response to STOP_SENDING. Also fair enough. But how does the transport determine the application error code.

I think the behavior here is fine, but the text feels... wooly, as you said. I wonder if it might be easier to read if we treated the STOP_SENDING case as more of an exception, than trying to make it part of the general "only the app resets streams" behavior.  *shrug*

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2888#pullrequestreview-260105299