Re: [quicwg/base-drafts] TLS provides AEAD and KDF (#2046)
janaiyengar <notifications@github.com> Tue, 27 November 2018 03:18 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E67C8130DF9 for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 19:18:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lQImmyzkAAbn for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 19:18:11 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3A47127B4C for <quic-issues@ietf.org>; Mon, 26 Nov 2018 19:18:10 -0800 (PST)
Date: Mon, 26 Nov 2018 19:18:09 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543288689; bh=TAu2EcUGxjQBb4NXLkMoa/9jgVc8pbJMNpYy9rVW2bI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zcdySsJ9SGl8084Tv/I2TT/jVc4b1mmyXQ9BcItBv0PCHFhA15hKME+ZSshLtIiTb 6CQTmHGd0FKdtU5gDOXVk3W//hYVuSttCFFsg5PMC14KNjPYOcDoATb4OFYsVJwO0W 1xfDMi9/mAwkUXfys0pcBzED/l6lGIE6eQ4f4qHA=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab366e789dbd6113627b8d45b0d0691619b9cc874592cf000000011814797192a169ce16de87de@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2046/review/178595698@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2046@github.com>
References: <quicwg/base-drafts/pull/2046@github.com>
Subject: Re: [quicwg/base-drafts] TLS provides AEAD and KDF (#2046)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfcb771af27f_223b3f844bed45b81222e8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kTj-vR9KHD9utTmgz8HdxappR4Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2018 03:18:13 -0000
janaiyengar approved this pull request. > @@ -710,14 +722,19 @@ based on the client's initial Destination Connection ID, as described in {{initial-secrets}}. The keys used for packet protection are computed from the TLS secrets using the -method described in Section 7.3 of {{!TLS13}}), with the labels "quic key" and -"quic iv" in place of the labels used by TLS (that is, "key" and "iv" -respectively). Using these labels provides key separation between QUIC and TLS, -see {{key-diversity}}. +KDF provided by TLS. In TLS 1.3, the HKDF-Expand-Label function described in +Section 7.1 of {{!TLS13}}) is used, using the hash function from the negotiated +cipher suite. Other versions of TLS MUST provide a similar function in order to +be used QUIC. + + The current encryption level secret and the label "quic key" are input to the ```suggestion The current encryption level secret and the label "quic key" are input to the ``` > @@ -753,9 +770,8 @@ thus ensuring that the keys are different for each version of QUIC. This prevents a middlebox that only recognizes one version of QUIC from seeing or modifying the contents of handshake packets from future versions. -The HKDF function defined in TLS 1.3 MUST be used even in case the minimum TLS -version that the endpoint is willing to use is greater, so as to assure that -the peer can decrypt the packet. +The HKDF-Expand-Label function defined in TLS 1.3 MUST be used for Initial Might be worth stating "For QUICv1 ..." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2046#pullrequestreview-178595698
- [quicwg/base-drafts] TLS provides AEAD and KDF (#… Martin Thomson
- Re: [quicwg/base-drafts] TLS provides AEAD and KD… Kazuho Oku
- Re: [quicwg/base-drafts] TLS provides AEAD and KD… janaiyengar
- Re: [quicwg/base-drafts] TLS provides AEAD and KD… Martin Thomson
- Re: [quicwg/base-drafts] TLS provides AEAD and KD… Martin Thomson