Re: [quicwg/base-drafts] Recommend a 1ms timer granularity (#3521)

Martin Thomson <notifications@github.com> Sun, 15 March 2020 21:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D91D03A1C69 for <quic-issues@ietfa.amsl.com>; Sun, 15 Mar 2020 14:14:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CdQ_3NleDz1Z for <quic-issues@ietfa.amsl.com>; Sun, 15 Mar 2020 14:14:30 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8ADDE3A1C68 for <quic-issues@ietf.org>; Sun, 15 Mar 2020 14:14:30 -0700 (PDT)
Received: from github-lowworker-0f78100.ash1-iad.github.net (github-lowworker-0f78100.ash1-iad.github.net [10.56.25.48]) by smtp.github.com (Postfix) with ESMTP id 5E72996022B for <quic-issues@ietf.org>; Sun, 15 Mar 2020 14:14:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584306869; bh=494QdLA9nXtmwdOvhlLV9q/tC/TqpQYEcGIgz31gCBo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iYzoG7G/Kvyu9J0JhHhDYShlFlQ+ybT/+qkvGEYJavOQ4+6F6HjKuc0bC6EzgNAro MZm9uVC7HO4adR8aZ2wHvuGxd2dcmQ3xjTkgrrMnyZRVjbEwWXQX1QAGrApRtGHA8C kxYmAxtz7TBk6kzasXEnJ87EjuBwykzRjMZ51/RY=
Date: Sun, 15 Mar 2020 14:14:29 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4I5N5NMASFXC2GHPF4PJ53LEVBNHHCFICXXQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3521/review/374834365@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3521@github.com>
References: <quicwg/base-drafts/pull/3521@github.com>
Subject: Re: [quicwg/base-drafts] Recommend a 1ms timer granularity (#3521)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6e9ab54ec89_11323fd527ccd96821043e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lCNBOuTtLAagWGBxpgV0wv1tCSw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Mar 2020 21:14:32 -0000

martinthomson commented on this pull request.



> @@ -428,7 +428,8 @@ as TCP-NCR {{?RFC4653}}, to improve QUIC's reordering resilience.
 Once a later packet within the same packet number space has been acknowledged,
 an endpoint SHOULD declare an earlier packet lost if it was sent a threshold
 amount of time in the past. To avoid declaring packets as lost too early, this
-time threshold MUST be set to at least kGranularity.  The time threshold is:
+time threshold MUST be set to at least the local alarm granularity, as

```suggestion
time threshold MUST be set to at least the local timer granularity, as
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3521#pullrequestreview-374834365