Re: [quicwg/base-drafts] Core terminology in QPACK (#3520)

Lucas Pardue <notifications@github.com> Fri, 13 March 2020 16:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA9F43A0D81 for <quic-issues@ietfa.amsl.com>; Fri, 13 Mar 2020 09:18:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Ra_uL4kVZv1 for <quic-issues@ietfa.amsl.com>; Fri, 13 Mar 2020 09:18:40 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7F093A0D7A for <quic-issues@ietf.org>; Fri, 13 Mar 2020 09:18:40 -0700 (PDT)
Date: Fri, 13 Mar 2020 09:18:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584116319; bh=JcBh048Zk+BJt9oItKK4AKQm98tVp9BdPtRgrR/fz+A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Okr+evkwRni4VFEqgf+VEXVcBVQs5qtcJjqeSpwuEl0yxjaJ23+KEULi4zk6ggIhk MY2SYrD2R8cdDAh3vmtnSJWo4i1DbUmrXrp0wW6f51+9/lHDbs1frxtdZT4899TlCC YDusSvqHPhq/LSg6dkmgy6JOyzkqmqla0JHl2ln0=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4FUNBC3ZZAFGKUJW54O6JV7EVBNHHCFHBAYE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3520/review/374428682@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3520@github.com>
References: <quicwg/base-drafts/pull/3520@github.com>
Subject: Re: [quicwg/base-drafts] Core terminology in QPACK (#3520)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6bb25f6468d_28e43f9b402cd95c391d8"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mFHBLvYS5yh6Z14bSx-mDI6OvIU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2020 16:18:49 -0000

LPardue approved this pull request.

lgtm modulo nnnits

>  
-After the decoder finishes decoding a header block containing dynamic table
-references, it MUST emit a Header Acknowledgement instruction
-({{header-acknowledgement}}).  A stream may carry multiple header blocks in the
+After the decoder finishes decoding a field block containing dynamic table
+references, it MUST emit a Entry Acknowledgement instruction

```suggestion
references, it MUST emit an Entry Acknowledgement instruction
```

>  
-After processing a header block whose declared Required Insert Count is not
-zero, the decoder emits a Header Acknowledgement instruction.  The instruction
-begins with the '1' one-bit pattern which is followed by the header block's
+After processing a field block whose declared Required Insert Count is not
+zero, the decoder emits a Entry Acknowledgement instruction.  The instruction

```suggestion
zero, the decoder emits an Entry Acknowledgement instruction.  The instruction
```

>  
-If an encoder receives a Header Acknowledgement instruction referring to a
-stream on which every header block with a non-zero Required Insert Count has
+If an encoder receives a Entry Acknowledgement instruction referring to a

```suggestion
If an encoder receives an Entry Acknowledgement instruction referring to a
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3520#pullrequestreview-374428682