Re: [quicwg/base-drafts] Specify the PATH_CHALLENGE timer period (#3339)

ianswett <notifications@github.com> Fri, 17 January 2020 18:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A30E3120089 for <quic-issues@ietfa.amsl.com>; Fri, 17 Jan 2020 10:17:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7PLpfnV_oczw for <quic-issues@ietfa.amsl.com>; Fri, 17 Jan 2020 10:17:13 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D8D32120025 for <quic-issues@ietf.org>; Fri, 17 Jan 2020 10:17:12 -0800 (PST)
Date: Fri, 17 Jan 2020 10:17:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579285032; bh=s+xkf0Fmui5cnQWsB7t1ADMvbvwT0+CnKJe7II6MA7w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oBDUlqcFI3Yg99p1vjW44clqIlNIdbqs091IGlFf1ZHeJXG8MKD2LGyRSxUn2qCeV IU0iDdq0TBLZgKu7UOrU3Hjm4pA+OnqYadrDjU4IMEoXr9H8qGDjGTH4v07jc7BA1A 5c6ihBomrkf80UbwtopPcT0PfIMMu4dcUthG5pE4=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYYNWAN5VNVVZV633F4F4WKPEVBNHHCBPBXP4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3339/review/344755556@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3339@github.com>
References: <quicwg/base-drafts/pull/3339@github.com>
Subject: Re: [quicwg/base-drafts] Specify the PATH_CHALLENGE timer period (#3339)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e21fa281e04_1ade3f9c6fccd968133158"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mYkDVuOhlZsObcUyjdhL4kEPDps>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2020 18:17:20 -0000

ianswett commented on this pull request.



> @@ -2176,9 +2176,10 @@ path is no longer needed (such as the case in {{off-path-forward}}).
 A sender can make exceptions for probe packets so that their loss detection is
 independent and does not unduly cause the congestion controller to reduce its
 sending rate.  An endpoint might set a separate timer when a PATH_CHALLENGE is
-sent, which is cancelled when the corresponding PATH_RESPONSE is received.  If
-the timer fires before the PATH_RESPONSE is received, the endpoint might send a
-new PATH_CHALLENGE, and restart the timer for a longer period of time.
+sent, which is cancelled if the corresponding PATH_RESPONSE is received or a

Agreed, that was awkward, thanks for the suggestions.  Accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3339#discussion_r368070267