Re: [quicwg/base-drafts] Specify the PATH_CHALLENGE timer period (#3339)

Jana Iyengar <notifications@github.com> Thu, 16 January 2020 21:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7234312004A for <quic-issues@ietfa.amsl.com>; Thu, 16 Jan 2020 13:48:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zs-xxT3-eoGh for <quic-issues@ietfa.amsl.com>; Thu, 16 Jan 2020 13:48:28 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A04C12004C for <quic-issues@ietf.org>; Thu, 16 Jan 2020 13:48:28 -0800 (PST)
Date: Thu, 16 Jan 2020 13:48:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579211307; bh=jfc5I6aJm+IKivVAeS9LXhpb8T1PxsbVYQ9NFnfw0Bs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=r3e+HIqzm5A5VAzMYL6tOwh3vfqqCXT1nGPIEB4+PEB2AAXOVu1YksdV+vW4bLG71 Z5VjNWiiC9vXq7Lafp0jb0F3SJ1xm8ft0fUh3em+NcOhhEizMjjxyAHCdn72GXHGjI /8t5gH1QjkVRbDIdtPzpgsY8+CVLjKRAb5FSE+d0=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZMHTA7TLQIW4SKVMF4FYGKXEVBNHHCBPBXP4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3339/review/344237130@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3339@github.com>
References: <quicwg/base-drafts/pull/3339@github.com>
Subject: Re: [quicwg/base-drafts] Specify the PATH_CHALLENGE timer period (#3339)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e20da2b5f2b9_63bc3fc30b2cd9641273b8"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/x5dYFW1A1soAQIv14u7VJH7VAYI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jan 2020 21:48:31 -0000

janaiyengar commented on this pull request.

This can be simpler -- just add the new sentence. I've made suggestions.

> @@ -2176,9 +2176,10 @@ path is no longer needed (such as the case in {{off-path-forward}}).
 A sender can make exceptions for probe packets so that their loss detection is
 independent and does not unduly cause the congestion controller to reduce its
 sending rate.  An endpoint might set a separate timer when a PATH_CHALLENGE is
-sent, which is cancelled when the corresponding PATH_RESPONSE is received.  If
-the timer fires before the PATH_RESPONSE is received, the endpoint might send a
-new PATH_CHALLENGE, and restart the timer for a longer period of time.
+sent, which is cancelled if the corresponding PATH_RESPONSE is received or a

```suggestion
sent, which is cancelled if the corresponding PATH_RESPONSE is received. If
```

> @@ -2176,9 +2176,10 @@ path is no longer needed (such as the case in {{off-path-forward}}).
 A sender can make exceptions for probe packets so that their loss detection is
 independent and does not unduly cause the congestion controller to reduce its
 sending rate.  An endpoint might set a separate timer when a PATH_CHALLENGE is
-sent, which is cancelled when the corresponding PATH_RESPONSE is received.  If
-the timer fires before the PATH_RESPONSE is received, the endpoint might send a
-new PATH_CHALLENGE, and restart the timer for a longer period of time.
+sent, which is cancelled if the corresponding PATH_RESPONSE is received or a
+new PATH_CHALLENGE is sent if it expires before receiving a PATH_RESPONSE.

```suggestion
the timer fires before the PATH_RESPONSE is received, the endpoint might send a
new PATH_CHALLENGE, and restart the timer for a longer period of time. 
```

> @@ -2176,9 +2176,10 @@ path is no longer needed (such as the case in {{off-path-forward}}).
 A sender can make exceptions for probe packets so that their loss detection is
 independent and does not unduly cause the congestion controller to reduce its
 sending rate.  An endpoint might set a separate timer when a PATH_CHALLENGE is
-sent, which is cancelled when the corresponding PATH_RESPONSE is received.  If
-the timer fires before the PATH_RESPONSE is received, the endpoint might send a
-new PATH_CHALLENGE, and restart the timer for a longer period of time.
+sent, which is cancelled if the corresponding PATH_RESPONSE is received or a

It's not clear what the "or" applies to.  You can undo the changes and simply add your new sentence at the end; see my suggestions below.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3339#pullrequestreview-344237130