Re: [quicwg/base-drafts] Unifying words in recovery draft (#3893)
Martin Thomson <notifications@github.com> Tue, 14 July 2020 06:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3557B3A1149 for <quic-issues@ietfa.amsl.com>; Mon, 13 Jul 2020 23:34:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XWZsB6fGmYD9 for <quic-issues@ietfa.amsl.com>; Mon, 13 Jul 2020 23:34:01 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A58C23A1148 for <quic-issues@ietf.org>; Mon, 13 Jul 2020 23:34:01 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id E1E4D6A03B2 for <quic-issues@ietf.org>; Mon, 13 Jul 2020 23:34:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594708440; bh=Pen+iznH0nckJzFBkprm0whcpDozUI2U6yKcX/1uL5k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=a0ZRkvQmMY1ozvuH23SJybiwpFrwAW/JZ4y+hEQxwWUULVCp+/Zxj6iZekMwNeEtF 3cJwyst5koYBSYKr3a3vDeuIBAHZy94e19lFmJb1H3Rf0ezMrpm5YhMWXu4esflWaz igl5YsUC4nv7mC5kNlUjYB8Rw40psz7HAypNtIgI=
Date: Mon, 13 Jul 2020 23:34:00 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK22AZQWZXGUTHDJHP55DEZNREVBNHHCOEWZDQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3893/review/447822856@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3893@github.com>
References: <quicwg/base-drafts/pull/3893@github.com>
Subject: Re: [quicwg/base-drafts] Unifying words in recovery draft (#3893)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0d51d8c2300_6ff93f92320cd95c3371e1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mwCUYvyzZ8_7-MUFoXYuXYVXfCc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2020 06:34:03 -0000
@martinthomson approved this pull request.
I think that "toward" is acceptable usage, otherwise, this is good.
> @@ -615,7 +615,7 @@ a packet containing unacknowledged CRYPTO data earlier than the PTO expiry,
subject to address validation limits; see Section 8.1 of {{QUIC-TRANSPORT}}.
Peers can also use coalesced packets to ensure that each datagram elicits at
```suggestion
Endpoints can also use coalesced packets to ensure that each datagram elicits at
```
> congestion control limits and are considered in-flight.
-* PADDING frames cause packets to contribute toward bytes in flight without
+* PADDING frames cause packets to contribute towards bytes in flight without
```suggestion
* PADDING frames cause packets to contribute toward bytes in flight without
```
> @@ -145,10 +145,10 @@ of frames contained in a packet affect recovery and congestion control logic:
performance of the QUIC handshake and use shorter timers for
acknowledgement.
-* Packets containing frames besides ACK or CONNECTION_CLOSE frames count toward
+* Packets containing frames besides ACK or CONNECTION_CLOSE frames count towards
I think that the original is correct.
```suggestion
* Packets containing frames besides ACK or CONNECTION_CLOSE frames count toward
```
> @@ -615,7 +615,7 @@ a packet containing unacknowledged CRYPTO data earlier than the PTO expiry,
subject to address validation limits; see Section 8.1 of {{QUIC-TRANSPORT}}.
Peers can also use coalesced packets to ensure that each datagram elicits at
-least one acknowledgement. For example, clients can coalesce an Initial packet
+least one acknowledgement. For example, a client can coalesce an Initial packet
I think that "a client" and "a server" are best here. The previous sentence is general, this is an example and therefore specific.
That said, we are almost certainly hugely inconsistent about addressing requirements to "endpoints" (plural) or "an endpoint" (singular).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3893#pullrequestreview-447822856
- [quicwg/base-drafts] Unifying words in recovery d… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Marten Seemann
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Martin Thomson
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Martin Thomson
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Kazu Yamamoto
- Re: [quicwg/base-drafts] Unifying words in recove… Martin Thomson
- Re: [quicwg/base-drafts] Unifying words in recove… Martin Thomson
- Re: [quicwg/base-drafts] Unifying words in recove… Jana Iyengar
- Re: [quicwg/base-drafts] Unifying words in recove… Jana Iyengar