IETF Logo Mail Archive

Re: [quicwg/base-drafts] Only ack headers that have non-zero declared Largest Reference (#1605)

Martin Thomson <notifications@github.com> Tue, 31 July 2018 06:58 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 59011130DC7 for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 23:58:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zA4mKuRY0WJq for <quic-issues@ietfa.amsl.com>; Mon, 30 Jul 2018 23:58:08 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9B34F12DD85 for <quic-issues@ietf.org>; Mon, 30 Jul 2018 23:58:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=598uLyzvwR6oqUjfH5q2QR7KzsY=; b=f2Cq8NNx/zi2AcCA wM+tazD9zrGgGmlyyt+HDNVaGAPVzUc7BJQEOY/FwQGAFHkn6I1q+3QRC9s9FqFU O2gGKZI4I9wOyoJd3jqLzKtGBLUtAhDr/WvM/a1c6M42o8jaeiR+7LYoPS8gdSvk tqcU/lhWJmaDehCk6bagiIGIxlI=
Received: by filter1094p1las1.sendgrid.net with SMTP id filter1094p1las1-3425-5B60087D-E 2018-07-31 06:58:05.850941184 +0000 UTC m=+462612.213840699
Received: from github-lowworker-1f7e42f.cp1-iad.github.net (unknown [192.30.252.46]) by ismtpd0019p1iad2.sendgrid.net (SG) with ESMTP id 5AJ7aYJiR2K6Bt-VvyW2EQ for <quic-issues@ietf.org>; Tue, 31 Jul 2018 06:58:05.699 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1f7e42f.cp1-iad.github.net (Postfix) with ESMTP id A42A5C0A5E for <quic-issues@ietf.org>; Mon, 30 Jul 2018 23:58:05 -0700 (PDT)
Date: Tue, 31 Jul 2018 06:58:06 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba001331cc01239ad5bffebeaf340f3fc6840d61192cf000000011777ca7d92a169ce14885428@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1605/c409116077@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1605@github.com>
References: <quicwg/base-drafts/pull/1605@github.com>
Subject: Re: [quicwg/base-drafts] Only ack headers that have non-zero declared Largest Reference (#1605)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b60087da239d_645e3fda2bed45b44976cd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3pFb/bDr4iAEmyVufIiu28IppkK1fsKVG1ux roNJPI+OGEXps8KNSVWZhGkCe8CSi8Xgdz41WGiyirWjFAWbTGVOyohF9dee3D+JXT4JOHPuxF2xa6 gfgQKJ1qu0apc9qXrjSE/OoqX7lQJgtH0ifSrfns9PRIuDC6QS+iXYD67+tdSSJIJtAvQXBAMXXbIw A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/n81vuZLqovtqSJ965BFqVUa3Tao>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 06:58:09 -0000

I implemented this just now and it was simple enough.  And it saves a few octets in some critical cases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1605#issuecomment-409116077

v2.23.0 | Report a Bug | By Email