IETF Logo Mail Archive

Re: [quicwg/base-drafts] allow dropping of Initial packets with invalid reserved bits (#2053)

ekr <notifications@github.com> Mon, 26 November 2018 13:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0DA21130DD0 for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 05:28:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OI3rLYxjXK5R for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 05:28:27 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 513AA12D4ED for <quic-issues@ietf.org>; Mon, 26 Nov 2018 05:28:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=8AJi84AZ9UhyaS9X1gZqdX5xDQ0=; b=aZc180XKzCElQtN+ 88Y4yB6xzkKcRR/sGmbk1ANtobDxSHmwdHI9Sokqy75E2P41Yy11dNCNUam6AjHn QgMGwALX/fTILupOHijrKQ7ikCh27JCmAg7h90XxtSCW2V0kRG7iB2zm66I6YoHL 4thxB9cAdJhNoVg3g7+ApUasDv0=
Received: by filter1696p1mdw1.sendgrid.net with SMTP id filter1696p1mdw1-16233-5BFBF4F8-C 2018-11-26 13:28:24.253447018 +0000 UTC m=+763465.256307801
Received: from github-lowworker-fc273f0.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0029p1mdw1.sendgrid.net (SG) with ESMTP id Vyi9Q7qwTZ-9emcvb_stuw for <quic-issues@ietf.org>; Mon, 26 Nov 2018 13:28:24.241 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-fc273f0.cp1-iad.github.net (Postfix) with ESMTP id 35B0EC00A1 for <quic-issues@ietf.org>; Mon, 26 Nov 2018 05:28:24 -0800 (PST)
Date: Mon, 26 Nov 2018 13:28:24 +0000
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab51c421e0b64f6bae3f3ddd80d947cdf5b1443ce292cf000000011813b6f892a169ce16e78b2d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2053/c441638613@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2053@github.com>
References: <quicwg/base-drafts/pull/2053@github.com>
Subject: Re: [quicwg/base-drafts] allow dropping of Initial packets with invalid reserved bits (#2053)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfbf4f833d42_6b5d3f9f6b2d45c032246b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1HPBERucBXp75sENItcaKIcW/F8fmE9RW3KE wH+Bk3QSsoG+vd7Am0Jok1TboNfxrnD/zQK8YLkciXsOFdt02QKciVfnEtxqiM4S+wNGKaoJAjWMDl gCmREuxRzVm1Fz3bR0HGhvvguL11SAnw9SkNtM7cmrTNxiAHWf1nfw/MjA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nr2YENacF7SXWGgT0hufqOxEGGg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Nov 2018 13:28:29 -0000

I don't see what this is buying us. In order to generate a packet which deprotects successfully but has bogus reserved bits, the attacker must know the CID, which effectively means it must be on-path. Such an attacker can easily generate a packet with correct reserved bits but bogus content (or an error). Can you please describe the scenario you are concerned about?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2053#issuecomment-441638613

v2.23.0 | Report a Bug | By Email