IETF Logo Mail Archive

Re: [quicwg/base-drafts] Push SHOULD precede reference (#2704)

ianswett <notifications@github.com> Wed, 15 May 2019 20:14 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0131B1201D5 for <quic-issues@ietfa.amsl.com>; Wed, 15 May 2019 13:14:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.606
X-Spam-Level:
X-Spam-Status: No, score=-1.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e83sLI7sF-UX for <quic-issues@ietfa.amsl.com>; Wed, 15 May 2019 13:14:41 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B0C1C1200D8 for <quic-issues@ietf.org>; Wed, 15 May 2019 13:14:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=/YA6Hg410IFlexSCeLiA7ShDAE0=; b=WUPo9MCqIpfnJnNW 2Z628jof0LbDs936czHJsRVBz7AA1WAWna9JTQQwnGcxVz8BO9r324uqL3NF/em7 kLj86oUwDS/SxuWnH2jh2M47x3V6u9Of0nx62K5EQW33EIMErTbSkFeHMWxHTZcw ffEOKOf62r7KLeeL0Q6J9rSXZMo=
Received: by filter0713p1las1.sendgrid.net with SMTP id filter0713p1las1-30144-5CDC732F-5 2019-05-15 20:14:39.117857265 +0000 UTC m=+167813.206574853
Received: from github-lowworker-dc5ea3e.cp1-iad.github.net (unknown [140.82.115.70]) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id OwhaTGbTQzmIW1M-RqajKQ for <quic-issues@ietf.org>; Wed, 15 May 2019 20:14:38.905 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dc5ea3e.cp1-iad.github.net (Postfix) with ESMTP id D1BC1260971 for <quic-issues@ietf.org>; Wed, 15 May 2019 13:14:38 -0700 (PDT)
Date: Wed, 15 May 2019 20:14:39 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7ADDWVWU7JDZQAWQ525GS25EVBNHHBU74FEE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2704/review/238046624@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2704@github.com>
References: <quicwg/base-drafts/pull/2704@github.com>
Subject: Re: [quicwg/base-drafts] Push SHOULD precede reference (#2704)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cdc732ed04ea_33e53fea220cd964392e3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0yOYcc60PhYSUftIP3l2UExaL6A4RthXNtgg ceeFROfquuwdQAc4hUq+sI4oi6+iinXA95CXACLmjU/AO8xS7H7PQPNFGDO5ak4fBpeV+lYGSNwEhC 0cv6igr8RuFbNNXLNTPDS3xQZPYPFy4hB6MuawRDbipa73HhlHVahqNHMQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pM0g7J6qK2KVwOIaeOaEAtsEjtA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 May 2019 20:14:43 -0000

ianswett commented on this pull request.



>  
 The same server push can be associated with additional client requests using a
-DUPLICATE_PUSH frame (see {{frame-duplicate-push}}).  Ordering of a
-DUPLICATE_PUSH in relation to certain parts of the response is similarly
-important.
+DUPLICATE_PUSH frame (see {{frame-duplicate-push}}).
+
+Ordering of a PUSH_PROMISE or DUPLICATE_PUSH in relation to certain parts of the
+response is important. The server SHOULD send PUSH_PROMISE or DUPLICATE_PUSH
+frames prior to sending any frames that reference the promised responses.  This

```suggestion
frames prior to sending any DATA frames that reference the promised responses.  This
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2704#pullrequestreview-238046624

v2.23.0 | Report a Bug | By Email