IETF Logo Mail Archive

Re: [quicwg/base-drafts] Prevent int underflow (#2065)

Martin Thomson <notifications@github.com> Wed, 28 November 2018 23:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 88E251310C2 for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 15:57:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5spBHQ321y97 for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 15:57:01 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AAAC71310C3 for <quic-issues@ietf.org>; Wed, 28 Nov 2018 15:57:01 -0800 (PST)
Date: Wed, 28 Nov 2018 15:56:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543449419; bh=YJx80AhtgHzOwQqvCS/ekrhp9t3kOWMVo8fX2ZKjadI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=gDvOydo4YZ1epNMZYzU1KVucjos3HMDYiko+7JgrK1y1s6JxB/XUNEic4n+wwx7te hgYFNYviEyG+2ahUurQhiWNeKNOAKkCt8t6/zsPGHmh7Z7u4sFmveTWW0P2LV5Anpx HHEGjVG7QeK6pO/+onFbE9B+rBBbaGWK6yTO7XEM=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abba0ef0d5b00570a5718ddf83804e24583d2664b192cf000000011816ed4b92a169ce16f9c086@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2065/review/179574787@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2065@github.com>
References: <quicwg/base-drafts/pull/2065@github.com>
Subject: Re: [quicwg/base-drafts] Prevent int underflow (#2065)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bff2b4be7e46_2753fe3958d45c49778"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qYYItln65BtcVSKuMcNBATEP_nw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 23:57:05 -0000

martinthomson commented on this pull request.



> @@ -848,8 +848,8 @@ Pseudocode for SetLossDetectionTimer follows:
       return
     if (loss_time != 0):
       // Early retransmit timer or time loss detection.
-      timeout = loss_time -
-        time_of_last_sent_retransmittable_packet
+      loss_detection_timer.set(loss_time)
+      return
     else:

You don't need an else clause if you are going to exit.  But this might set the timer to some time in the past if we're not careful with setting loss_time.  I have a PR that might help inbound.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2065#pullrequestreview-179574787

v2.23.0 | Report a Bug | By Email