Re: [quicwg/base-drafts] Most the Retry-related fixes (#1788)

[ianswett <[e-mail]>]

ianswett commented on this pull request.

Thanks Martin, looks good.

> @@ -593,37 +593,40 @@ The server populates the Destination Connection ID with the connection ID that
 the client included in the Source Connection ID of the Initial packet.
 
 The server includes a connection ID of its choice in the Source Connection ID
-field.  The client MUST use this connection ID in the Destination Connection ID
-of subsequent packets that it sends.
+field.  This value MUST not be equal to the Destination Connection ID field of

So the server HAS to change connection ID with a Retry?  I have no problem with that, but I wasn't sure where that ended up previously.

>  
-A Retry packet does not include a packet number and cannot be explicitly
-acknowledged by a client.
+A server MAY send Retry packets in response to Initial and 0-RTT packets.  A
+server can either discard or buffer 0-RTT packets that it receives.  A server

Below, you're advising that the client changes crypto context in response to Retry, so buffering 0RTT packets is likely to be useless, correct?

Retry is really meant for cheap DDoS, so if we want this to work well, I think we should spend more time thinking about how to make it work well.  I suspect we don't care and should just advise dropping 0RTT packets if you're sending a Retry?

>  
-A server MUST NOT send a Retry in response to packets other than Initial
-or 0-RTT packets.  A server MAY choose to only send Retry in response to Initial
-packets and discard or buffer 0-RTT packets corresponding to unvalidated client
-addresses.
+A client MUST accept and process at most one Retry packet for each connection

This MUST is a bit strong for me when thinking of man-on-the-side, especially since you don't respond to cases when the original dcid doesn't match, but it's Ok for now since mots is out of scope for v1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1788#pullrequestreview-157937587