Re: [quicwg/base-drafts] Merge crypto timeout into PTO (#2655)

Jana Iyengar <notifications@github.com> Sun, 28 April 2019 07:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D031F1200A1 for <quic-issues@ietfa.amsl.com>; Sun, 28 Apr 2019 00:04:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.384
X-Spam-Level:
X-Spam-Status: No, score=-6.384 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E0iqhe9p8yGl for <quic-issues@ietfa.amsl.com>; Sun, 28 Apr 2019 00:04:48 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A686D120094 for <quic-issues@ietf.org>; Sun, 28 Apr 2019 00:04:48 -0700 (PDT)
Date: Sun, 28 Apr 2019 00:04:47 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1556435087; bh=cMAqeCBZatMzPKN28Zjw+IRlGuXyWdzVmDzxXozCTAg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qtNcnSwS7kylY412yHnb8BtRBSy2HaPJ94CCpRT6J/QLySo+ltejKvF+YyngaVRbt bAGOW6s409c+P8/he3a8+XEUOr5ufSpPC5iXAcLDfEsrX2JEY6bkaXwkMC36vYQ8tH M33tjx5ndsJgxQy8OebbX75mezMzNvFIbvd2nc78=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5VBZHOEADEPDDVFKV22KBQ7EVBNHHBUGOXBA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2655/review/231452091@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2655@github.com>
References: <quicwg/base-drafts/pull/2655@github.com>
Subject: Re: [quicwg/base-drafts] Merge crypto timeout into PTO (#2655)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cc5508f58622_31a43fbbd0ecd968436068"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rvFfGOHTcW5wrdtCW44OQ2thMus>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Apr 2019 07:04:51 -0000

janaiyengar approved this pull request.

Gah! I hate it when these diffs are so broken. I've gone over it, and I assume that this basically just moved text (and removed some unnecessary text), right? I want to do an editorial pass, but it might be best to do that once this is in. Go ahead and merge after you've fixed the merge issue.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2655#pullrequestreview-231452091