Re: [quicwg/base-drafts] Define the use of generic TLS alerts (#3601)

Mike Bishop <notifications@github.com> Tue, 28 April 2020 18:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 043BF3A09A5 for <quic-issues@ietfa.amsl.com>; Tue, 28 Apr 2020 11:46:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d6c7tHhPl9C7 for <quic-issues@ietfa.amsl.com>; Tue, 28 Apr 2020 11:46:37 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0AFEA3A09CC for <quic-issues@ietf.org>; Tue, 28 Apr 2020 11:46:36 -0700 (PDT)
Received: from github-lowworker-ca5950c.va3-iad.github.net (github-lowworker-ca5950c.va3-iad.github.net [10.48.17.57]) by smtp.github.com (Postfix) with ESMTP id 3C051E05EE for <quic-issues@ietf.org>; Tue, 28 Apr 2020 11:46:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1588099596; bh=QMWcBvMA+M2o0SyeBe5x8s4Vxn8aeY6z/V2dwVFuoD0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JhyTGJqjAxqcLfXoS8dnlyBN9lb8R/xM285M13WWcbOJAhUnAoIKHoAGFwjipM05l 6pZ1U9XWi3719JjKaUVZ0xz/lYoCfnFwHlHXvU214NNhCgCJp+X/CTlcoOBILTO3T9 S6zeiW5LWOi53XbBY72ANY836OJqEkD835In5jxQ=
Date: Tue, 28 Apr 2020 11:46:36 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ44CDEYFN4JROI3NV4WRNQZEVBNHHCIPNKJY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3601/review/402115147@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3601@github.com>
References: <quicwg/base-drafts/pull/3601@github.com>
Subject: Re: [quicwg/base-drafts] Define the use of generic TLS alerts (#3601)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ea87a0c2cfaf_40013f8a106cd96c32288"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/u9RWtriI4uPkaHO9pPuG_HBCtdY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 18:46:46 -0000

@MikeBishop commented on this pull request.



> +10.3 of {{QUIC-TRANSPORT}}) if an application protocol is not negotiated with a
+no_application_protocol TLS alert (QUIC error code 0x178, see {{tls-errors}}).

```suggestion
10.3 of {{QUIC-TRANSPORT}}) with a no_application_protocol TLS alert (QUIC
error code 0x178, see {{tls-errors}}) if an application protocol is not negotiated.
```
"close a connection with... if..." makes it clearer which phrase the "with" applies to.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3601#pullrequestreview-402115147