Re: [quicwg/base-drafts] MUST pace or limit bursts to 10 packets (#3106)

MikkelFJ <notifications@github.com> Fri, 18 October 2019 04:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2658120044 for <quic-issues@ietfa.amsl.com>; Thu, 17 Oct 2019 21:56:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c5-fGSbwwGXm for <quic-issues@ietfa.amsl.com>; Thu, 17 Oct 2019 21:56:17 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B08C120024 for <quic-issues@ietf.org>; Thu, 17 Oct 2019 21:56:17 -0700 (PDT)
Date: Thu, 17 Oct 2019 21:56:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571374576; bh=ibpSuxvEaKlYofTcA8gprimvn5XmHhYS0x+ltRr2z4o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SV3evPwMAoOtfEx4tFwX7Rd4LFGWgqz/6iDjf/IcNe1tFc1tKD3dm9E0PZRfnKss/ 8haUBSaVNyNiX7Phf29X1Beq4H3t8156EN7nvqXOSbmTki04m1UgqLf4hn7aKNA7XH ziTP+9H3dPvLSSOgaDEeLe//m86jWYgrITkDs6fU=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7ROQKHUBWSENAPLP53W2DIBEVBNHHB4SPHCQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3106/review/303664818@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3106@github.com>
References: <quicwg/base-drafts/pull/3106@github.com>
Subject: Re: [quicwg/base-drafts] MUST pace or limit bursts to 10 packets (#3106)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da945f016027_7bba3f946d2cd9681380c7"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/uZ4sIAaOCu9L8fCmjO1ib9-L_RA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Oct 2019 04:56:19 -0000

mikkelfj commented on this pull request.



> @@ -753,6 +753,12 @@ delivery of ACK frames is important for efficient loss recovery. Packets
 containing only ACK frames should therefore not be paced, to avoid delaying
 their delivery to the peer.
 
+Sending multiple packets into the network without any delay between them
+creates a packet burst that might cause short-term congestion and losses.
+Implementations MUST either use pacing or limit such bursts to minimum

to minimum -> to the minimum

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3106#pullrequestreview-303664818