Re: [quicwg/base-drafts] Placeholder -1 (#2690)

ianswett <notifications@github.com> Fri, 10 May 2019 18:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D232C12000E for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 11:41:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.606
X-Spam-Level:
X-Spam-Status: No, score=-1.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ffBzC412ft9i for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 11:41:16 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4AE4120229 for <quic-issues@ietf.org>; Fri, 10 May 2019 11:41:16 -0700 (PDT)
Date: Fri, 10 May 2019 11:41:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557513675; bh=9zJKSt7uPtaMVwCduVDdO3PUnzIFfJAgdlSjQVAmhZc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tUg0HY0x8FuAWdc7RRqsATUVS4V3ugU3BK7qDdWptHjVeBsVfX9nZID2UgabxXd1a JK3U/aCTlGmCXdEGqm7TTGjqR9Ei29jj0ooI853fBFOeUUZyev8lqzpJF+o1vXtiXD ntijMcmR8djBrLrEB0WZkACaW/ASUXFY8gpkWaCg=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2VGYM5FXUE34VLN7N24L4EXEVBNHHBUZJ65I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2690/review/236256709@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2690@github.com>
References: <quicwg/base-drafts/pull/2690@github.com>
Subject: Re: [quicwg/base-drafts] Placeholder -1 (#2690)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd5c5cba27ca_2df33fc0fb6cd9681167db"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vFQz38ZN335p0uEprgJY1eSSNBE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2019 18:41:19 -0000

ianswett commented on this pull request.



> +cannot be reprioritized.  The structure of the dependency tree changes as
+PRIORITY frames modify the dependency links between other prioritized elements.
+
+All dependent streams are allocated an integer weight between 0 and 255
+(inclusive).
+
+Streams with the same parent SHOULD be allocated resources proportionally based
+on their weight.  Thus, if stream B depends on stream A with weight 4, stream C
+depends on stream A with weight 12, and no progress can be made on stream A,
+stream B ideally receives one-third of the resources allocated to stream C.
+
+A weight of zero indicates that no resources should be allocated to the
+indicated stream if progress can be made on other streams dependent on the same
+parent.
+
+A reference to an element which is no longer in the tree is treated as a

If I read this correctly, if I reference stream 10 in a priority frame for stream 100 and you've removed all state for 10, 100 gets no resources whatsoever until all other requests finish?

That seems awful, so I must be missing something.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2690#pullrequestreview-236256709