Re: [quicwg/base-drafts] Fix QPACK-04 changelog: add two non-editorial changes (#2102)

Dmitri Tikhonov <notifications@github.com> Thu, 13 December 2018 13:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 175441288BD for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 05:24:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uUI2efqFa6Zs for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 05:24:32 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3EDA8127332 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 05:24:32 -0800 (PST)
Date: Thu, 13 Dec 2018 05:24:31 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544707471; bh=LE1Xxyn14Q2ZB66pk/Rt1g8ujaaTZwiXcsDi/Rocs3U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dWzMWc0UMImJ1gItzE1nfvD/gEHopgG9DJQLWBeZ8QVr5KPUCzCiXHKgRmdyDFk3M Yh37EI41WzcrljW+Yi9DJ3eOQOTzkhcIGAbjYAuIQvqabg7LTVgLJp00Y+LazKLmdN RRo/4DOe3HpEP/Ic/uB9a4c1ujnf43kJO34ky+G0=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfd5763e5baa41741c67ec6b8d7d4be291a0b1bc292cf00000001182a1f8f92a169ce1723d5fa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2102/review/184657572@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2102@github.com>
References: <quicwg/base-drafts/pull/2102@github.com>
Subject: Re: [quicwg/base-drafts] Fix QPACK-04 changelog: add two non-editorial changes (#2102)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c125d8f55a09_79b63ff6634d45c44667bf"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zWzbjBCgQfcTsnJIgA95nQwqPtE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 13:24:36 -0000

dtikhonov commented on this pull request.



> @@ -1254,7 +1254,9 @@ return controlBuffer, prefixBuffer + streamBuffer
 
 ## Since draft-ietf-quic-qpack-03
 
-Substantial editorial reorganization; no technical changes.
+- Avoid having multiple ways to encode Delta Base Index of zero (#2005)

Fixed.  Thanks, @martinthomson!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2102#discussion_r241397155