Re: AD review : draft-ietf-quic-bit-grease-02

David Schinazi <dschinazi.ietf@gmail.com> Thu, 12 May 2022 23:47 UTC

Return-Path: <dschinazi.ietf@gmail.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2DB17C159A2E for <quic@ietfa.amsl.com>; Thu, 12 May 2022 16:47:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.097
X-Spam-Level:
X-Spam-Status: No, score=-7.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mFO-_vFOsrAg for <quic@ietfa.amsl.com>; Thu, 12 May 2022 16:47:41 -0700 (PDT)
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5365CC159A2D for <quic@ietf.org>; Thu, 12 May 2022 16:47:41 -0700 (PDT)
Received: by mail-pj1-x1029.google.com with SMTP id c1-20020a17090a558100b001dca2694f23so6247633pji.3 for <quic@ietf.org>; Thu, 12 May 2022 16:47:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zXQtYj89x6S9CsT0JfB7kQ9h6u0+k+7TAKjKPhaCpSw=; b=M1vnuYVp0ngw2OGIN4Vycax8W15A91y/cBIQpbIoR/vZTYsSmv0HhgI4sHEkRheTeA FOQ6afaJs6qibRsP1WZt51WHbHbUxgEpsXh3LQ/qM2MHCv6PW3Qmw4GMPhgTDX7p7QyE Yxc8Y1MTweFGSwoYSyLeM0M0ZnE5AKrWG+F9dGodpXsZSSdH1px5VrP/oFRWy+pup8dh YR1N63/CukwwO8ZK3L4Vc4SlRyCZKyokDMlYyAyMtfT9hhRlDHVA/8n51g6oTQzp3427 1wdII5xymBIjaSLjEwS06fkziadIE0rzcUA1zKocuNP2DGMXg+Ot5YzE1NHeAOx6w0Jn MtFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zXQtYj89x6S9CsT0JfB7kQ9h6u0+k+7TAKjKPhaCpSw=; b=efzLYHUKSKTkTcK+V//HWFRJNAD2u7mpKCbKEseKfrYpXCIklwdU2FrYWAlftWXdwB i+pGpy1pysMfP8HyFeVQxkVY/GgUyc0ejwADA1MejC8U4/m/h1gWfwYMFh0KhztZfWSA 1+rG/8EzZRI8c+vq9VzuKxI03onH3sHMzmArg8FhF6qd/d4JOjaX93EOeU7LdipqWGM9 LCM6UlAAB3FzVOKnnwaARO8eQcHqXzBNPhTU27kf3Xq+pojKB9fbbsoxfbnUcLEI/o3e KsMuTVprch9FKky//J7p61kf2HaQxdyz89sC6+0DdoL4wzx9A8IClIKrMhwiQHXXGrDt /EKw==
X-Gm-Message-State: AOAM533pcivx+HW+dcnSZ+fVlo7voBNWnzySCeEAZ2u/Iz0Mrq/MX/9x YDUD33AYabTEkcuO4QKax+5/cE8AuTv7vf9DoE+H+Qil
X-Google-Smtp-Source: ABdhPJwYYgZvWL3jtmJ065IFCTTGuVjPuD+miBQF3iVGkYt/g0QlVb19/JBgF4SIeZ55UF8OcTmBsI3j4NHQcHDcyqE=
X-Received: by 2002:a17:90b:1e49:b0:1dc:81d9:2d97 with SMTP id pi9-20020a17090b1e4900b001dc81d92d97mr13273469pjb.221.1652399260125; Thu, 12 May 2022 16:47:40 -0700 (PDT)
MIME-Version: 1.0
References: <E622BA01-2890-498D-87CA-37EDB0F54F67@ericsson.com> <642ef7c0-82fc-4336-9300-caea2fb927aa@beta.fastmail.com> <1871AA6F-D8C2-4B49-BF5C-D4559BA8E7FA@ericsson.com> <b2b70599-f0ce-4e71-a698-d024a63d55a0@beta.fastmail.com>
In-Reply-To: <b2b70599-f0ce-4e71-a698-d024a63d55a0@beta.fastmail.com>
From: David Schinazi <dschinazi.ietf@gmail.com>
Date: Thu, 12 May 2022 16:47:28 -0700
Message-ID: <CAPDSy+5eghqFkcQatVfJfX8uZEZOJa=DcPj6CdWSxyqwwJ+QFg@mail.gmail.com>
Subject: Re: AD review : draft-ietf-quic-bit-grease-02
To: Martin Thomson <mt@lowentropy.net>
Cc: QUIC <quic@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000ed4db505ded92ebf"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/9FL_KlaLqeBXGezYwOFBqjgIkWg>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2022 23:47:45 -0000

Oh. I hadn't realized that this allowed greasing handshake & 0-RTT.
I think that's a great feature, but I might suggest mentioning it in as
many words to avoid any confusion.

David

On Thu, May 12, 2022 at 4:33 PM Martin Thomson <mt@lowentropy.net> wrote:

> Hey folks,
>
> David just provided some feedback on this that suggested a more
> comprehensive rewrite.  In case you looked already, you might want to take
> another peek.  One consequence of that change is that clearing the bit is
> now also possible on 0-RTT and Handshake packets, which might have been how
> people implemented this (that's what I did).
>
> Cheers,
> Martin
>
> On Thu, May 12, 2022, at 16:58, Zaheduzzaman Sarker wrote:
> > Hello all,
> >
> > Martin and me has chatted about the 7 day rule and it appeared that not
> > following the rule would actually lead to connection failure. Hence,
> > this actually should be a MUST. See the pull request
> > https://github.com/quicwg/quic-bit-grease/pull/24.
> >
> > Please reflect on this change by the end of next week (20th May, 2022)
> > along with any thoughts regarding the 7 (day) number. Unless any
> > critical issue found, after that I will consider the AD review issues
> > are resolved and move the doc to IETF LC.
> >
> > //Zahed
> >
> >
> >> On 28 Apr 2022, at 04:33, Martin Thomson <mt@lowentropy.net> wrote:
> >>
> >> Thanks Zahed.
> >>
> >> I've added references as you suggest and reworded some of the intro
> (fewer words!)
> >>
> >> You asked about the 7 day thing, which is almost entirely arbitrary.
> QUIC doesn't time limit NEW_TOKEN in any way, so this time is only
> necessary to avoid unbounded use of the mechanism (which might prevent a
> server from ever disabling greasing).  It's aligned with TLS requirements
> for session tickets, because that is likely natural for client
> implementations, but it is still ultimately an arbitrary value.  We can say
> that much, but I don't think we need to.
> >>
> >> On Wed, Apr 27, 2022, at 20:09, Zaheduzzaman Sarker wrote:
> >>> Hi,
> >>>
> >>> Thanks for the short and nice draft.
> >>>
> >>> I have done my AD review. I haven’t noticed any technical issues so
> >>> far. However, I have some editorial comments and I have created issues
> >>> for those (
> https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-454445555731-bfd564275429d53b&q=1&e=47a1b565-597e-492d-a7c0-c2291d74fae4&u=https%3A%2F%2Fgithub.com%2Fquicwg%2Fquic-bit-grease%2Fissues).
>
> >>>
> >>> //Zahed
> >>> Attachments:
> >>> * smime.p7s
> >
> > Attachments:
> > * smime.p7s
>
>