Re: KEYS_READY

Jana Iyengar <jri.ietf@gmail.com> Thu, 14 February 2019 04:24 UTC

Return-Path: <jri.ietf@gmail.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 873EF130F70 for <quic@ietfa.amsl.com>; Wed, 13 Feb 2019 20:24:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k0pL5XkNQxL0 for <quic@ietfa.amsl.com>; Wed, 13 Feb 2019 20:24:39 -0800 (PST)
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E4D4A130F6A for <quic@ietf.org>; Wed, 13 Feb 2019 20:24:38 -0800 (PST)
Received: by mail-lj1-x229.google.com with SMTP id z25-v6so3994934ljk.7 for <quic@ietf.org>; Wed, 13 Feb 2019 20:24:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0Ay4lN723+d5PfybcQ+wRiCnVpTlmBfRhbi5xmGfEas=; b=iajdpAPk6JYmEdotU5qDilhxB+/DhQJWj2zVJ4XKa8XjGGMYp8PJIafjmyI+XvZPYB e7MY5GIFWTn4NT7Mh35VeQQE2pzbQ4EFsidvFWWUgpZRcT2+WlGpK5YCJ1cxcMKxANYz czj7YFzK1CYwETQZJd2hO8yQwkRgSEFnV4PZ6ho6/Xn5pAufTDDCsMM0XfDfiRIBDH8x wUIK7Vzqhf90wCOVAXNvpsXnkqsMt4q/ko4sg3kUmQQYIqn/31yHKmT1kPp8r+1bnHwH 7Gi5wFbAFUyyWAZNoAtLrN0XAcVmsX5yX1cuBK3vgP1Wng6/IUCrYVEHWU3GJNFf01gM eUtA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Ay4lN723+d5PfybcQ+wRiCnVpTlmBfRhbi5xmGfEas=; b=FH+qNuZAWOjKcWWlOBOlaw/zrtc3jyY9QHSgQPH05wHS9W+j5ZGQhwfogqTxlteGKG PR5Pohu0QYGWdmiIlwpsl8sOBDPwBgf6vBrOQxJDUKwXutiPVEpDVI9m75GCX4ZBEgiH +FVDd40Dr1x7CjCCsw37exHXc7hlgIyEvg3ltfYeM7xzAYsyMDiuW0wh5kP/ln+mFmLv NFcrUa99TirHbAK6VJIKUOrC0VWyx/EAnVbHFpoT3qI6deaQ4CRQBoNp6kf6uMrufQpv nIA/Gxu/Yx5xm9ihnMYGywIkY61B3chyon6nMqy7s0UepFMgrqL6mesXVeV5YuIS+rlm ol6w==
X-Gm-Message-State: AHQUAuYF9kch5V95VMsdr/WqUjADIWz/E+10CS3YgTXg2iCg8jVMK+cA QfyKoNqs7KUuzNLzPe7LTp++GiztR/OIio1jwfePEQ==
X-Google-Smtp-Source: AHgI3IajHvogx2YqmMsjg4XZmxhqptbRzV6recICVJuGXfwwB8YLGZJ0LdV7OlOJbrxPcCHR3HFi/01D+U5Usew7ing=
X-Received: by 2002:a2e:3c19:: with SMTP id j25mr939792lja.72.1550118277053; Wed, 13 Feb 2019 20:24:37 -0800 (PST)
MIME-Version: 1.0
References: <1550022355.557617.1656828112.4DD1CEE6@webmail.messagingengine.com> <CANatvzy_juza_meGR_-KuBV9FA=F754mv54aawxMb8hYWxb1gA@mail.gmail.com> <CAN1APdcVYKWuapZ3XHxXa_nVACwkRD-xeF3ub-5ROttE7QVrmQ@mail.gmail.com> <CAOYVs2ooxAuwu_zr2XZ-y9UqUP5kTbjoFrckAOi40bF9vODGOg@mail.gmail.com> <CAKcm_gNk=jKrnXM4Ht4yF0RX25wtVifjxz0c1gay0uie7PMw6A@mail.gmail.com> <CANatvzxBYzEaDZ1Ftt=o1zT5zVcVTd1EwtGiJOC-mkrNUWzVAQ@mail.gmail.com> <CAN1APdfzepc9DE98UsWw=hB4dM38qKLxdAjpsYuddDBatcscDA@mail.gmail.com> <739AFC55-DD02-47AA-A29E-B9C34ED7D6F9@gmail.com> <CAN1APddWLdmRo+ZZDnmvrBEFQk4TTcS3UK_9AU4KqAeSkiBvJQ@mail.gmail.com> <375A63C5-7120-4688-8873-EEA90693332E@huitema.net> <CANatvzxoOFzpkcH_4VpQscpZq8ak0QL0D6REvyJVjE+ga97SVQ@mail.gmail.com> <1550111606.3717440.1657643080.033E200B@webmail.messagingengine.com> <ae018a6d-4c9a-acc7-4213-21d1670f9dad@huitema.net> <1550117510.928793.1657684264.41D049FA@webmail.messagingengine.com>
In-Reply-To: <1550117510.928793.1657684264.41D049FA@webmail.messagingengine.com>
From: Jana Iyengar <jri.ietf@gmail.com>
Date: Wed, 13 Feb 2019 20:24:25 -0800
Message-ID: <CACpbDcfbEcg70RwpFrCQ2X6WA0Dd7ygd=Q0w7iwKc-ZgZQbZ0w@mail.gmail.com>
Subject: Re: KEYS_READY
To: Martin Thomson <mt@lowentropy.net>
Cc: QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000043836c0581d3099c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/GdvI2ZG0TlYK6xLQ2gkVji-uEco>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Feb 2019 04:24:42 -0000

On Wed, Feb 13, 2019 at 8:12 PM Martin Thomson <mt@lowentropy.net> wrote:

> On Thu, Feb 14, 2019, at 14:47, Christian Huitema wrote:
> > Of course, if the KEY ACTIVE frame requires an acknowledgement, it
> > should arrive eventually. But what if it doesn't? What if the peer did
> > not send it, or did not correctly retransmit it? Should the endpoint
> > just abort the connection if some number of RTO pass after the phase
> > change, and the KEY ACTIVE frame has not been received yet? Does the
> > behavior change if some traffic encrypted with the new phase has been
> > acknowledged?
>
> I'm happy leaving this to implementation discretion.  There is no clear
> rule that say when you can treat the absence of the frame as an error,
> partly because your view of PTO is different than that of your peer.
>
> Maybe we can say that if you want to update and can't, you close the
> connection.  That's the usual advice anyway.
>

(I've left this comment on the PR as well, but seeing that this discussion
is happening here as well, echoing it here)
If the peer hasn't acked the previous KEYS_ACTIVE, it may not have seen it
yet. It is possible that it simultaneously did a key update and sent a
KEYS_ACTIVE however. Under this condition, the endpoint wouldn't be able to
update its keys again, since the peer may close the connection, right?