[Rats] CHARRA module feedback

[William Bellingrath <[e-mail]>]

Hi all,

I have another round of feedback and review on the CHARRA YANG module from some of my colleagues.
Comments are predominately aimed at naming conventions and readability and are only suggestions.


1. Our preference is for "-" vs. "_" in naming conventions in all cases, for example as below.
  feature netequip_boot {
    description
      "The device supports the netequip_boot logs.";
...



2. We would generally say "Netconf server" instead of "YANG server".
"The module defined requires at least one TPM 1.2 or TPM 2.0 and corresponding Trusted Software Stack included in the device components of the composite device the YANG server is running on."



3. Noting the use of upper case and '_' here to check if this is intentional.
       leaf TPMS_QUOTE_INFO {
         type binary;
         mandatory true;
...



4. This RPC name looks very generic and not specific to the particular feature. Is this the intention?
   +---x log-retrieval <<<<<<
      +---w input
...


Thanks,
William Bellingrath


Juniper Business Use Only