Re: [Rift] RIFT protocol implementation

Tony Przygienda <tonysietf@gmail.com> Thu, 26 March 2020 16:25 UTC

Return-Path: <tonysietf@gmail.com>
X-Original-To: rift@ietfa.amsl.com
Delivered-To: rift@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DAE303A0908 for <rift@ietfa.amsl.com>; Thu, 26 Mar 2020 09:25:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.097
X-Spam-Level:
X-Spam-Status: No, score=-1.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3e9ZIUa1t0PS for <rift@ietfa.amsl.com>; Thu, 26 Mar 2020 09:25:34 -0700 (PDT)
Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8D2263A08EB for <rift@ietf.org>; Thu, 26 Mar 2020 09:25:34 -0700 (PDT)
Received: by mail-il1-x144.google.com with SMTP id j9so5934938ilr.7 for <rift@ietf.org>; Thu, 26 Mar 2020 09:25:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C4Y/8U48G859hKZTtKM5LElD2fEA9all+geVDM1pNuA=; b=NKIIpMyOvDcBYxKRjpxeQYdV+yzwpQXQ7GDfsH+J1jmanink4zpFP5pxwktMr0D5K1 9ila+RLu/00ohVh/22VN3Kp+mgLI7xy76zue1jYeb4uFUP3vQhYnG21qjBeX0OcwPEen QO8489/TJ2pNNgMK/Hscum5S5ZE3F0eZzOLA9keAC0iwbjLppqQqkssTDtjEH6DpsJbV oDaskmfQbfixAeCraGNXJ62KFLf+cl6TLvTlXbJdV7l6O5vHmrAGi5pHU8zINpRdHfrZ y95gbF+z7EMQxfh62xdhw/6VHsNgQ9kDwJidVab/U3MMui6ze8XAdrP1uiX9ZbPCRWja wWng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C4Y/8U48G859hKZTtKM5LElD2fEA9all+geVDM1pNuA=; b=ok5gk5aGj8Sioe0xyQ4TcGYaB2tnQ168xm3bS7RUD6vtQW5SbXQLP/8JnjawPERHPm DhmYeV4Jng1Al3Uxq5o+KZztJWsfdFg2pOTpBkM3rgwpI5HuXRCarCqzr4nCnueZPGQU YmFJSRcAFpLLx3ITkC/I0ihyAYoDp02tTXTS1BHoIpXGF3Mz//LJUO4NAyZJZNx1P7uK t7dgSQL0tw5elnw0upzF9NGSjxTL+tZoREbNdJZVqIGD8/24OSh8qGn4g6HIsHVvuK+o S5zWyzrDMZGi0D9ZM9KsLToMCFcHYfmnhICQZbzbguG4XMhmDLTyciD+Ihbydp180vfj ICrA==
X-Gm-Message-State: ANhLgQ3yjttsBZmpET5Siu9qi2a7D2UheQrO0yGp7mrVBMU9ZeJlEH9+ InbCLuEpGoyHWOIjs835prWNyWUzrabOjwKj2CQ=
X-Google-Smtp-Source: ADFU+vvvuDxhsVyregxTmcwyYWotazAqcuIfPI+xHmeJBNIX7v/6e5XeWEQK9wCAGih0hYpmwjkDiO6BfI1BHMkLyLg=
X-Received: by 2002:a92:3958:: with SMTP id g85mr9591051ila.302.1585239933475; Thu, 26 Mar 2020 09:25:33 -0700 (PDT)
MIME-Version: 1.0
References: <AM6PR04MB432519F740317CFE30ED33C8C1420@AM6PR04MB4325.eurprd04.prod.outlook.com> <4586A088-9D59-47E7-B6D6-3B94E82AEB1F@gmail.com> <349c1186-e6f4-a68e-289d-b832285033fe@fing.edu.uy> <9EA55459-D718-4575-ADE6-D061023AAE34@gmail.com> <b642570c-caed-9de4-4a5e-dcd4943c3f0e@fing.edu.uy> <16a8f23f-db46-ebe0-4503-1cbeee076ffb@os.uniroma3.it> <CAObb+j7j8MQRzax3UDyN4KWNC6sB0jfOSop+Vf2YxZ+EjcVjtw@mail.gmail.com> <8a55226e-d428-f195-cfb5-c427229eb081@os.uniroma3.it> <87FBCCFA-A2E9-41EA-9C8F-BC87AAF1A9CF@gmail.com> <5b48347b-4156-bc4e-dcb2-14ec70159ee6@os.uniroma3.it> <E824E104-63BF-415E-BBBB-8A6EF7FAE332@gmail.com> <2528b464-c368-6e31-54c7-6ff200b6dafb@os.uniroma3.it> <A24BFF42-9AAE-4837-85EA-ACD55BDCEF41@gmail.com> <8977A74B-B0AE-430D-9817-2608952DDCF7@juniper.net> <CA+wi2hN2LziBFx68VEk5HLEVv3Jwj+0uWiZdf=QzJKfaXY1CTw@mail.gmail.com> <fe29024c-7170-97f5-fe3c-d381ef1d62d2@os.uniroma3.it> <C8542AB2-9C17-42FF-8DD8-1AB3C8C65159@juniper.net> <b82cfbc9-6531-cb3a-a7b2-01ed723f37b4@fing.edu.uy>
In-Reply-To: <b82cfbc9-6531-cb3a-a7b2-01ed723f37b4@fing.edu.uy>
From: Tony Przygienda <tonysietf@gmail.com>
Date: Thu, 26 Mar 2020 09:23:39 -0700
Message-ID: <CA+wi2hOYT-xzh89=SkGexbqV_ZuEqnUD7nSc35veTR=Q+=KEnA@mail.gmail.com>
To: Leonardo Alberro Zimmermann <lalberro@fing.edu.uy>
Cc: rift@ietf.org, Bruno Rijsman <brunorijsman@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000001e5fcc05a1c46f93"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rift/-zTCAumlHCuq-_3229yAEUD_RsM>
Subject: Re: [Rift] RIFT protocol implementation
X-BeenThere: rift@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of Routing in Fat Trees <rift.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rift>, <mailto:rift-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rift/>
List-Post: <mailto:rift@ietf.org>
List-Help: <mailto:rift-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rift>, <mailto:rift-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2020 16:25:37 -0000

Leonardo, that is a great project. Observe that depending on language
backend/thrift compiler different streams may represent the same encoding
so it's good to test it against more than one implementation. We should get
streams that has all possible LIEs and TIEs in it.

If you run juniper standalone public package
https://www.juniper.net/us/en/dm/free-rift-trial/ you can easily build a
2x2 yaml topology and just snoop on a UDP port. I suggest snooping a v6/v4
links from a spine to a leaf. that will give you all the LIEs and node TIEs
and default prefixes. If you break a link via CLI you will get
disaggregation as well. If you struggle with that, ping me ...

Having said that you can do all that with open source as well (but observe
we didn't pull open source to -11 draft yet which had some schema changes
albeit minor). you can pull the schema yourself with Bruno's help or I'll
get to it one of these days ;-) ...

Architecturally, since RIFT will evolve and possibly move to newer major
schemas, I would suggest you provision for the possibility to put into
wireshark multiple schema files, basically you'd need to compile multiple
directories in differnt namespaces and use the correct one depending on the
major you found on packet envelope (you can always use the newest minor you
support on the major, they are always compatible).

--- tony



On Thu, Mar 26, 2020 at 7:17 AM Leonardo Alberro Zimmermann <
lalberro@fing.edu.uy> wrote:

> Hi everyone,
>
> as a part of this project we are developing a wireshark dissector for
> RIFT. The dissection for the security envelope is ready and tested. Now we
> are working on the Serialized RIFT Model Object dissection and for
> preparing the testing we are looking for a "known" trace, i.e we need a few
> packets and the exact values of these fields in the Thrift model. So if
> anyone can help us we'll be grateful.
>
> Regards,
> Leonardo.
> El 18/3/20 a las 13:34, Antoni Przygienda escribió:
>
> Forwarding the discussion to the rift ietf list for further exposure &
> since I generally think it will be possibly more productive in a wider
> forum. Roma Tre University is working on Bruno’s open source and there’s a
> bunch of interesting tools they’re developing as well as you can read
> below.
>
>
>
> --- tony
>
>
>
> *From: *Mariano Scazzariello <mscazzariello@os.uniroma3.it>
> <mscazzariello@os.uniroma3.it>
> *Date: *Wednesday, March 18, 2020 at 9:10 AM
> *To: *Bruno Rijsman <brunorijsman@gmail.com> <brunorijsman@gmail.com>
> *Cc: *Antoni Przygienda <prz@juniper.net> <prz@juniper.net>, Leonardo
> Alberro Zimmermann <lalberro@fing.edu.uy> <lalberro@fing.edu.uy>,
> "tommasocaiazzi@gmail.com" <tommasocaiazzi@gmail.com>
> <tommasocaiazzi@gmail.com> <tommasocaiazzi@gmail.com>,
> "lorenzoariemma@gmail.com" <lorenzoariemma@gmail.com>
> <lorenzoariemma@gmail.com> <lorenzoariemma@gmail.com>, Giuseppe Di
> Battista <giuseppe.dibattista@uniroma3.it>
> <giuseppe.dibattista@uniroma3.it>
> *Subject: *Re: RIFT protocol implementation
>
>
>
> Hi everyone,
> thanks for the extremely detailed suggestions! I have a lot of stuff which
> I can use to work on the implementation. Also thanks Tony for giving me
> further useful tips.
>
> Also, I'm happy that we agree on almost every implementation detail and I
> agree with your suggested variations (like the flag for the
> spf_run_direction method).
>
> About point C, I did not write anything since it seems quite easy to
> extend the Thrift model. If I have any issues, I'll surely ask you for some
> help. I also wrote a point D (which is how to handle the negative
> disaggregation in the RIB/FIB when received), but I read the Pascal slides
> (I add the link
> <https://urldefense.com/v3/__https:/bitbucket.org/riftrfc/rift_draft/src/master/negative*20disaggregation.pptx__;JQ!!NEt6yMaO-gk!QBFQP3Ec6u0elEKgEFaAEndcjyQntJXvMg0h2TfAH6kn4JLUaMb3FOYpDQOltw$>
> here, so everyone can access them easily) and the steps used in that
> presentation are the same that I thought.
>
> I still have some doubts about the special SPF run:
> *2) We will also need a new member field orig_neg_disagg_prefixes (once
> again of type set, I think) that contains the negatively disaggregated
> prefixes that are autonomously being originated based on the detection of
> fallen leafs based on the difference between the normal and special SPF
> run.*
> You are proposing to postpone the RIB/FIB update after the special SPF run
> (which can detect additional fallen leaf nodes). This is right,  but should
> this only occur on ToF nodes? If we consider a node X, which is not a ToF,
> that receives a negative disaggregation TIE, it should only add the prefix
> in the *prop_neg_disagg_prefixes *set and check if it received this
> prefix from all its parent nodes and propagate it if required. Then it
> should proceed to update its RIB/FIB, without running the special SPF. Am I
> right?
>
> About the flooding oscillations, Tony writes "Your best protection is
> scaled, randomized tests". Here at Roma Tre University we developed a tool
> called Kathará
> <https://urldefense.com/v3/__https:/www.kathara.org/__;!!NEt6yMaO-gk!QBFQP3Ec6u0elEKgEFaAEndcjyQntJXvMg0h2TfAH6kn4JLUaMb3FOZujrrECA$>
> which is able to emulate network scenarios using Docker containers.
> Recently, we also developed a Fat Tree Generator, that automatically
> generates a fat tree topology starting from the fundamental parameters of a
> Fat Tree (K_LEAF, K_TOP and R) that can be run in Kathará. It also
> auto-configures the routing protocol on each node (of course, we also
> included the RIFT-Python implementation). So we can generate Fat Tree
> topologies of any size and run tests on it to verify functional and
> behavioral aspects (and also gather routing information such as PDU size
> and count). We are also developing a Fat Tree Test Framework (in
> collaboration with Leonardo and the team at UY university) which implements
> typical data center network scenarios (such as link failure, node failure,
> fallen leaf, partitioned fabric and so on) to run integration tests on it.
> For example, we can check if the routing table of a node is equal to the
> expected one after a failure (e.g. loss of a multipath or a prefix). With
> this tool we can surely run randomized tests (at any scale, since Kathará
> supports Kubernetes) to ensure that no flooding oscillations occur.
>
> I agree to move the discussion on the RIFT WG mailing list. Maybe someone
> of you should introduce us and explain what we're doing.
>
> Thanks everyone for your time,
> Mariano.
>
> _______________________________________________
> RIFT mailing listRIFT@ietf.orghttps://www.ietf.org/mailman/listinfo/rift
>
>