Re: [Rift] AD review https://datatracker.ietf.org/doc/draft-ietf-rift-rift/ (v-18) (review up to Section 4.3)

James Guichard <james.n.guichard@futurewei.com> Fri, 29 September 2023 18:59 UTC

Return-Path: <james.n.guichard@futurewei.com>
X-Original-To: rift@ietfa.amsl.com
Delivered-To: rift@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8340C151536; Fri, 29 Sep 2023 11:59:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8RdfvaNl_de3; Fri, 29 Sep 2023 11:59:42 -0700 (PDT)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2095.outbound.protection.outlook.com [40.107.243.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB0F8C151522; Fri, 29 Sep 2023 11:59:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNfKu7Cvc2wLqm6UoAgZdlaYUjbGSyks8KbLCfPIrw65G2OTYcP00PnJi2L61zSanOQKzgTVQbykJP2YA1Aqx3aYsITPynheFW8EftpT+InAFvMmYQlzrMX/WxfDoTOttHmYEf+32aBYdGUssCvc5vkFRmoGybwlbLBqhlTgKu2G9W1+AVhEAleoXsTFpRMmlUytVYpfb1RWV1wjAZXztYE0UXP9HMxCUwzxu2AoZHy71LqZ/Cy2klMTKh+VYKxTgDI3Ou+v1TSretueCyn00NYyBgyWTVg6nxWhr6mnF59jJQvc7q4ElIttasV4wSF46oOPi20xTZ1NhNDo9JwKSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cn9cEQO5UpKKM4xi7XvCcVw6nz+SBLSJlPDWxTSrgco=; b=KYqrMUx4NAKgpyi1jUThMg1aoCyjEXEy0cEBRWiY2JA9lx5kRzbJxnGAHa/eVuAQioM0ILLNO5BsUMRL2Z8Ze04IT979aVkfvpnrwLECOnLk0qkRmo+UWdynSS4UMmieEc1S5eHIPh49TuI7Rs7/zjkTYAYDyAbw03KFDsIxKB6m4pN5II4raM+rz+pxbXiEqbDQSehXuBW7Pw6qeDPrhHqX3PTZ+YJcPtmnXpIm0XUeHVabBrfu4AHIQxaizCIdCaXN0Z/nQrYMKv0fpqijiCuk3eIYhyOetZPd8trwVl+gg+1611lxlWqFydqADnbceFoZr0fWkpnR3hFKiwfrvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cn9cEQO5UpKKM4xi7XvCcVw6nz+SBLSJlPDWxTSrgco=; b=Qa8Ds18fdelL7dknEFgSoarNY4grHVwWVJ8es+sn6x9MgFO4XlGNnMDU4QA5YRW9ZFD0Z08VY0JW0iUCg7uo9D2RHgjfuMv3+bdHrlA33dsF9H3L0YLZIuLT+nPWJxNoDqhoarP0juivQT8TajOGzsDNfIP0SxyeAnl7UtcuXH4=
Received: from MN2PR13MB4206.namprd13.prod.outlook.com (2603:10b6:208:a0::26) by CH3PR13MB6507.namprd13.prod.outlook.com (2603:10b6:610:195::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22; Fri, 29 Sep 2023 18:59:36 +0000
Received: from MN2PR13MB4206.namprd13.prod.outlook.com ([fe80::7734:82c7:efcd:e3bb]) by MN2PR13MB4206.namprd13.prod.outlook.com ([fe80::7734:82c7:efcd:e3bb%5]) with mapi id 15.20.6813.027; Fri, 29 Sep 2023 18:59:36 +0000
From: James Guichard <james.n.guichard@futurewei.com>
To: Tony Przygienda <tonysietf@gmail.com>, Jordan Head <jhead=40juniper.net@dmarc.ietf.org>
CC: "draft-ietf-rift-rift@ietf.org" <draft-ietf-rift-rift@ietf.org>, "rift@ietf.org" <rift@ietf.org>
Thread-Topic: [Rift] AD review https://datatracker.ietf.org/doc/draft-ietf-rift-rift/ (v-18) (review up to Section 4.3)
Thread-Index: Adnseg5bNIbVc2aHQYejW5jmGgjmRgAGuBzxAZwoSwAAAF3dUA==
Date: Fri, 29 Sep 2023 18:59:36 +0000
Message-ID: <MN2PR13MB4206523DF06E98E2461482EBD2C0A@MN2PR13MB4206.namprd13.prod.outlook.com>
References: <MN2PR13MB4206AE6192DEA6FB74267123D2F8A@MN2PR13MB4206.namprd13.prod.outlook.com> <BL0PR05MB53629692FC647D6E1652F646B6F8A@BL0PR05MB5362.namprd05.prod.outlook.com> <CA+wi2hPqQgimzzEzvqE9BHCiKE2xmOgzVFm4qFJz02L03uK8UQ@mail.gmail.com>
In-Reply-To: <CA+wi2hPqQgimzzEzvqE9BHCiKE2xmOgzVFm4qFJz02L03uK8UQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=futurewei.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MN2PR13MB4206:EE_|CH3PR13MB6507:EE_
x-ms-office365-filtering-correlation-id: 6c22c1fe-f047-4c73-51b6-08dbc11e39e9
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZIh3B9MLPNSBRBZb+JVECIjEnaqM7155Iw/xb0xOQIslgsuFThAykEBPY0EDHZ/rrfNW6prPpvbqRPzTilnrcPh9G6YGU1Xf2sEOhMRUbt66cxqQJNPrG0n1imCx8eUdzSNfTUq5Zy5/zTUEhEjwovYVXvUqxsrM+5gip36DW8isBpDY9iwPcpdN/OuOxhxntE34UKI4wFZlqtX+4tu7fOVX2v50yw4qL+8MgidRjgANTwH1Pu1mU7/ChQ3omp+h578pj2bKAMXr6UClNK/jJr7o6Z+nf+i2kgIRSDlkz9991vBXKOUkqiUDqLxoAX24s8manF9+5zgUNFF/lZFDWBYPcoGzxFQsHYEIEG23j1UyVNzLbon/1TDbRyNKFkIgUo2Amc7v+Xug9ZI+9XdyPdc1tiTrrfj/jC8BBLqY/iIyrnJF6tpJ67FBwvB/yZAmFs+3sQjmIUXJAKTt/WkFzxl9lRgXVwRhg4aF9Mpb1ra/muluaI+P1cKCAg5Ko4X3VOcK4th5RtI6oX13/YKMn3yRmWFuEQ7/0t8kZa3bgbLXRI4Mb/46K5b/LH+I7kVHhNl25xMBS07pQEe5w8g3cTBe8g5lcDfiJMuB5M/GFBDXACkOyw+13vZzO8A9IwWNT5LDG9B9R1ZZ8cJYXU/acA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB4206.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39840400004)(366004)(136003)(346002)(396003)(376002)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(2906002)(66899024)(38100700002)(38070700005)(86362001)(53546011)(478600001)(9686003)(71200400001)(6506007)(33656002)(966005)(55016003)(41300700001)(7696005)(52536014)(8936002)(4326008)(5660300002)(66446008)(54906003)(66476007)(8676002)(122000001)(64756008)(66556008)(76116006)(66946007)(110136005)(316002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: GDdd/Gw/dHUxV8njmPgRIHILL96UqjAE8IjH66KrpKxX7XhgeCdmZ46PzL7wRa/AHo+DTq+m8yBnlTHmepEAz7NXLgq/xh67vw1dssgQY6K+TS1o4mTKSBjqoQ3DP5K3ZQeqIkSq0AzC2CkoX7kdrU9SVeuytXXg1izih8SGA5HmP5vgmTEd4e7GH0gkwtxFVZsSMu0+YxtFbjgj4lYwaJVa1w6p/JMyOFhsWxKnG+ZNL/kja5AvyQ+TghMkTlR7/Uy4BRGSQjr0AMHaw/PSmHKFNL3I7yhYcC3E9C3frEXYfvTyCVQ7oKcqEemH6ueK70uEXUDpaKh7U2v+DaEwIgofeIvNhUacVte9GdztmaErPmcdAPKQhUzj6VZFoKcx1NtUcKCB6BltuE10odPXmFTpCdkub3x5z9YtvOifOy0/bhkWPzbw1CqpL0pEljFGeyOJs0iZwHDnEFdYLGzSW22dXaQm4JXf1lQaT9epbzIz1ex3qKU1e5cVuM4nDdfMujxF7GzHS6z53bMhHh8U2B5VHBicJ2xaTFQcFs4iZfreyvduJoFQhNTFVG4q0Hu74JgHHdQg1qfUqfWepkwvIsn60GZfk3GBufb74x3hsgAWL1yt0F1R7a6d1yb7nHFruAB/3Z1fmsaa/YvPLEglW9tfExCMzwF+sqvRRDjnDVnC5NsCbokAE1M2zfKPnlvitW0aCMvI150YmrO04WJ9qmY43eO8mUfJKowQYzazhvphHwufrIGWvRpv2IhPvmlgJuGUbCxb02WAoVnlV+KBuYqlBQLnku2dwK33xxPNvp86dcAKC5ViZu3Wt3ddvHN3voh+lwlP0K8KJ2DPbsgPhc6TDd9xAIioj1yZu92MdRySA8GJHtKByqaZkiEQIilo9CFHc2qggs1oF7C2AOBXoSe01/2XYogMBDHUBgy9KMUvCbXU/nHYyuXciRvq9hYxr577FqauyEvrNGYaVzKLdc/ZArfPrYblX4biNrkkyNo5uMVWV5DppoNNJB+5A7B412kglvrotqEo45mtaOIg+LIvBLCov1ntf6IxpPKxSdgQyXeVvYH2Y3b5UwR6ummHiWb15xypXLhv0aq6Rmsl5orfALHaXWK/B+Ymf7cDqttvKhxA7gSbfOw02AWpPihCOAvGCIIl1bBDnmDWESaAwNv+uiIURxW0rHxMznAqR95PgWBjwPMxWEmCoTS5affY8DUZPZ2+xabeSHco3K4HrcSjBoETTAhuPfTuF5IEOuozLo4LkJcPTtbCckA+gDOFEgIBvKp+ZsQQJ1uuu+mAG9ETJwbMK2PFdnM5aRvxndsYKozV4OW9qm6e2cWXRnY+CwTd27hPzet1OHgvrYu8w7s3YKcr9z/sRa7x7jNStSoV9kfGTT7X5Lfxnqp+o2CppBJCL1PVeyajX/DWxaJRXzRXfBfS/RyFmoW1ggB82ft4F7YIkqYNMsSqIAbnAVqwrlmNYNXxjGFLyXeh6lCFPNtIDPAsUW1HbWgO+MLUpI3mV7mb29HXlOXoVJa/Z2ezjUqNKKAzgfIRz0s/A3MmsKPFbivRsG32aGMOgwGq2WI7R9qP/FzyWiIcZyLEoLNDrrjHqQdVbtaZSLaq3W61HiSH5fRfA7sKdhFUTNVcd9POvlraqrECIguyoTVoZQsa
Content-Type: multipart/alternative; boundary="_000_MN2PR13MB4206523DF06E98E2461482EBD2C0AMN2PR13MB4206namp_"
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB4206.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c22c1fe-f047-4c73-51b6-08dbc11e39e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2023 18:59:36.7219 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5Gj2xREpmhdBcg1hCDcTLliK647OstxGA//SOsXeo9Vpi/ePwvFE+bThxz1UUaNUoVAqkz7o6H7DFtrtUa95EQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR13MB6507
Archived-At: <https://mailarchive.ietf.org/arch/msg/rift/D7PPry-zNsamoFNaqA8CcysCtmo>
Subject: Re: [Rift] AD review https://datatracker.ietf.org/doc/draft-ietf-rift-rift/ (v-18) (review up to Section 4.3)
X-BeenThere: rift@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion of Routing in Fat Trees <rift.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rift>, <mailto:rift-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rift/>
List-Post: <mailto:rift@ietf.org>
List-Help: <mailto:rift-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rift>, <mailto:rift-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Sep 2023 18:59:45 -0000

Okay makes sense and I can see your point of view – not a big deal.

Jim

From: Tony Przygienda <tonysietf@gmail.com>
Sent: Friday, September 29, 2023 2:49 PM
To: Jordan Head <jhead=40juniper.net@dmarc.ietf.org>
Cc: James Guichard <james.n.guichard@futurewei.com>; draft-ietf-rift-rift@ietf.org; rift@ietf.org
Subject: Re: [Rift] AD review https://datatracker.ietf.org/doc/draft-ietf-rift-rift/ (v-18) (review up to Section 4.3)

I just chime in on one bigger topic


Section 4.1.5:  Addressing the Fallen Leaves Problem

Jim> General comment: I think the document would be much easier to follow if sections 4.1.2 - 4.1.5 were moved into an appendix with a pointer to
that appendix in section 4.1.1 (for those readers interested in multiplane). For those readers not familiar with complex datacenter design it is
going to be very confusing to read and in some sense detracts from the specification which is the next section.

jhead>> I will concede that this topic quite dense, but that’s just the nature of multiplane fabrics. However, this is a protocol specification that at baseline is for those who plan to implement the protocol in its entirety. The Reader’s Digest section exists to help readers navigate the document depending upon their level and area of interest. For those that are interested in multiplane fabrics, moving the section to the appendix will not shield them from the complexity, but I do think it will make the document feel disjointed. For those who are not interested, be it an implementor or an operator, the Reader’s Digest will steer them around the topic.



I'm fully with Jordan here. Moving this section down will make lots of specification parts like e.g. negative disaggregation and necessity to flood northbound on horizontal links at ToF completely incomprehensible. Reader's digest already explains the structure if one wants to skip the multiplane while possibly being baffled by some things down later but e.g. the explanation of generic concept of representation of fabric and its variables (thanks Pascal here) and the resulting problems of falling leaves/inversion I hear good things about. Some large shops ended up telling their engineers to read those sections to normalize the language spoken about fabrics, even when not running rift or further pursuing its concepts in production

-- tony