Re: [Rift] AD review https://datatracker.ietf.org/doc/draft-ietf-rift-rift/ (v-18) (review up to Section 4.3)

Tony Przygienda <tonysietf@gmail.com> Fri, 29 September 2023 18:49 UTC

Return-Path: <tonysietf@gmail.com>
X-Original-To: rift@ietfa.amsl.com
Delivered-To: rift@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F4C2C14CE40; Fri, 29 Sep 2023 11:49:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eOamcG8lfVfL; Fri, 29 Sep 2023 11:49:18 -0700 (PDT)
Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4814BC14CE36; Fri, 29 Sep 2023 11:49:18 -0700 (PDT)
Received: by mail-vs1-xe32.google.com with SMTP id ada2fe7eead31-4526ae5b0b3so6338328137.2; Fri, 29 Sep 2023 11:49:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696013357; x=1696618157; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fEflIvqblnzYacAoexsCj2rOCly22bZ6TdDcS0+2Y7U=; b=YIK2kFnrRyMUcHhPceE7JBbohp4lS7nxjNkgHnkl+ZSVZDg9RQzwrTp2jpGaYJvjor ceKSTzk5CyXNvQYjR1YNq4OqSOf3N99F7qOKSQ+87urFYzWe58neDxCaOljKKM90zugl j+0u7HK616LQ1egeCuuLCpKFtYoZqV8W7fWpEddFtmUeWOg8Qm0Puy9NEO77sNHI/ZJD QMAnxupjl1kQCIs2TmgH9i7LAb2yv3rW8JXvQVcvSug9WVOrnt2wIQ6tX9qlk4g7Xa+F 0gQ7rNA5z+2JU+UXL4CgETMd4KAPqLFjrP6IeKgu13MGiVBPpRC2MqTZ/03P8MBP2RVI jVnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696013357; x=1696618157; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fEflIvqblnzYacAoexsCj2rOCly22bZ6TdDcS0+2Y7U=; b=CjR0rkTPxv5IWM2C71lQJ2aNz4lBDZEtlb+EtXjC8dZ3rXyAUHQgYZUmIbbCAUFaRG hfmigrreXH66GYV7y7Oyt04PdeScKO9D3raEf1JJBXIMggcqobk2QRwnMhHoznljIOrk iYEb8DLifgyKZRDD2MqgG2hzbaZoXp4JsM6RjIjoQg3BtpEg6upCHTlBKNTc+ukExPW2 RT7h3nZ3y48Si3aUnrOKRMNjuza5QNRwm159WsC0R/DAl6UySxj9TDzioGZmnEzNkUN7 AptGldy4H1T3qQ+KkAg+mi+Xiqy+l3Tivwuow+FfZdD8ULJaAQgBAVSiwNwHftNGXJch f+LQ==
X-Gm-Message-State: AOJu0Yx/x4flaJDHOaRVhYKh6fAfBQZyJHhQrw2z5+oFdxhzUWkj5llF BVOn3SK+hZGkUeIDNzBdn+g/A2CwyJRULgA8dSiLfyfvNcM=
X-Google-Smtp-Source: AGHT+IEk4hb5M66aFB3Ml/A+C68tEcvooaG8tfIV/1iOhb/s+sJqa8m97QfTfL8R6rPNYYUnwkRpPY4dKnvqU5+GUKI=
X-Received: by 2002:a05:6102:d6:b0:452:6780:a6d1 with SMTP id u22-20020a05610200d600b004526780a6d1mr4593386vsp.1.1696013356856; Fri, 29 Sep 2023 11:49:16 -0700 (PDT)
MIME-Version: 1.0
References: <MN2PR13MB4206AE6192DEA6FB74267123D2F8A@MN2PR13MB4206.namprd13.prod.outlook.com> <BL0PR05MB53629692FC647D6E1652F646B6F8A@BL0PR05MB5362.namprd05.prod.outlook.com>
In-Reply-To: <BL0PR05MB53629692FC647D6E1652F646B6F8A@BL0PR05MB5362.namprd05.prod.outlook.com>
From: Tony Przygienda <tonysietf@gmail.com>
Date: Fri, 29 Sep 2023 20:48:40 +0200
Message-ID: <CA+wi2hPqQgimzzEzvqE9BHCiKE2xmOgzVFm4qFJz02L03uK8UQ@mail.gmail.com>
To: Jordan Head <jhead=40juniper.net@dmarc.ietf.org>
Cc: James Guichard <james.n.guichard@futurewei.com>, "draft-ietf-rift-rift@ietf.org" <draft-ietf-rift-rift@ietf.org>, "rift@ietf.org" <rift@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000ab7e7b060683e127"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rift/dj_ZT_IuH-JO3Vbdox2vPrEcS58>
Subject: Re: [Rift] AD review https://datatracker.ietf.org/doc/draft-ietf-rift-rift/ (v-18) (review up to Section 4.3)
X-BeenThere: rift@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion of Routing in Fat Trees <rift.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rift>, <mailto:rift-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rift/>
List-Post: <mailto:rift@ietf.org>
List-Help: <mailto:rift-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rift>, <mailto:rift-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Sep 2023 18:49:19 -0000

I just chime in on one bigger topic


>
> Section 4.1.5:  Addressing the Fallen Leaves Problem
>
>
>
> Jim> General comment: I think the document would be much easier to follow
> if sections 4.1.2 - 4.1.5 were moved into an appendix with a pointer to
>
> that appendix in section 4.1.1 (for those readers interested in
> multiplane). For those readers not familiar with complex datacenter design
> it is
>
> going to be very confusing to read and in some sense detracts from the
> specification which is the next section.
>
>
>
> jhead>> I will concede that this topic quite dense, but that’s just the
> nature of multiplane fabrics. However, this is a protocol specification
> that at baseline is for those who plan to implement the protocol in its
> entirety. The Reader’s Digest section exists to help readers navigate the
> document depending upon their level and area of interest. For those that
> are interested in multiplane fabrics, moving the section to the appendix
> will not shield them from the complexity, but I do think it will make the
> document feel disjointed. For those who are not interested, be it an
> implementor or an operator, the Reader’s Digest will steer them around the
> topic.
>
>
>


I'm fully with Jordan here. Moving this section down will make lots of
specification parts like e.g. negative disaggregation and necessity to
flood northbound on horizontal links at ToF completely incomprehensible.
Reader's digest already explains the structure if one wants to skip the
multiplane while possibly being baffled by some things down later but e.g.
the explanation of generic concept of representation of fabric and its
variables (thanks Pascal here) and the resulting problems of falling
leaves/inversion I hear good things about. Some large shops ended up
telling their engineers to read those sections to normalize the language
spoken about fabrics, even when not running rift or further pursuing its
concepts in production

-- tony