Re: [rmcat] AD review for draft-ietf-rmcat-rtp-cc-feedback-08

Colin Perkins <csp@csperkins.org> Mon, 11 July 2022 15:13 UTC

Return-Path: <csp@csperkins.org>
X-Original-To: rmcat@ietfa.amsl.com
Delivered-To: rmcat@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8AFC2C16ECAF; Mon, 11 Jul 2022 08:13:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=csperkins.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qa6hZm_b5l_n; Mon, 11 Jul 2022 08:13:04 -0700 (PDT)
Received: from mx1.mythic-beasts.com (mx1.mythic-beasts.com [IPv6:2a00:1098:0:86:1000:0:2:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6F1EC16ECE6; Mon, 11 Jul 2022 08:13:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=csperkins.org; s=mythic-beasts-k1; h=Date:Subject:To:From; bh=fHpZjd1X6jHRguvhe2BbtYecIJpfZJ2AU7S/SlsfXkA=; b=APpdMO4RL577dmPIVrca3Zviy8 fOJFdpvrwWGrrVy4fATjlswDiZ5NhHjSRAVBf7UCoFs36UxicvhOSgDN764JxN5niPlag7m/5f67O mCfl0A93OWdw8XmU8uunPxvFIZPp9xeAX2qDQWtQTCXfnPg9y++6IY7ttN4OTFb5GAkBGdX+9u/a7 CCdolXz0KpQgkUPNtjgsz8Tax/YS5KeBdADXcC6VXDTw8c8xuslyJXtdU2LZOMrvIfeUqYZ4zcOI/ IJ4+duYDAUZfcSiuGg9G3MN93b7Z4Wn+RuUL/DbpNvltDYYZa5MjYYh7hkeuMXjOkzILgTEq5LCrE F7EPKwzg==;
Received: from [81.187.2.149] (port=46420 helo=[192.168.0.72]) by mailhub-cam-d.mythic-beasts.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <csp@csperkins.org>) id 1oAv5p-003j4N-51; Mon, 11 Jul 2022 16:13:01 +0100
From: Colin Perkins <csp@csperkins.org>
To: Zaheduzzaman Sarker <zaheduzzaman.sarker=40ericsson.com@dmarc.ietf.org>
Cc: rmcat@ietf.org, draft-ietf-rmcat-rtp-cc-feedback.chairs@ietf.org, draft-ietf-rmcat-rtp-cc-feedback.authors@ietf.org
Date: Mon, 11 Jul 2022 16:12:54 +0100
X-Mailer: MailMate (1.14r5903)
Message-ID: <6A269021-0759-4667-BC29-AD1116E40EE3@csperkins.org>
In-Reply-To: <20E15E38-9BA2-4350-8913-FDCBB44F4B4D@ericsson.com>
References: <20E15E38-9BA2-4350-8913-FDCBB44F4B4D@ericsson.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BlackCat-Spam-Score: 0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rmcat/Yvo0GeMELF_-qlPBozmoH4hVONg>
Subject: Re: [rmcat] AD review for draft-ietf-rmcat-rtp-cc-feedback-08
X-BeenThere: rmcat@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "RTP Media Congestion Avoidance Techniques \(RMCAT\) Working Group discussion list." <rmcat.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rmcat>, <mailto:rmcat-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rmcat/>
List-Post: <mailto:rmcat@ietf.org>
List-Help: <mailto:rmcat-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rmcat>, <mailto:rmcat-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2022 15:13:08 -0000


On 4 Jul 2022, at 15:52, Zaheduzzaman Sarker wrote:

> Hi,
>
> Thanks for working on this informational document. This was a nice short read with useful information.
>
> I think this is ready for IETF last call. I, however, have some minor comments below -
>
> ## Comments -
>
>     - Anna has some good comments in her Shepherd write up mail (https://mailarchive.ietf.org/arch/msg/rmcat/XRWgsOrPbeWLXp7cRqutWZcRU70/ <https://mailarchive.ietf.org/arch/msg/rmcat/XRWgsOrPbeWLXp7cRqutWZcRU70/> ), please address them.

The -09 draft was intended to address Anna’s comments.

>     - Section 2: Says -
>
>    			"Approaches like in-network filtering of acknowledgements
>    can reduce the feedback frequency and overhead in some cases, but
>    this so-called "stretch-ACK" behaviour is non-standard and not
>    guaranteed"
>
>
>    		would be great to have references supporting this claim and definition of “stretch-ACK” or reference to that.

Addressed in -09

>     - Section 2: Says -
>
>     		"indeed, it is unlikely that a video codec can react instantly to a rate change anyway, and there is little point in providing feedback more often than the codec can adapt"
>
>     	 This kind of builds up the hope/assumption that it might be affecting the feedback frequency if this fact is known. But rest of the document does not deal with this information at all. I would suggest to be clear on how this information is used to calculate the frequency.

Added a clarification on -10, suggesting that the feedback should be configured to match the codec rate of adaptation.

>     - Section 3.2 : repeats the Trtcp equation. Can we tag the same equation in section 3.1 and cross reference from section 3.2?

Added a cross-reference. The maths is easier to follow in the equation is repeated, however, so I left the equation.

>     - Section 3.2 : regarding SDES packet size calculation, I think it is worth mentioning where that 1 octet comes from to calculate 28 octet.

Added a reference to RFC 3550 section 6.5, that describes the SDES padding rules, and noted that these require SDES packets to be 32-bit aligned.

>     		"The RTCP SDES packet will comprise a header (4 octets), originating SSRC (4 octets), a CNAME chunk, a terminating chunk, and any padding. If the CNAME follows [RFC7022] and [RFC8834] it will be 18 octets in size, and will need 1 octet of padding, making the SDES packet 28 octets in size.”
>
>     	this calculates , 4 (header)+4 (SSRC)+18(CNAME)+1(padding) = 27 octet ( + 1 octet of terminating chunk ? Or more padding?)

4 (header) + 4 (SSRC) + 18 (CNAME) + 1 (padding) + 1 (terminating) = 28.

I updated the text to be more explicit.

I’ll submit -10 with these changes.

Colin