IETF Logo Mail Archive

Re: [rtcweb] Review comments on draft-ietf-rtcweb-fec-04

Justin Uberti <juberti@google.com> Wed, 05 July 2017 02:46 UTC

Return-Path: <juberti@google.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2B638127977 for <rtcweb@ietfa.amsl.com>; Tue, 4 Jul 2017 19:46:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DmKangUX0Pmv for <rtcweb@ietfa.amsl.com>; Tue, 4 Jul 2017 19:46:30 -0700 (PDT)
Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C81A012EBFD for <rtcweb@ietf.org>; Tue, 4 Jul 2017 19:46:30 -0700 (PDT)
Received: by mail-io0-x236.google.com with SMTP id r36so78857801ioi.1 for <rtcweb@ietf.org>; Tue, 04 Jul 2017 19:46:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RcLe1YGzbSgGgtNpocoWpUek4YDzSz6wqu2xn7kda4w=; b=eSd/Sv90XrbNgfpXY18tk93ezUmY+xVmmsDVunjIdS18MFffmsuZFz1uT7ublrwuAJ y4BiFfOMnoSydPXnPBRPHYY0Bdp0TnkC5n8RpyoZRh50qrhta+T9OVWoyES2I2jqj2Yk nMZtvGhp5faRh36FLsSWLPeGk38us8bk+v8qr7l2IXcO/G0xPMclYe7yDl6Ja0H0tz/w tMM5E7TuLmYwEwMFns68aDxB8dYRTsnv9S3j1OXoYIPyGs+Teulbp7ksXWxfBCkpRKKH 5nrVxYJc4isCQlFz0RgoigauQfEy/FC4IurBZXkoz8cw/LQNPAwy507c0pA0RDdcVxf9 8CCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RcLe1YGzbSgGgtNpocoWpUek4YDzSz6wqu2xn7kda4w=; b=qPvuiDRPr1+8+URe3gWaS+zDYppWjDIpOWB6A5EMhs3Hv2gLTdu3oG4qCrLgfZXdM1 WrxU2Zp6VSC24hW5kl/CYG61h/UvXbfZkA7kGCIzQd3+zoFJ93vXbou66LnjFDie4FT9 69vjfLniim5YieNEuCfuqbrWTRknAhNQUIgaWAZiadCO/U/4yHPyt+XVNihLnR63st2b eCM+L2mKFeET4QmiY4lR72eQJMb9plblpPMuu37IJr1fTVafAMicQhNgTphnYwZv904A 0qCiWGwWOE7QVlqX/Lxmv3n2swxkuBjmadGLxeapjHwtbI0zSWxSDsm+S93k31lc6t9l 52nQ==
X-Gm-Message-State: AKS2vOyncAQrvsO7qlJBAG8Brypeyehgy+ZIkla1Ce0YOQGheRMAjo4Z uYGuCf16ALb/HEvVLyM5rx9qnVKBg4aR
X-Received: by 10.107.133.84 with SMTP id h81mr39933563iod.230.1499222789877; Tue, 04 Jul 2017 19:46:29 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.18.149 with HTTP; Tue, 4 Jul 2017 19:46:09 -0700 (PDT)
In-Reply-To: <CAOJ7v-3MMC8vhi8+uoTG_COF85p4BdVHp65B1z1etzQaXzzEoA@mail.gmail.com>
References: <39c31585-7e15-383d-a534-9efe8888695a@ericsson.com> <CAOJ7v-3MMC8vhi8+uoTG_COF85p4BdVHp65B1z1etzQaXzzEoA@mail.gmail.com>
From: Justin Uberti <juberti@google.com>
Date: Tue, 04 Jul 2017 19:46:09 -0700
Message-ID: <CAOJ7v-0KdtpTWSrc8EmUURb5K2AxHc=tKB1qZNhexvMnpUn=cQ@mail.gmail.com>
To: Magnus Westerlund <magnus.westerlund@ericsson.com>
Cc: "rtcweb@ietf.org" <rtcweb@ietf.org>
Content-Type: multipart/alternative; boundary="001a113f13a6d52fef05538901f3"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/WCCITvbM5ffKBF-VxS4si_RDfvk>
Subject: Re: [rtcweb] Review comments on draft-ietf-rtcweb-fec-04
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jul 2017 02:46:33 -0000

Thanks for the review. These issues have all been resolved in the latest
version of the draft, https://tools.ietf.org/html/draft-ietf-rtcweb-fec-06.

On Sat, Apr 22, 2017 at 12:46 PM, Justin Uberti <juberti@google.com> wrote:

>
>
> On Fri, Apr 21, 2017 at 2:07 AM, Magnus Westerlund <
> magnus.westerlund@ericsson.com> wrote:
>
>> Hi,
>>
>> I have review the -04 version of the FEC. I think the document is mostly
>> done. I only have these few comments that should be addressed before going
>> forward.
>>
>> 1. Section 4.2:
>>
>>    Support for redundant encoding MUST be indicated by offering "red" as
>>    a supported payload type in the offer.
>>
>> I think it is unclear what "red" refers to here. This as it is not made
>> clear that RFC 2198 has the media type audio/red and text/red. I think
>> there are two things that would make this clearer. One would be to change
>> "red" into media type "audio/red". The other would be to add the reference
>> afterwards.
>
>
> Adding the reference seems like a good idea. With that, the fact that it
> is audio/red seems implicit.
>
> https://github.com/juberti/draughts/issues/46
>
>>
>
>
>> 2. Section 12.1:
>>
>> It is missing this normative reference: [3GPP.26.114]
>>
>
> Agreed. I need to remember how to format such non-IETF references.
>
> https://github.com/juberti/draughts/issues/28
>
>>
>> 3. Section 12.1:
>>
>> I think that the following references have usages in the text that make
>> them normative:
>>
>> [RFC7587] and [RFC4867]
>>
>
> Agreed.
>
> https://github.com/juberti/draughts/issues/47
>

v2.23.0 | Report a Bug | By Email