Re: [rtcweb] JSEP issue regarding TRANSPORT/IDENTICAL mux category attributes
Justin Uberti <juberti@google.com> Fri, 14 April 2017 03:57 UTC
Return-Path: <juberti@google.com>
X-Original-To: rtcweb@ietfa.amsl.com
Delivered-To: rtcweb@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E54FF1294BE for <rtcweb@ietfa.amsl.com>; Thu, 13 Apr 2017 20:57:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6XgCmvMDp9x2 for <rtcweb@ietfa.amsl.com>; Thu, 13 Apr 2017 20:57:47 -0700 (PDT)
Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 88769129489 for <rtcweb@ietf.org>; Thu, 13 Apr 2017 20:57:47 -0700 (PDT)
Received: by mail-io0-x234.google.com with SMTP id a103so102333717ioj.1 for <rtcweb@ietf.org>; Thu, 13 Apr 2017 20:57:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ak65xamdxYQ4a6sZs+JEOo5xWSV1AGmCVDHWKTEK3kE=; b=fDSUPYfEzfsS/YYGq5KWq3IUYr5HhEygrU774KBorc0fae15w8wX+xrYrHHUbJkzWW P4L62X/aWaviTs620ku9Dz+/egkBh+UNhUUFpcneGaYHGjhA+kpFPuHZdOAXGjFhhcLo +HtFASMzi300abR1C5WHbPwrh+S2QIAk2CaHmkn93bwwS0+5rj4wdU6+PrS366IWGK3V 7YNupSFKpG0llR/DAk4K05tsXgfOwlHZp8C9xUo/nJG/X2BqixizdzXEJN3np0KTZD97 TCqKT9n0r+ubab+x/bY+yHSC3a8ODjRxHLgSnvNHbAC06daojqK06n11JOxlAyRL9/Wf 7F2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ak65xamdxYQ4a6sZs+JEOo5xWSV1AGmCVDHWKTEK3kE=; b=dooexOiEZMlv3VqQe1bZU1Kd7Sv1W1gipc2Jx4Z44KTUAeuB4vWiIw+6YaLvHB9Wxo wNvDARJJbaSr9KAvZn13MxMz8HCizowibyI6TuBIRCTi8i8HxyeTF4qM29yZ45JS5u/i obuSgq5SGBUhWWYt8NjhsatCXDxZPprchra4T3hXI4CyTkLhwj+tsO4peH1yhzW/MqSw zJ/it9pYvmWzmfl8n2sYUk0VaQL6hZqgFFr6kSsYvdug6upT9Y583vjqyQGl0l4C9zEc En/zTOBYgWXiqpTrma+FzIU9JOZmyQM3v99XgFkKHYzFRuKpF5yLmOHU3kHoIoJxUAMD sRvw==
X-Gm-Message-State: AN3rC/7kA65kMdNWJGNw4hqH0sZAPY+Aiy1ISUItyYCRlLS5WpWWznv7 AeQgeeC01F9qcx4iklj6EiK5p2lkkaLL
X-Received: by 10.36.29.1 with SMTP id 1mr8264900itj.97.1492142266730; Thu, 13 Apr 2017 20:57:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.138.143 with HTTP; Thu, 13 Apr 2017 20:57:26 -0700 (PDT)
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B4CB5A243@ESESSMB102.ericsson.se>
References: <D50D32D2.1AB0F%christer.holmberg@ericsson.com> <CAK35n0Z2kBKmu_0MciAD3sZsjBhQLE2_TAeE1ZhHnUwmhvaa3g@mail.gmail.com> <7594FB04B1934943A5C02806D1A2204B4CB5A243@ESESSMB102.ericsson.se>
From: Justin Uberti <juberti@google.com>
Date: Thu, 13 Apr 2017 20:57:26 -0700
Message-ID: <CAOJ7v-0rtB61mx6BNfvd9xDj6UJpyYd6RLQrV6qo_Y5mctFSAA@mail.gmail.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
Cc: Taylor Brandstetter <deadbeef@google.com>, "draft-ietf-rtcweb-jsep.all@tools.ietf.org" <draft-ietf-rtcweb-jsep.all@tools.ietf.org>, "rtcweb@ietf.org" <rtcweb@ietf.org>
Content-Type: multipart/alternative; boundary="001a1143eddac3d4e9054d187126"
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtcweb/b-fkqIKRWbDM5nBYlGddbhSbiWg>
Subject: Re: [rtcweb] JSEP issue regarding TRANSPORT/IDENTICAL mux category attributes
X-BeenThere: rtcweb@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Real-Time Communication in WEB-browsers working group list <rtcweb.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtcweb/>
List-Post: <mailto:rtcweb@ietf.org>
List-Help: <mailto:rtcweb-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtcweb>, <mailto:rtcweb-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Apr 2017 03:57:50 -0000
I think it makes sense for JSEP to reference appropriate text in bundle-negotiation. However, I didn't see the specific contradiction that you indicated in your initial email. Can you explain more? On Fri, Apr 7, 2017 at 11:05 AM, Christer Holmberg < christer.holmberg@ericsson.com> wrote: > Hi, > > > > >The suggestion to change "specifies that attributes... should not be > repeated" to "specifies when attributes ... MUST not be repeated" sounds > > >good to me. The actual "when" is described in more detail in the > following paragraphs. > > > > I don’t think we should describe the “when” in JSEP – at least not using > RFC 2119 terminology. We should reference the “Mux considerations” section > in BUNDLE. I have created a BUNDLE PR that (among other things) clarifies > the “when” within that section. > > > > https://github.com/cdh4u/draft-sdp-bundle/pull/33/commits/ > 9d3d02d04ca036e2b128d760b61c73e5dd1a0a48 > > > > JSEP also contains the following statement (and a number of similar > statements): > > > > “The following attributes, which are of category IDENTICAL or > > TRANSPORT, MUST appear only in "m=" sections which either have a > > unique address or which are associated with the bundle-tag.” > > > > While correct, I again think we should either reference to BUNDLE for the > “when”, OR say something like “According to BUNDLE, the following > attributes, which…”. > > > > That way, if something for whatever reason changes in BUNDLE, JSEP will > automatically be aligned. > > > > Regards, > > > > Christer > > > > > > > > On Fri, Apr 7, 2017 at 2:09 AM, Christer Holmberg < > christer.holmberg@ericsson.com> wrote: > > Hi, > > > > I have found an issue in JSEP. > > > > Section 5.2.1 says: > > > > "Each m= section, provided it is not marked as bundle-only, MUST > > generate a unique set of ICE credentials and gather its own unique > > set of ICE candidates. Bundle-only m= sections MUST NOT contain any > > ICE credentials and MUST NOT gather any candidates.” > > …and: > > "[I-D.ietf-mmusic-sdp-mux-attributes] groups SDP attributes into > > different categories. To avoid unnecessary duplication when > > bundling, Section 8.1 of [I-D.ietf-mmusic-sdp-bundle-negotiation] > > specifies that attributes of category IDENTICAL or TRANSPORT should > > not be repeated in bundled m= sections." > > > > > > First, the two paragraphs contradict each other, because the ICE > credentials (SDP ‘ice-ufrag’, ice-pwd’ etc attributes) are of TRANSPORT > category. > > > > Second, according to BUNDLE, IDENTICAL/TRANSPORT category attributes are > not duplicated if the m- section 1) contains a shared address (BUNDLE > address) or 2) is bundle-only. > > If the m- line contains a unique address, which is common in the initial > offer, attributes need to be associated with each m- line. However, the > text does not address that. > > > > I think the easiest way to fix it is by simply s/“specifies that > attributes”/ “specifies WHEN attributes”. > > > > …and change “should not” to “must not”. > > > > Regards, > > > > Christer > > > > > > > _______________________________________________ > rtcweb mailing list > rtcweb@ietf.org > https://www.ietf.org/mailman/listinfo/rtcweb > > > > _______________________________________________ > rtcweb mailing list > rtcweb@ietf.org > https://www.ietf.org/mailman/listinfo/rtcweb > >
- Re: [rtcweb] JSEP issue regarding TRANSPORT/IDENT… Justin Uberti
- [rtcweb] JSEP issue regarding TRANSPORT/IDENTICAL… Christer Holmberg
- Re: [rtcweb] JSEP issue regarding TRANSPORT/IDENT… Taylor Brandstetter
- Re: [rtcweb] JSEP issue regarding TRANSPORT/IDENT… Christer Holmberg