Re: [mpls] Review of draft-mirsky-mpls-bfd-bootstrap-clarify

Carlos Pignataro <cpignata@gmail.com> Mon, 05 February 2024 03:34 UTC

Return-Path: <cpignata@gmail.com>
X-Original-To: rtg-bfd@ietfa.amsl.com
Delivered-To: rtg-bfd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C86CDC14F689; Sun, 4 Feb 2024 19:34:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GXij0MNpl0Gw; Sun, 4 Feb 2024 19:34:53 -0800 (PST)
Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 252B0C14F619; Sun, 4 Feb 2024 19:34:53 -0800 (PST)
Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-dc6d7e3b5bfso3449240276.2; Sun, 04 Feb 2024 19:34:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707104092; x=1707708892; darn=ietf.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=LYsATUMz4dttBacvNvNoU+yY66EtDXAmhoYl3velK+o=; b=elOgbUqlw+FEIURr/uGLU/5m5Y19NXhyZcQUOmpw0YHkWADmFHphdhrPZJWRzr1o5w f3HBppqudPjpVd/M0G7qRIYJVWkQLObPPOx4D2NIDet+F/AYXMEd+NCz0IYvhMY8VV45 rUOlOqrXtXBqMdXBsFo1RgTu9O2WYhvZclFHpN122vrTFhFQtM/rTF1cAYH2L24vNn/M 3rHuqEy4Gup1xwB3K+1C2kGIh4CNqi4y1wDzG/C6SIoxnlsC98CsL7HzHJISDcRNhh3X HcYp4n9uhdAG8ZcaUyMzFk2pOA/OXMuA6jKYZzGagl9GwipOEldgPOl/qmdL5twFamle 1hIw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707104092; x=1707708892; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LYsATUMz4dttBacvNvNoU+yY66EtDXAmhoYl3velK+o=; b=v3jhSKI5bPORdl+h3pYRGkFPNdeuzra2lb5GK9lWhB36G92FUgHlp5cH8SFLU+3uyM y6WSqhZdow5XuZesdl5nf01JGjTwHPGvfwQWdrNV728aX8Avp120prYDjhQrQL2FMRiO yPBqUX0NCoGzS6/kPbV+VGCevUWELdTf7dmolkHqHwm5OpWAekVfptA5zBYVGkaBVGQf 7zkN30cNHEa8PqsF3MkjzhjjJtA0ftbnuF8LGeDeVGfmQ+HNMo/x8r6hSamxyWY8y7w5 T+xuoKqtQYtajsu+cU0VM+eebc5YTAALPfc2eBu+L2MyOA1t4fm94jw0HfBoPsbBSp5I wJ8A==
X-Gm-Message-State: AOJu0YztU4ZY1dpKpXbuM/bkD1hq5g1EzFlqIWz3XYfoJ+jg/+CeIwjZ GlrNKs4B3WDRDPLeuKENlBIcQ9Ye4l3XETCitd4AtCvaDTGvsaKwXAX8IoN8WT2hkQ==
X-Google-Smtp-Source: AGHT+IFV6V6JsO1/Pxl4klOPDKBPAQNa4o4dzNpQvx5BQSWVsEXeVGsnCBQTZiOiKcAA/9Dey1PLhA==
X-Received: by 2002:a25:4156:0:b0:dc6:ff55:29ee with SMTP id o83-20020a254156000000b00dc6ff5529eemr3406430yba.47.1707104091781; Sun, 04 Feb 2024 19:34:51 -0800 (PST)
X-Forwarded-Encrypted: i=0; AJvYcCXHMGiUYHKSSB6TFVHld3Ac0TqtME9fO3bNL20HQ/hC7WNdE15GMwxi441CdO3pBZeIg5h6Ad3UiZ8EGFc11yKh
Received: from smtpclient.apple ([136.56.7.30]) by smtp.gmail.com with ESMTPSA id v17-20020a05622a015100b0042bee53c585sm3283321qtw.36.2024.02.04.19.34.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Feb 2024 19:34:50 -0800 (PST)
From: Carlos Pignataro <cpignata@gmail.com>
Message-Id: <990F8663-4E94-4F75-A7F5-2A929EB5D6E5@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_B9070E2B-F8BF-4A70-9F9C-9F4E3DA618D5"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\))
Subject: Re: [mpls] Review of draft-mirsky-mpls-bfd-bootstrap-clarify
Date: Sun, 04 Feb 2024 22:34:39 -0500
In-Reply-To: <98DD113F-F363-4B9B-9011-CC8B594F4B90@pfrc.org>
Cc: mpls@ietf.org, "rtg-bfd@ietf. org" <rtg-bfd@ietf.org>
To: Jeff Haas <jhaas@pfrc.org>
References: <CACe62MmreLuNR5s10zhDCh+x2p1JXY1_J6dUPDtpcD9jEjsZQw@mail.gmail.com> <98DD113F-F363-4B9B-9011-CC8B594F4B90@pfrc.org>
X-Mailer: Apple Mail (2.3774.400.31)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-bfd/1KgTIYnXy1rv9FRhzqfPcf2zGXQ>
X-BeenThere: rtg-bfd@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "RTG Area: Bidirectional Forwarding Detection DT" <rtg-bfd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-bfd/>
List-Post: <mailto:rtg-bfd@ietf.org>
List-Help: <mailto:rtg-bfd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-bfd>, <mailto:rtg-bfd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2024 03:34:57 -0000

Thanks Jeff for refreshing the cache on those mailing-list comments.
I was part of that conversation, and frankly did not remember them — now I do. And to put that in perspective, that was almost 6 **years** ago! 

I also missed the Errata, which was good.
And there’s also a couple other held for doc update: https://www.rfc-editor.org/errata_search.php?rfc=5884 

I will start with the last bit, borrowing from your text Jeff: Carlos is also completely unaware of anyone experiencing any sort of confusion covering RFC 5884 procedures other than Greg.

And also, it’s a clarification that does not hurt.

I do not feel norao impacts 5884, but at the same time bundling all the updates on a RFC 5884-bis sounds like a most appropriate suggestion to me. I’m happy to help if needed.

And to that, I’d also bundle in the changes from RFC 7726.

Thanks,

Carlos.


> On Feb 4, 2024, at 11:36 AM, Jeffrey Haas <jhaas@pfrc.org> wrote:
> 
> +bfd WG.
> 
> Some original comments to Adrian were:
> 
> https://mailarchive.ietf.org/arch/msg/rtg-bfd/SYouXfNrVyKHErqacOuM2fICzMc/
> 
> Apparently, Greg didn't consider this worth holding his peace over.
> 
> https://www.rfc-editor.org/errata/eid5085 was filed and accepted as a clarification for RFC 5884 as part of a prior round of this discussion.
> 
> LSP Ping is getting its norao update currently in MPLS.  While it's my opinion that the current set of changes to that document don't negatively impact backward compatibility with RFC 5884, it's a normative enough change that perhaps it's worth moving forward with the small updates to RFC 5884.
> 
> In my opinion, the appropriate work is to take this to BFD for RFC 5884-bis, which would be co-reviewed with MPLS.  I believe we can get at least one of the original authors to pick up that work.
> 
> That said, the BFD chairs are completely unaware of anyone experiencing any sort of confusion covering RFC 5884 procedures other than Greg.
> 
> -- Jeff
>  
> 
> 
>> On Jan 24, 2024, at 2:55 PM, Carlos Pignataro <cpignata@gmail.com <mailto:cpignata@gmail.com>> wrote:
>> 
>> Hi!
>> 
>> Review of draft-mirsky-mpls-bfd-bootstrap-clarify
>> Version 05
>> Type Getting Ready for WG Adoption
>> Team MPLS WG Review Team
>> Reviewer: Carlos Pignataro 
>> 
>> I have been asked to provide a ‘getting ready for WG adoption’ review of this document, on behalf of the MPLS WG review team.
>> 
>> There are generally two relevant questions at this stage:
>> 
>> 1. knowing whether the document is in scope for the working group, and
>> 2. knowing whether the document is ready to be considered for WG adoption
>> 
>> My perspective is that:
>> 
>> 1. Maybe - RFC 4884, the RFC that this document would update if approved, was progressed as draft-ietf-bfd-mpls in the bfd wg. As such, I wonder if that ought to be followed here. From a practical standpoint, both WGs (mpls and bfd) would have to review this document, but it is a chair decision and guidance whether this should live in mpls or bfd (and frankly I have no strong position either way so long as both WGs are in the loop, simply pointing historic datapoints.) The document is clearly in scope on the intersection of both WGs, and historically was in bfd.
>> 
>> 2. Yes – this document addresses clear clarifications for implementation interoperability. Granted, this protocol is deployed without these clarifications, but are (at least) theoretical gaps.
>> 
>> A couple of further comments, since I read the document. Overall, well written and clear, achieves its goal, and:
>> 
>> a. Backwards compatibility is paramount, and neither of those two words appear in the document. I recommend a section detailing implications.
>> 
>> b. Section 5, IPv6, seems like an after-though, since it is not mentioned in the Abstract. Further, that case and explanation is well covered in RFC 8029, and as such seems like a distraction.
>> 
>> c. There are various nits and an editorial pass would help with clarity. These include things like unqualified “echo reply” uses.
>> 
>> Thanks,
>> 
>> Carlos Pignataro
>> 
>> _______________________________________________
>> mpls mailing list
>> mpls@ietf.org <mailto:mpls@ietf.org>
>> https://www.ietf.org/mailman/listinfo/mpls
>