[RTG-DIR] Review of draft-ietf-isis-layer2-09

Ross Callon <rcallon@juniper.net> Mon, 03 January 2011 00:57 UTC

Return-Path: <rcallon@juniper.net>
X-Original-To: rtg-dir@core3.amsl.com
Delivered-To: rtg-dir@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 95BB63A6936 for <rtg-dir@core3.amsl.com>; Sun, 2 Jan 2011 16:57:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -106.593
X-Spam-Level:
X-Spam-Status: No, score=-106.593 tagged_above=-999 required=5 tests=[AWL=0.005, BAYES_00=-2.599, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zNXBetP+aeTP for <rtg-dir@core3.amsl.com>; Sun, 2 Jan 2011 16:57:16 -0800 (PST)
Received: from exprod7og105.obsmtp.com (exprod7og105.obsmtp.com [64.18.2.163]) by core3.amsl.com (Postfix) with ESMTP id 4C5673A6933 for <rtg-dir@ietf.org>; Sun, 2 Jan 2011 16:57:07 -0800 (PST)
Received: from source ([66.129.224.36]) (using TLSv1) by exprod7ob105.postini.com ([64.18.6.12]) with SMTP ID DSNKTSEfYjgBQbuxFwgpXBV3titx7rbTD4jS@postini.com; Sun, 02 Jan 2011 16:59:22 PST
Received: from p-emfe01-wf.jnpr.net (172.28.145.24) by P-EMHUB03-HQ.jnpr.net (172.24.192.37) with Microsoft SMTP Server (TLS) id 8.2.254.0; Sun, 2 Jan 2011 16:53:45 -0800
Received: from EMBX01-WF.jnpr.net ([fe80::8002:d3e7:4146:af5f]) by p-emfe01-wf.jnpr.net ([fe80::d0d1:653d:5b91:a123%11]) with mapi; Sun, 2 Jan 2011 19:53:45 -0500
From: Ross Callon <rcallon@juniper.net>
To: "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Date: Sun, 02 Jan 2011 19:53:43 -0500
Thread-Topic: Review of draft-ietf-isis-layer2-09
Thread-Index: AcuqGEmc33rSojB0SmODdRqwfGAMNwAx5NEQ
Message-ID: <DF7F294AF4153D498141CBEFADB177049AC8B6E657@EMBX01-WF.jnpr.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: multipart/alternative; boundary="_000_DF7F294AF4153D498141CBEFADB177049AC8B6E657EMBX01WFjnprn_"
MIME-Version: 1.0
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-isis-layer2.all@tools.ietf.org" <draft-ietf-isis-layer2.all@tools.ietf.org>
Subject: [RTG-DIR] Review of draft-ietf-isis-layer2-09
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/rtg-dir>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jan 2011 00:57:21 -0000

Hello,
I have been asked to provide an additional Routing Directorate review for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://www.ietf.org/iesg/directorate/routing.html
Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.
Document: draft-ietf-isis-layer2-09.txt
Reviewer: Ross Callon
Review Date: 2011-01-02
IETF LC End Date: 2010-12-14
Intended Status: proposed standard
Summary:
I have only very minor concerns about this document. While these are of a nature that the RFC editor staff might be expected to identify and fix, you may nonetheless want to resolve these before publication.
Comments:
The document is well written and structured, and generally conforms to the conventional definition of IS-IS TLVs.
Major Issues:
No major issues found.
Minor Issues:

Section 2.2, The bullet item "Type: TLV Type, set to MT-PORT-CAP TLV 143 [TBD]."

My understanding is that the value 143 was incorrectly picked (and overlaps with a different meaning of the same value). My understanding is also that the "TBD" means that this was tentative. This will need to be corrected prior to publication, and you might want to add an RFC editor's note to this effect (or at least make sure that you check this during auth-48).


Section 6.2, informative references. The third reference. I believe that this is to "draft-ietf-trill-rbridge-protocol-16.txt", which is in the RFC editor's queue waiting on a normative reference to this document. It would be less confusing to include the draft name. My understanding is that the RFC editor will then replace this with the RFC when both are published together.