[RTG-DIR] Rtgdir last call review of draft-ietf-rift-rift-20

Loa Andersson via Datatracker <noreply@ietf.org> Tue, 19 March 2024 09:24 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: rtg-dir@ietf.org
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A5C5AC18DB96; Tue, 19 Mar 2024 02:24:10 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Loa Andersson via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: draft-ietf-rift-rift.all@ietf.org, last-call@ietf.org, rift@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.8.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171084025066.20222.12149424859698001324@ietfa.amsl.com>
Reply-To: Loa Andersson <loa@pi.nu>
Date: Tue, 19 Mar 2024 02:24:10 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/mpPgWxSpNBPMzX21piV0SxbXfzc>
Subject: [RTG-DIR] Rtgdir last call review of draft-ietf-rift-rift-20
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Mar 2024 09:24:10 -0000

Reviewer: Loa Andersson
Review result: Has Nits


I have been selected as the Routing Directorate reviewer for this draft. 
The Routing Directorate seeks to review all routing or routing-related 
drafts as they pass through IETF last call and IESG review, and 
sometimes on special request. The purpose of the review is to provide 
assistance to the Routing ADs. For more information about the Routing 
Directorate, please see https://wiki.ietf.org/en/group/rtg/RtgDir

Although these comments are primarily for the use of the Routing ADs, it 
would be helpful if you could consider them along with any other IETF 
Last Call comments that you receive, and strive to resolve them through 
discussion or by updating the draft.

Document: draft-ietf-rift-rift-20 (the current version is -20)
Reviewer: Loa Andersson
Review Date: 2024-03-19
IETF LC End Date:
Intended Status: Standards Track


This document is basically ready for publication (with nits) ; though I found it a bit
hard to read.

- at least for me the appendixes contain info that was useful when it
  came to understand the document. This could be mentioned early in the 
  document. Admittedly the Readers Digest does a good work, but it is 
  quite a bit into the document.

Document Overview:

This document defines a routing protocol for Clos and fat tree network
topologies optimized towards control plane state efficiency and a 
minimum of configuration and operational complexity.

Note: One have to get far into the document (even into appindixes) before
you understand the specification of that protocol


The draft is long (189 pages), and it takes time to get through all the
details. That said the authors does a good job, it is more that the 
topic is new and fairly complicated. Especially the "Readers Disgest"
section is useful and I had to return to it serval times,

Major Issues:


Minor Issues


The abstract of a bit thin, I can't really get what it is asll about
from just reading the abstract, and that it what is there for, right?


There is a long list of nits found by the nits-tool (not running 
verbose), please fix those!

In the abstract you say "clos and fat tree topologies", in the the
Terminology section you say "This document uses the terms Clos and 
Fat Tree interchangeably".
Should the abstract asy "clos or fat tree topologies"?
Caveat: This is a grammar comment and I do not normally make grammar
comments :)!

You mixed "terms" and "abbreviations", have concidered two lists?

In section 5.3.1 you use "acronym", I think the preferred word is 
All acronyms are abbreviations, but not all abbreviations are acronyms.

One question on the policy defintion in the IANA registries, can you
have a reference to an Appendix in the IANA registry?

I have not found any other nits.


Loa Andersson                        email: loa@pi.nu
Senior MPLS Expert                          loa.pi.nu@gmail.com
Bronze Dragon Consulting             phone: +46 739 81 21 64