[RTG-DIR] RtgDir review: draft-smirnov-ospf-xaf-te

IJsbrand Wijnands <ice@cisco.com> Fri, 20 May 2016 12:32 UTC

Return-Path: <ice@cisco.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 525EF12D82F; Fri, 20 May 2016 05:32:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.947
X-Spam-Level:
X-Spam-Status: No, score=-15.947 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O83LDnWi2xcN; Fri, 20 May 2016 05:31:59 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39D1C12D19E; Fri, 20 May 2016 05:31:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1876; q=dns/txt; s=iport; t=1463747518; x=1464957118; h=from:content-transfer-encoding:subject:date:message-id: cc:to:mime-version; bh=zH1AqYi6C69DBK2f0yxXy25JT2NsVje3T6lBLOKJQcw=; b=f01em/8Y1IKmqyZg5qfItiOmRgSPHmyrq/gTPPch+xiAVYw6Ore6yOsw 3fZB37LN98HqBjfh3oe39cqZlRk6ll+D8+pqiY36brA8lddQO4FQ1NB2J Yj7GSgCOo0CXfq6u1c2oHJLBnhEzeDl3IhT82Iu9w1Dg1lqlw3kF44Jo7 Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CNBgBcAz9X/xbLJq1ehA1+AaU7AgIIDAEBAQEBAQUBgQ+DBJIaIoVvggQBAQEBAQFmJ4RsVhkWBgImAl+IQg6VBp0dkWEBAQEBAQEEAQEBAQEBAQEBHoEBhFyCPgiEX4UwK4IuBZg0hgCIIIFpToQBiGSPS2KDbzoziAIBAQE
X-IronPort-AV: E=Sophos;i="5.26,339,1459814400"; d="scan'208";a="635740922"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2016 12:31:56 +0000
Received: from ams-iwijnand-88113.cisco.com (ams-iwijnand-88113.cisco.com [10.60.202.94]) by aer-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id u4KCVt28005874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 May 2016 12:31:56 GMT
From: IJsbrand Wijnands <ice@cisco.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 20 May 2016 14:31:55 +0200
Message-Id: <887E0412-D057-4404-ACED-69F7B162AEC5@cisco.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
X-Mailer: Apple Mail (2.2104)
Archived-At: <http://mailarchive.ietf.org/arch/msg/rtg-dir/uUjcpUA8BgsxBUvwjXQmMSERSkY>
Cc: rtg-dir@ietf.org, draft-smirnov-ospf-xaf-te@ietf.org
Subject: [RTG-DIR] RtgDir review: draft-smirnov-ospf-xaf-te
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2016 12:32:00 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-smirnov-ospf-xaf-te 
Reviewer: IJsbrand Wijnands 
Review Date: 20-05-2016
Intended Status: Standards Track

Summary: 

This document is basically ready for publication, but has nits that should be considered prior to publication.

Comments:

This document is well written and the use-case is very clear and useful to solve. Does this also solve the use-case for P2MP TE LSPs? If it does, maybe its good to mention this. I do think it has consequences as it requires an IPv4/IPv6 explicit NULL label, if you want to share IPv4 and IPv6 traffic over the same P2MP LSP.


Major Issues: 
No major issues found.

Minor Issues: 

Section 3.
"For example, suppose the OSPFv2 instance …”

This paragraph could benefit from a rewrite as I find it hard to follow what the intention is. I would also advise not to use real IP addresses as an example since the actual value does not matter. Better to say IPv4_1, IPv4_2,.. IMO. 

Nits:

The acronym “ASON” is used in this document, but it is not spelled out what it stands for.

Thx,

Ice.