Re: [RTG-DIR] RtgDir review: draft-smirnov-ospf-xaf-te

"Acee Lindem (acee)" <acee@cisco.com> Fri, 20 May 2016 13:46 UTC

Return-Path: <acee@cisco.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E14C12D0EA; Fri, 20 May 2016 06:46:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.946
X-Spam-Level:
X-Spam-Status: No, score=-15.946 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id orCY5Wio4MRX; Fri, 20 May 2016 06:46:03 -0700 (PDT)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 175E012D513; Fri, 20 May 2016 06:46:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=10367; q=dns/txt; s=iport; t=1463751963; x=1464961563; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Z6kpOeNMcJ6HFVUV1fZgFfTPlPi1j45wJ7t8BzVkgYw=; b=H6i1KQXw7AYdoaDZ4Ui4S8qDPENjGgSJHUNcD7qC1kODt8HcO1ZADCIw dNNhzq5D590Tk3MfCt4EBhq25hN2yWUDfeIX1iSvn0lajtR57eLr0ayrb X/Oia0QkGl7MYynmW4jf/wVzjGEtLqagkRb33zuYpWaSLdl7vqgtW3hez g=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0BHAgD3Ez9X/49dJa1egmxLVn0GrhSGdoR5AQ2BdSKFbwIcgRo4FAEBAQEBAQFlJ4RCAQEBBCNWEAIBBgIOAwMBAigDAgICHxEUCQgCBAENBYgVAxcOlRedHY0hDYQwAQEBAQEBAQEBAQEBAQEBAQEBAQEBHIpygkOCHIJhglkFmAEzAYV/hieBeYFpToQBiGSHY4dnAQ8PAQFCg21uAYcDfwEBAQ
X-IronPort-AV: E=Sophos;i="5.26,339,1459814400"; d="scan'208,217";a="274074304"
Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2016 13:46:02 +0000
Received: from XCH-RTP-008.cisco.com (xch-rtp-008.cisco.com [64.101.220.148]) by rcdn-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id u4KDk1WH026772 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 20 May 2016 13:46:02 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-008.cisco.com (64.101.220.148) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Fri, 20 May 2016 09:46:01 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1104.009; Fri, 20 May 2016 09:46:01 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Alia Atlas <akatlas@gmail.com>, "IJsbrand Wijnands (iwijnand)" <ice@cisco.com>
Thread-Topic: [RTG-DIR] RtgDir review: draft-smirnov-ospf-xaf-te
Thread-Index: AQHRspOfqf+uKT3yUkukqL/OW1QYYJ/CBicA///QkgA=
Date: Fri, 20 May 2016 13:46:00 +0000
Message-ID: <D3648C9D.61DA9%acee@cisco.com>
References: <887E0412-D057-4404-ACED-69F7B162AEC5@cisco.com> <CAG4d1rfv8wRZPg2Wojf9KSAKOdKipKv-cHaaG=1NYaNjkOwhtA@mail.gmail.com>
In-Reply-To: <CAG4d1rfv8wRZPg2Wojf9KSAKOdKipKv-cHaaG=1NYaNjkOwhtA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.196]
Content-Type: multipart/alternative; boundary="_000_D3648C9D61DA9aceeciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/rtg-dir/wDVNNymAZUtVJ1IklA5Pw6UlKf8>
Cc: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-smirnov-ospf-xaf-te@ietf.org" <draft-smirnov-ospf-xaf-te@ietf.org>
Subject: Re: [RTG-DIR] RtgDir review: draft-smirnov-ospf-xaf-te
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2016 13:46:09 -0000

Yes - thanks Ice,
Acee

P.S.  ASON stands for Automatically Switched Optical Networks with the OSPF extensions defined in RFC 5787.


From: rtg-dir <rtg-dir-bounces@ietf.org<mailto:rtg-dir-bounces@ietf.org>> on behalf of Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>>
Date: Friday, May 20, 2016 at 8:35 AM
To: "IJsbrand Wijnands (iwijnand)" <ice@cisco.com<mailto:ice@cisco.com>>
Cc: "<rtg-ads@ietf.org<mailto:rtg-ads@ietf.org>>" <rtg-ads@ietf.org<mailto:rtg-ads@ietf.org>>, Routing Directorate <rtg-dir@ietf.org<mailto:rtg-dir@ietf.org>>, "draft-smirnov-ospf-xaf-te@ietf.org<mailto:draft-smirnov-ospf-xaf-te@ietf.org>" <draft-smirnov-ospf-xaf-te@ietf.org<mailto:draft-smirnov-ospf-xaf-te@ietf.org>>
Subject: Re: [RTG-DIR] RtgDir review: draft-smirnov-ospf-xaf-te

Ice,

Thank you for doing this review.

Regards,
Alia

On Fri, May 20, 2016 at 8:31 AM, IJsbrand Wijnands <ice@cisco.com<mailto:ice@cisco.com>> wrote:
Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-smirnov-ospf-xaf-te
Reviewer: IJsbrand Wijnands
Review Date: 20-05-2016
Intended Status: Standards Track

Summary:

This document is basically ready for publication, but has nits that should be considered prior to publication.

Comments:

This document is well written and the use-case is very clear and useful to solve. Does this also solve the use-case for P2MP TE LSPs? If it does, maybe its good to mention this. I do think it has consequences as it requires an IPv4/IPv6 explicit NULL label, if you want to share IPv4 and IPv6 traffic over the same P2MP LSP.


Major Issues:
No major issues found.

Minor Issues:

Section 3.
"For example, suppose the OSPFv2 instance …”

This paragraph could benefit from a rewrite as I find it hard to follow what the intention is. I would also advise not to use real IP addresses as an example since the actual value does not matter. Better to say IPv4_1, IPv4_2,.. IMO.

Nits:

The acronym “ASON” is used in this document, but it is not spelled out what it stands for.

Thx,

Ice.