IETF Logo Mail Archive

Re: Yangdoctors early review of draft-ietf-rtgwg-routing-types-04

"Acee Lindem (acee)" <acee@cisco.com> Wed, 24 May 2017 16:23 UTC

Return-Path: <acee@cisco.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0BFB5126FB3; Wed, 24 May 2017 09:23:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.522
X-Spam-Level:
X-Spam-Status: No, score=-14.522 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jPEnCKKvNfsl; Wed, 24 May 2017 09:23:34 -0700 (PDT)
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5E121128BB7; Wed, 24 May 2017 09:23:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1934; q=dns/txt; s=iport; t=1495643014; x=1496852614; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4HaU5nOvfse3Vl8NXD8T2RprQHiyKUEONqEXINiY/zE=; b=lylGHcPGuLmO5Sz4hMcTCLJgBHwpC/cPIdu7/gf0zr2ZRt7V5JIOJYHO Wa82HBHrKoRLS6ii/JKG3vf6JPGzjqcc3cOeEAuhYqLqa2WfNOIroKB/L qtTU0ymM44sWUXhM/wfCK3Q+K5pbhGU1Dcr0TksmT0zLQNm6UUOTxxwr6 I=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DTAQCfsiVZ/5pdJa1cGQEBAQEBAQEBAQEBBwEBAQEBg1WBbgeDaLFqgg+GJAIagldAFwECAQEBAQEBAWsohRkGIxFFEAIBBgIaAiYCAgIwFRACBAENBYomjx+dYIImi0ABAQEBAQEBAQEBAQEBAQEBAQEBAQEdgQuHMoMchGSDEoJBHwEEniMBkyeCBoU8ijWUTQEhAjSBCnEVhzx2iBaBDQEBAQ
X-IronPort-AV: E=Sophos;i="5.38,387,1491264000"; d="scan'208";a="430319491"
Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2017 16:23:33 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by rcdn-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id v4OGNXSS013109 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 24 May 2017 16:23:33 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 24 May 2017 12:23:32 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1210.000; Wed, 24 May 2017 12:23:32 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Radek Krejčí <rkrejci@cesnet.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-rtgwg-routing-types.all@ietf.org" <draft-ietf-rtgwg-routing-types.all@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>
Subject: Re: Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
Thread-Topic: Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
Thread-Index: AQHS1HriMukYolvWj0qJjqW/bAhXHqIDqzAA
Date: Wed, 24 May 2017 16:23:32 +0000
Message-ID: <D54B2AD5.B085A%acee@cisco.com>
References: <823c6e8a-9544-5544-8a99-d05c0ffc7017@cesnet.cz>
In-Reply-To: <823c6e8a-9544-5544-8a99-d05c0ffc7017@cesnet.cz>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.196]
Content-Type: text/plain; charset="utf-8"
Content-ID: <B4D92D93E5D82644AED8F289ADCB6A81@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/04P1pQKrad0A_RS3os-ELgERJoE>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 May 2017 16:23:36 -0000

Hi Radek, 

I believe I have addressed your YANG Doctor comments in the -05 version of
the draft. I used the template in RFC6087Bis, Appendix C which resulted in
some reorganization of ietf-routing-types.

Thanks,
Acee 

On 5/24/17, 6:45 AM, "Radek Krejčí" <rkrejci@cesnet.cz> wrote:

>Reviewer: Radek Krejčí
>Review result: Ready with Nits
>
>I have reviewed changes made to draft-ietf-rtgwg-routing-types between
>revision 02 and 04 (04 was published just a week after 03). The main
>change is splitting the module into 2 modules: ietf-routing-types and
>iana-routing-types.
>
>iana-routing-types:
>- since it is IANA-maintained module, IANA should be the 'organization'
>and also the 'contact' value should be changed accordingly (see
>iana-if-type)
>
>ietf-routing-types:
>- please follow the contact template available in RFC 6087 Appendix B (or
>RFC6087bis, Appendix C)
>
>draft text:
>- if iana-routing-types is supposed to be IANA-maintained module, isn't
>IANA also supposed to be XML registrant contact (IANA Considerations
>section)? 
>- my fault from previous review - since the module imports
>ietf-yang-types, it MUST contain reference to its RFC, which is RFC 6991
>(not RFC 6021 as I wrote in my review). So move RFC 6991 reference from
>Informative references section into Normative references where it will
>replace reference to RFC 6021.
>
>Radek

v2.23.0 | Report a Bug | By Email