IETF Logo Mail Archive

Re: [Rtg-dt-yang-arch] Yangdoctors early review of draft-ietf-rtgwg-routing-types-04

Jeff Tantsura <jefftant.ietf@gmail.com> Tue, 13 June 2017 09:51 UTC

Return-Path: <jefftant.ietf@gmail.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 27E3D1317A8; Tue, 13 Jun 2017 02:51:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vtgY5AsWyqVp; Tue, 13 Jun 2017 02:51:25 -0700 (PDT)
Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CE5C31314A0; Tue, 13 Jun 2017 02:38:18 -0700 (PDT)
Received: by mail-lf0-x22c.google.com with SMTP id o83so66001007lff.3; Tue, 13 Jun 2017 02:38:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :references:in-reply-to:mime-version:content-transfer-encoding; bh=KvjHkcO+J41Sa3zR5uLgdnkgOOAEWYnqAdwukqqD99A=; b=vTh5jHsaWSpooyyEzbSaVb1IvlOPyRC+Z77I3ZSkDeDhRfbDFSiO2mdqGtGSxitFOU I0n4NYwLbbwAzkud7oSW6Ea4KGissgI10QEpTHTvvdN4UNqpD5nms1le1gH5y4HJPFOp QQ3o5BfsxTSppc7DlY3fxbyISJ88iKt/vHiWsy29a143xlxXl2LPoAXzW4dJOyPZNnOP bit+5pTReZEc74W7aEeDz5ii4pZoDE8uOAbP7KtYzgaeZHoIPnBK/Mbu+4CuwmCBsUfD lmsKDOnneGmsRlMLHz8hJj7bTMaP9cMlWy3oewztxk+NUc6kFtYqvb4ClKEByP3tBOQp x/pA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:date:subject:from:to:cc:message-id :thread-topic:references:in-reply-to:mime-version :content-transfer-encoding; bh=KvjHkcO+J41Sa3zR5uLgdnkgOOAEWYnqAdwukqqD99A=; b=UWkrW6FuwI4gCnEz9lkPwIHObY/XMrtf7UiD63LXl2/UfIkltRNLU9hEw9FW4+f+wW mHLnCKPNtnIhpol9Q3yi98ShAjYEuO5vHmKksPq/jtMrR62ZG5eFiBTtb2n9RWitOopv +JQ/yhovUbkXxNbWY9GPNu+1MapIeViBSJfgCOA8TiHTc1c8ForMOFtIqXwqfdON1U3z N19gL7fqI2kHNG2QhZEtBARiM6JRhTBd3FZ36645GfA/Czkaei5QLQXbv6OZAsXtDpbb Wz9aeEIiUW3Qxs1lyXq//W7x/cPEPjj64ii8hW9ywMZCNv+QQ59AEfmLo/UsIzatCqWQ UcDw==
X-Gm-Message-State: AODbwcB8W+hA3iHL9ZrWPWpqlJMmTXrBFbuPMHOrLc5AVXmvQud8sDlO JoWgTfCeDVxjQlWQ
X-Received: by 10.46.22.66 with SMTP id 2mr14667363ljw.35.1497346697037; Tue, 13 Jun 2017 02:38:17 -0700 (PDT)
Received: from [130.237.14.64] (conf-n14-p64.kthopen.kth.se. [130.237.14.64]) by smtp.gmail.com with ESMTPSA id z10sm3231795lja.24.2017.06.13.02.38.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jun 2017 02:38:16 -0700 (PDT)
User-Agent: Microsoft-MacOutlook/f.21.0.170409
Date: Tue, 13 Jun 2017 02:38:16 -0700
Subject: Re: [Rtg-dt-yang-arch] Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
From: Jeff Tantsura <jefftant.ietf@gmail.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
CC: RTG YANG Design Team <rtg-dt-yang-arch@ietf.org>, Chris Bowers <cbowers@juniper.net>, Routing WG <rtgwg@ietf.org>
Message-ID: <EAFB61D8-072F-4157-B6B6-F0DDDC42EE28@gmail.com>
Thread-Topic: [Rtg-dt-yang-arch] Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
References: <823c6e8a-9544-5544-8a99-d05c0ffc7017@cesnet.cz> <D54B2AD5.B085A%acee@cisco.com> <6fc7d6b3-bf13-6861-01d3-c0ed52532629@cesnet.cz> <D564AC33.B2C6F%acee@cisco.com> <AB43025D-7A16-4084-A597-1E35B10D7A72@gmail.com>
In-Reply-To: <AB43025D-7A16-4084-A597-1E35B10D7A72@gmail.com>
Mime-version: 1.0
Content-type: text/plain; charset="UTF-8"
Content-transfer-encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/fH_JyErB0wLoHdTvd0ytX58K1nE>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jun 2017 09:51:27 -0000

Acee,

Please fix nits.
 
Cheers,
Jeff
 

On 6/13/17, 00:45, "Rtg-dt-yang-arch on behalf of Jeff Tantsura" <rtg-dt-yang-arch-bounces@ietf.org on behalf of jefftant@gmail.com> wrote:

    Hi Acee,
    
    Thanks, will do.
    
    Regards,
    Jeff
    
    > On Jun 12, 2017, at 17:39, Acee Lindem (acee) <acee@cisco.com> wrote:
    > 
    > Jeff, Chris, 
    > 
    > The authors believe we are ready for a WG last call.
    > 
    > Thanks,
    > Acee 
    > 
    >> On 6/12/17, 2:32 AM, "Radek Krejčí" <rkrejci@cesnet.cz> wrote:
    >> 
    >> Hi Acee,
    >> 
    >> sorry for the delay. I've checked the changes and the document as well as
    >> both the modules seem fine to me now.
    >> 
    >> Regards,
    >> Radek
    >> 
    >> 
    >> Dne 24.5.2017 v 18:23 Acee Lindem (acee) napsal(a):
    >>> Hi Radek, 
    >>> 
    >>> I believe I have addressed your YANG Doctor comments in the -05 version
    >>> of
    >>> the draft. I used the template in RFC6087Bis, Appendix C which resulted
    >>> in
    >>> some reorganization of ietf-routing-types.
    >>> 
    >>> Thanks,
    >>> Acee 
    >>> 
    >>>> On 5/24/17, 6:45 AM, "Radek Krejčí" <rkrejci@cesnet.cz> wrote:
    >>>> 
    >>>> Reviewer: Radek Krejčí
    >>>> Review result: Ready with Nits
    >>>> 
    >>>> I have reviewed changes made to draft-ietf-rtgwg-routing-types between
    >>>> revision 02 and 04 (04 was published just a week after 03). The main
    >>>> change is splitting the module into 2 modules: ietf-routing-types and
    >>>> iana-routing-types.
    >>>> 
    >>>> iana-routing-types:
    >>>> - since it is IANA-maintained module, IANA should be the 'organization'
    >>>> and also the 'contact' value should be changed accordingly (see
    >>>> iana-if-type)
    >>>> 
    >>>> ietf-routing-types:
    >>>> - please follow the contact template available in RFC 6087 Appendix B
    >>>> (or
    >>>> RFC6087bis, Appendix C)
    >>>> 
    >>>> draft text:
    >>>> - if iana-routing-types is supposed to be IANA-maintained module, isn't
    >>>> IANA also supposed to be XML registrant contact (IANA Considerations
    >>>> section)? 
    >>>> - my fault from previous review - since the module imports
    >>>> ietf-yang-types, it MUST contain reference to its RFC, which is RFC
    >>>> 6991
    >>>> (not RFC 6021 as I wrote in my review). So move RFC 6991 reference from
    >>>> Informative references section into Normative references where it will
    >>>> replace reference to RFC 6021.
    >>>> 
    >>>> Radek
    >> 
    > 
    
    _______________________________________________
    Rtg-dt-yang-arch mailing list
    Rtg-dt-yang-arch@ietf.org
    https://www.ietf.org/mailman/listinfo/rtg-dt-yang-arch

v2.23.0 | Report a Bug | By Email