Re: [Rtg-dt-yang-arch] Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
"Acee Lindem (acee)" <acee@cisco.com> Tue, 13 June 2017 16:58 UTC
Return-Path: <acee@cisco.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D758113145C; Tue, 13 Jun 2017 09:58:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.522
X-Spam-Level:
X-Spam-Status: No, score=-14.522 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oXMu4mmz7Are; Tue, 13 Jun 2017 09:58:50 -0700 (PDT)
Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E63813012B; Tue, 13 Jun 2017 09:58:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4694; q=dns/txt; s=iport; t=1497373130; x=1498582730; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=TfLtjQtErgmK3vjLZBNGH/QcnjP5c3HtlhGWoT1YGPY=; b=eP86dM9XXxgTClrplS8I0+qMOil1yhArpgr6m3/2QEtsDya8M9GBpHD/ 3kCDbmxB98YxVBtLnuFJZptvEEhhXx5K9SSbMOYqhx4+OrEdtNlRJtAWj K869LLXa5Y49rVSuUVrXMmyWItk2SrfArsqnBu7pisLUYyK7TBj8Gy7M8 M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AHAQCjGEBZ/4kNJK1dGQEBAQEBAQEBAQEBBwEBAQEBg1higQ0Hg22KGJFyiCqNWYIRIQuFeAIagig/GAECAQEBAQEBAWsohRkBAQEDAQEhEToLEAIBBgIYAgImAgICHwYLFRACBA4FihQDFRCQMp1hgiaHNQ2DewEBAQEBAQEBAQEBAQEBAQEBAQEBARgFgQuHNoMggliCEheCe4JCHwWeCDsCjmmEZIIHhUOKPotMiScBHziBCnQVSIUMHBmBTXaIXIENAQEB
X-IronPort-AV: E=Sophos;i="5.39,338,1493683200"; d="scan'208";a="255463690"
Received: from alln-core-4.cisco.com ([173.36.13.137]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Jun 2017 16:58:49 +0000
Received: from XCH-RTP-011.cisco.com (xch-rtp-011.cisco.com [64.101.220.151]) by alln-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id v5DGwnlQ032701 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 13 Jun 2017 16:58:49 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-011.cisco.com (64.101.220.151) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 13 Jun 2017 12:58:48 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1210.000; Tue, 13 Jun 2017 12:58:48 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Jeff Tantsura <jefftant.ietf@gmail.com>
CC: RTG YANG Design Team <rtg-dt-yang-arch@ietf.org>, Chris Bowers <cbowers@juniper.net>, Routing WG <rtgwg@ietf.org>
Subject: Re: [Rtg-dt-yang-arch] Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
Thread-Topic: [Rtg-dt-yang-arch] Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
Thread-Index: AQHS1HriMukYolvWj0qJjqW/bAhXHqIizCIAgAAfhwCAADgCAA==
Date: Tue, 13 Jun 2017 16:58:48 +0000
Message-ID: <D5659052.B2F06%acee@cisco.com>
References: <823c6e8a-9544-5544-8a99-d05c0ffc7017@cesnet.cz> <D54B2AD5.B085A%acee@cisco.com> <6fc7d6b3-bf13-6861-01d3-c0ed52532629@cesnet.cz> <D564AC33.B2C6F%acee@cisco.com> <AB43025D-7A16-4084-A597-1E35B10D7A72@gmail.com> <EAFB61D8-072F-4157-B6B6-F0DDDC42EE28@gmail.com>
In-Reply-To: <EAFB61D8-072F-4157-B6B6-F0DDDC42EE28@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.196]
Content-Type: text/plain; charset="utf-8"
Content-ID: <8A0883EB88AE584181EFC1E183C089F4@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/Azrt1l8t9FHKK9ZGZM4nFTpULVw>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jun 2017 16:58:53 -0000
Hi Jeff, Then -05 version fixed most of the nits. I just posted (before the WG Chairs chat) the 06 version which addressed a couple residual nits. I did not change 224.0.0.0 - 239.255.255.255 to avoid the non-example IPv4 address warning or move the 2 IANA directory references from Normative to Informative to get around the “Possible down reference” comments. I view these as noise. Thanks, Acee On 6/13/17, 5:38 AM, "Jeff Tantsura" <jefftant.ietf@gmail.com> wrote: >Acee, > >Please fix nits. > >Cheers, >Jeff > > >On 6/13/17, 00:45, "Rtg-dt-yang-arch on behalf of Jeff Tantsura" ><rtg-dt-yang-arch-bounces@ietf.org on behalf of jefftant@gmail.com> wrote: > > Hi Acee, > > Thanks, will do. > > Regards, > Jeff > > > On Jun 12, 2017, at 17:39, Acee Lindem (acee) <acee@cisco.com> >wrote: > > > > Jeff, Chris, > > > > The authors believe we are ready for a WG last call. > > > > Thanks, > > Acee > > > >> On 6/12/17, 2:32 AM, "Radek Krejčí" <rkrejci@cesnet.cz> wrote: > >> > >> Hi Acee, > >> > >> sorry for the delay. I've checked the changes and the document as >well as > >> both the modules seem fine to me now. > >> > >> Regards, > >> Radek > >> > >> > >> Dne 24.5.2017 v 18:23 Acee Lindem (acee) napsal(a): > >>> Hi Radek, > >>> > >>> I believe I have addressed your YANG Doctor comments in the -05 >version > >>> of > >>> the draft. I used the template in RFC6087Bis, Appendix C which >resulted > >>> in > >>> some reorganization of ietf-routing-types. > >>> > >>> Thanks, > >>> Acee > >>> > >>>> On 5/24/17, 6:45 AM, "Radek Krejčí" <rkrejci@cesnet.cz> wrote: > >>>> > >>>> Reviewer: Radek Krejčí > >>>> Review result: Ready with Nits > >>>> > >>>> I have reviewed changes made to draft-ietf-rtgwg-routing-types >between > >>>> revision 02 and 04 (04 was published just a week after 03). The >main > >>>> change is splitting the module into 2 modules: >ietf-routing-types and > >>>> iana-routing-types. > >>>> > >>>> iana-routing-types: > >>>> - since it is IANA-maintained module, IANA should be the >'organization' > >>>> and also the 'contact' value should be changed accordingly (see > >>>> iana-if-type) > >>>> > >>>> ietf-routing-types: > >>>> - please follow the contact template available in RFC 6087 >Appendix B > >>>> (or > >>>> RFC6087bis, Appendix C) > >>>> > >>>> draft text: > >>>> - if iana-routing-types is supposed to be IANA-maintained >module, isn't > >>>> IANA also supposed to be XML registrant contact (IANA >Considerations > >>>> section)? > >>>> - my fault from previous review - since the module imports > >>>> ietf-yang-types, it MUST contain reference to its RFC, which is >RFC > >>>> 6991 > >>>> (not RFC 6021 as I wrote in my review). So move RFC 6991 >reference from > >>>> Informative references section into Normative references where >it will > >>>> replace reference to RFC 6021. > >>>> > >>>> Radek > >> > > > > _______________________________________________ > Rtg-dt-yang-arch mailing list > Rtg-dt-yang-arch@ietf.org > https://www.ietf.org/mailman/listinfo/rtg-dt-yang-arch > > >
- Yangdoctors early review of draft-ietf-rtgwg-rout… Radek Krejčí
- Re: Yangdoctors early review of draft-ietf-rtgwg-… Acee Lindem (acee)
- Re: Yangdoctors early review of draft-ietf-rtgwg-… Radek Krejčí
- FW: Yangdoctors early review of draft-ietf-rtgwg-… Acee Lindem (acee)
- Re: Yangdoctors early review of draft-ietf-rtgwg-… Jeff Tantsura
- Re: [Rtg-dt-yang-arch] Yangdoctors early review o… Jeff Tantsura
- Re: [Rtg-dt-yang-arch] Yangdoctors early review o… Acee Lindem (acee)