Re: Lars Eggert's No Objection on draft-ietf-rtgwg-yang-rib-extend-20: (with COMMENT)

Acee Lindem <acee.ietf@gmail.com> Thu, 25 May 2023 14:22 UTC

Return-Path: <acee.ietf@gmail.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86204C13AE20; Thu, 25 May 2023 07:22:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2IVmPlr6VDVO; Thu, 25 May 2023 07:22:17 -0700 (PDT)
Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 855AAC151554; Thu, 25 May 2023 07:22:17 -0700 (PDT)
Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-3f4eb166122so4980541cf.3; Thu, 25 May 2023 07:22:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685024536; x=1687616536; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vLmHCzc9daEAqiYwedmEvuxqg+DKnCwhNxKgSlsvEpU=; b=RBIdg+S64KkQLYmXqNA5tUcLGoYvZQ1163JAjxk35xgTQd6Kx+mLu7U8WvRHyssHZv ozU4LyFkfLSoQPG5fe5aWVnxA0e71LmJjwfR1TF16fQcxTual76ZQfUOb7Vo5sEqj0eG oia0YqCKehcRsYIaT5vAJJxf3/PGVCtQvDSTcm0CoochYenI+sBThwwJcBg1rvoAnV/8 QVbfw1g01LOy2csSsauCqnYBnuLvoHHabA4ENWLT6oszjvJIVA5GQ7/myHSb7j9InTkP IMTXNvX+uWvSRX54J+wYcyTkTUCmBKdQYHs/jLHoScfGmzei5ySd2wjTWR+rFIpe5j9l p1bA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685024536; x=1687616536; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vLmHCzc9daEAqiYwedmEvuxqg+DKnCwhNxKgSlsvEpU=; b=PNBBejfQR1cJ8kavQsBMGZCn3X6BeU6TYKdciP/ly0O7fO0VJVY0GxD6IntCyOeQrQ qd1w5BM3A349NE2J1zec1q5dfeEmqHqLfAFrJuYbMdZeIzhI3sXAIy7gekYVi6o7mLw9 hJ96u8yVOmnFpI4SVhn8XFiKZCv9o4j5c8ifvVAKeCqQ+edWAqA1oYXOobNh5bckX7Xe ONFzrGq3XbEjjU7mIT1WgD5GBvBTMwaZCFhjbniuIyn/Gj7ikwjBGeD0mb6tRaCN+vO5 MqbDeiiDqi/MK3wIKUOOwbvH1BplWK9p3u1MOThZAk+t5ziGHzBeCm6AACtVk3Y2MkpL JflQ==
X-Gm-Message-State: AC+VfDyA5AKZCtLn45Nx+GDR3+oWgWTUnkDZUX4lwTatjfzSxftUFPNX gd2R0dB3+pr0+9m4TBAGslxkGrx1ihg=
X-Google-Smtp-Source: ACHHUZ7Mf5+yjUsenqBb9E1pvWOGOafnKU7jgzT0XyKQkl5TChhXqH4vKqRf2ITQr2fMxcwGz3lqgQ==
X-Received: by 2002:a05:6214:20a6:b0:61b:75e0:6a19 with SMTP id 6-20020a05621420a600b0061b75e06a19mr1064258qvd.14.1685024536549; Thu, 25 May 2023 07:22:16 -0700 (PDT)
Received: from smtpclient.apple ([136.56.20.4]) by smtp.gmail.com with ESMTPSA id ez9-20020ad45909000000b0061f7cf8207asm425323qvb.133.2023.05.25.07.22.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 May 2023 07:22:16 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
Subject: Re: Lars Eggert's No Objection on draft-ietf-rtgwg-yang-rib-extend-20: (with COMMENT)
From: Acee Lindem <acee.ietf@gmail.com>
In-Reply-To: <168499555819.10562.12221379348466463004@ietfa.amsl.com>
Date: Thu, 25 May 2023 10:22:05 -0400
Cc: The IESG <iesg@ietf.org>, draft-ietf-rtgwg-yang-rib-extend@ietf.org, rtgwg-chairs@ietf.org, rtgwg@ietf.org, jefftant.ietf@gmail.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <AF9AB877-CA83-4E79-8B87-FBF1DAFB3709@gmail.com>
References: <168499555819.10562.12221379348466463004@ietfa.amsl.com>
To: Lars Eggert <lars@eggert.org>
X-Mailer: Apple Mail (2.3731.500.231)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/22HWVgIbC0UY_RyiHOU2PbgGJS4>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2023 14:22:21 -0000

Hi Lars,

Thanks for you comments. 

> On May 25, 2023, at 2:19 AM, Lars Eggert via Datatracker <noreply@ietf.org> wrote:
> 
> Lars Eggert has entered the following ballot position for
> draft-ietf-rtgwg-yang-rib-extend-20: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
> for more information about how to handle DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-rtgwg-yang-rib-extend/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> # GEN AD review of draft-ietf-rtgwg-yang-rib-extend-18
> 
> CC @larseggert
> 
> ## Comments
> 
> ### Boilerplate
> 
> This document does not use RFC2119 keywords, but contains the RFC8174
> boilerplate.

I’ve removed these in the -21 version. 


> 
> ### Inclusive language
> 
> Found terminology that should be reviewed for inclusivity; see
> https://www.rfc-editor.org/part2/#inclusive_language for background and more
> guidance:
> 
> * Term `master`; alternatives might be `active`, `central`, `initiator`,
>   `leader`, `main`, `orchestrator`, `parent`, `primary`, `server`

Good catch - the examples including “ipv4-master” and “ipv6-master” were migrated from RFC 8349 and enhanced with the new YANG data nodes. I’ve changed these to “ipv4-primary” and “ipv6-master” in the -21 version. 

Thanks,
Acee



> 
> ## Notes
> 
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
> 
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments
> [IRT]: https://github.com/larseggert/ietf-reviewtool
> 
> 
>