Re: Yangdoctors last call review of draft-ietf-rtgwg-yang-rib-extend-17

[Acee Lindem <[e-mail]>]

Hi Martin, 

Thanks for your review. I’ve addressed your comments in the -18 version. 

Thanks,
Acee

> On May 4, 2023, at 3:53 AM, Martin Björklund via Datatracker <[e-mail]> wrote:
> 
> Reviewer: Martin Björklund
> Review result: Ready
> 
> This is the third YANG doctor review of this document (I have reviewed -17).
> All comments from my previous review have been addressed.
> 
> So, I have only two very minor comments.
> 
> o  The "description" of the YANG module now reads:
> 
>     This document defines a YANG data model which extends
>     the RIBs defined in ietf-routing YANG module with more
>     route attributes.
> 
>   In the module itself, we usually write "This YANG module ...".  So perhaps simply
> 
>     This YANG module extends the RIBs defined in the 'ietf-routing' YANG module
>     with more route attributes.
> 
> o  Use single quotes to refer to schema nodes.
> 
>   The "description" of the leaf "routes" has:
> 
>     "Total routes for protocol in the RIB.";
> 
>   This looks odd, the grammar is not correct.  Then I realized that the word "protocol" refers
>   to the leaf "protocol".  So I suggest:
> 
>      "Total routes for 'protocol' in the RIB.";
> 
>   The same comment applies to some other descriptions as well.
> 
> 
> 
> /martin
> 
> 
>