Yangdoctors last call review of draft-ietf-rtgwg-yang-rib-extend-17
Martin Björklund via Datatracker <noreply@ietf.org> Thu, 04 May 2023 07:53 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: rtgwg@ietf.org
Delivered-To: rtgwg@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 93C3CC153CBB; Thu, 4 May 2023 00:53:32 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Martin Björklund via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: draft-ietf-rtgwg-yang-rib-extend.all@ietf.org, last-call@ietf.org, rtgwg@ietf.org
Subject: Yangdoctors last call review of draft-ietf-rtgwg-yang-rib-extend-17
X-Test-IDTracker: no
X-IETF-IDTracker: 10.1.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168318681259.49785.18220095950036916676@ietfa.amsl.com>
Reply-To: Martin Björklund <mbj+ietf@4668.se>
Date: Thu, 04 May 2023 00:53:32 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/gcsskoL_lcR_2F7VqeAc-A9-wmM>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 May 2023 07:53:32 -0000
Reviewer: Martin Björklund Review result: Ready This is the third YANG doctor review of this document (I have reviewed -17). All comments from my previous review have been addressed. So, I have only two very minor comments. o The "description" of the YANG module now reads: This document defines a YANG data model which extends the RIBs defined in ietf-routing YANG module with more route attributes. In the module itself, we usually write "This YANG module ...". So perhaps simply This YANG module extends the RIBs defined in the 'ietf-routing' YANG module with more route attributes. o Use single quotes to refer to schema nodes. The "description" of the leaf "routes" has: "Total routes for protocol in the RIB."; This looks odd, the grammar is not correct. Then I realized that the word "protocol" refers to the leaf "protocol". So I suggest: "Total routes for 'protocol' in the RIB."; The same comment applies to some other descriptions as well. /martin
- Yangdoctors last call review of draft-ietf-rtgwg-… Martin Björklund via Datatracker
- Re: Yangdoctors last call review of draft-ietf-rt… Acee Lindem