IETF Logo Mail Archive

Yangdoctors early review of draft-ietf-rtgwg-routing-types-04

Radek Krejčí <rkrejci@cesnet.cz> Wed, 24 May 2017 10:45 UTC

Return-Path: <rkrejci@cesnet.cz>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 20CFD127286; Wed, 24 May 2017 03:45:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.601
X-Spam-Level:
X-Spam-Status: No, score=-1.601 tagged_above=-999 required=5 tests=[BAYES_50=0.8, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cesnet.cz
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7qxGK9DPWNWI; Wed, 24 May 2017 03:45:30 -0700 (PDT)
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 341731294A2; Wed, 24 May 2017 03:45:29 -0700 (PDT)
Received: from [IPv6:2001:67c:1220:80c:921b:eff:fe59:4360] (unknown [IPv6:2001:67c:1220:80c:921b:eff:fe59:4360]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id A309320016; Wed, 24 May 2017 12:45:27 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2; t=1495622727; bh=UPEAVj0N6iueENyCOB9OO4ed3kw2An4ALLFlj99mKOk=; h=From:Subject:To:Cc:Date; b=Th3QyS3QxPt4yf1L4uNfoWNCODypkdqgbQC/Ob7EtBLK8Kud2GtPdDX6yS2npgRUH nNYEL6jtjY4kYbrVuS+IQSBfDVNQpaSxPypGHp7mjP11w6sbKNW5QnIzfjxDgM8zhZ HroPnYwH4b85dDGbjLFJJ1P93nTxVlEOq+pv9zN8=
From: Radek Krejčí <rkrejci@cesnet.cz>
Subject: Yangdoctors early review of draft-ietf-rtgwg-routing-types-04
To: yang-doctors@ietf.org
Cc: draft-ietf-rtgwg-routing-types.all@ietf.org, rtgwg@ietf.org
Message-ID: <823c6e8a-9544-5544-8a99-d05c0ffc7017@cesnet.cz>
Date: Wed, 24 May 2017 12:45:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/B7ybQ3YiJNEOGZyliCRzTPJZpe4>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 May 2017 10:45:32 -0000

Reviewer: Radek Krejčí
Review result: Ready with Nits

I have reviewed changes made to draft-ietf-rtgwg-routing-types between revision 02 and 04 (04 was published just a week after 03). The main change is splitting the module into 2 modules: ietf-routing-types and iana-routing-types.

iana-routing-types:
- since it is IANA-maintained module, IANA should be the 'organization' and also the 'contact' value should be changed accordingly (see iana-if-type)

ietf-routing-types:
- please follow the contact template available in RFC 6087 Appendix B (or RFC6087bis, Appendix C)

draft text:
- if iana-routing-types is supposed to be IANA-maintained module, isn't IANA also supposed to be XML registrant contact (IANA Considerations section)? 
- my fault from previous review - since the module imports ietf-yang-types, it MUST contain reference to its RFC, which is RFC 6991 (not RFC 6021 as I wrote in my review). So move RFC 6991 reference from Informative references section into Normative references where it will replace reference to RFC 6021.

Radek

v2.23.0 | Report a Bug | By Email