RE: QA review of draft-ietf-rtgwg-device-model-02

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Tue, 02 May 2017 22:29 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 289FD129C70; Tue, 2 May 2017 15:29:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pNIvthq-hIO9; Tue, 2 May 2017 15:29:12 -0700 (PDT)
Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F21D129422; Tue, 2 May 2017 15:27:05 -0700 (PDT)
X-AuditID: c1b4fb25-0a3ff70000006049-19-590907b6b0c7
Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 31.94.24649.6B709095; Wed, 3 May 2017 00:27:04 +0200 (CEST)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 3 May 2017 00:27:01 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.onmicrosoft.com; s=selector1-ericsson-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rNud0zBftZ4mgUnbwmAqyB0yBLw2J4g0A7QzHk385T0=; b=NSvg1Uu1aX2rU29fGb+MEUpa33L+SvUZxuo3vhfN2WtpZu0GBvJgMFauVdtbemt1l1FF+YNW92k9aSALWeSxVxZXz+kIG0zXppZPD7519T2Yr7+33ko+lH+6/2I0WV16Xpn6NbKlRTOJlVtHxkluW1Kx3vQLTH6hS5hsMxyhp9M=
Received: from AM2PR07MB0994.eurprd07.prod.outlook.com (10.162.37.152) by AM2PR07MB0994.eurprd07.prod.outlook.com (10.162.37.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.1; Tue, 2 May 2017 22:27:00 +0000
Received: from AM2PR07MB0994.eurprd07.prod.outlook.com ([fe80::9d48:60f4:c92:7443]) by AM2PR07MB0994.eurprd07.prod.outlook.com ([fe80::9d48:60f4:c92:7443%17]) with mapi id 15.01.1075.010; Tue, 2 May 2017 22:27:00 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: "draft-ietf-rtgwg-device-model-02@tools.ietf.org" <draft-ietf-rtgwg-device-model-02@tools.ietf.org>, "rtgwg-chairs@ietf.org" <rtgwg-chairs@ietf.org>
CC: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>, "Jonathan Hardwick (Jonathan.Hardwick@metaswitch.com)" <Jonathan.Hardwick@metaswitch.com>, "Yemin (Amy)" <amy.yemin@huawei.com>
Subject: RE: QA review of draft-ietf-rtgwg-device-model-02
Thread-Topic: QA review of draft-ietf-rtgwg-device-model-02
Thread-Index: AdLDWi/ONOprp8BmQpG9Qvq24gy0eQAOLLxA
Date: Tue, 02 May 2017 22:27:00 +0000
Message-ID: <AM2PR07MB09946B270FFB0CFC88C2B4FFF0170@AM2PR07MB0994.eurprd07.prod.outlook.com>
References: <AM2PR07MB09944F0B3AA9F4B0A3BFC65CF0170@AM2PR07MB0994.eurprd07.prod.outlook.com>
In-Reply-To: <AM2PR07MB09944F0B3AA9F4B0A3BFC65CF0170@AM2PR07MB0994.eurprd07.prod.outlook.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: tools.ietf.org; dkim=none (message not signed) header.d=none;tools.ietf.org; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [108.58.107.174]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM2PR07MB0994; 7:yzXceNyFbOtEUkpT+jokXj/7+AzFnjOjuCJbsghfH9zDfL3/l/X6yoPi8Ye4XZOid54ECE3UY7IjdVxz6HuD1m11p+B4G2g5MOjY81EuPgaR+Z6yGWojQoWJ6y2hvE8vU+UWZDdlAfAKC+49s2y83wnefP657S6fqIow92UaNj1j97GzRUzBesXbNcAA850aprewfk5LmFXMKOpqvvCIcHfo5HRYIUaY6ZXm+hEh2BdMK5SSYFo9Pw5mkKyExV4TvXjbRtU4vNXl5Qamd5TmHA8RYOwInJWdq0H2blhXhiHejl7KAvTVXmd6fTLNgkSYdRjoeTaRHqRCGdffPMrsEA==
x-ms-office365-filtering-correlation-id: 6f4db70a-4eb2-4d85-59a4-08d491aa5a1e
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:AM2PR07MB0994;
x-microsoft-antispam-prvs: <AM2PR07MB0994CA244712DD3BE741276BF0170@AM2PR07MB0994.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(50582790962513)(21748063052155);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(6072148); SRVR:AM2PR07MB0994; BCL:0; PCL:0; RULEID:; SRVR:AM2PR07MB0994;
x-forefront-prvs: 02951C14DC
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39410400002)(39860400002)(39840400002)(39850400002)(229853002)(8936002)(54896002)(5250100002)(189998001)(2900100001)(6506006)(230783001)(99286003)(9686003)(6306002)(4326008)(53546009)(6436002)(25786009)(53936002)(86362001)(38730400002)(66066001)(54356999)(76176999)(478600001)(3280700002)(33656002)(3660700001)(2906002)(2501003)(8676002)(7696004)(3846002)(102836003)(7736002)(790700001)(74316002)(6116002)(81166006)(50986999)(5660300001)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR07MB0994; H:AM2PR07MB0994.eurprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_AM2PR07MB09946B270FFB0CFC88C2B4FFF0170AM2PR07MB0994eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2017 22:27:00.7238 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR07MB0994
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHfc85285Gg9NUfNQEWflBRStNGVmZH4TRBYIuui7U0pOK88LO GipFBgnmpawUL6y8ZqZJK50Jiuac1dFKTTPLBV1W3ulKWorl9hr47fc8///7f5/34aVJGS/w oBOSdaw2Wa2RCyVUafSD3QGtIrFq0+AIUjRlG4WK3PpWQpGX76/gDfOkorOxmlQMzCyQO4XK C5ZZgbKm5jeh7Hl9nVT+HPoh3EcdlmyLZTUJela7cccJSXznxKgoldem3f5aKMxE3TE5SEwD swUGr40ROUhCyxgLgtnqZhEuHiNofz6O7C6KySehbTgcC0UEfLA2rhx5h6Cn17bsomkhsxVs 5j32vgtjQGA0lQjsBclMIJgZ/CyyRzkvm0zfrjhiXZgwMFuyScxB0DfXQuDrNsB4dYPQzlLm KJSNVDhYtszt9wyUncXMMZh6UurIQYwXFLRVOZhk3OCNrZzAj2Ogpr2fxOwKkx+XHAMhphRB V/4UhQU5WK3TK+wFL8pzkd0ETB4Ji3VPV5L2QtVSE4WFywhMxj8CLCRCX/FLhHkXNA8XijB/ J6C41hPzOugvmBfgw38pmCsYXdmFB7wdvogKkG/ZqtExp0Bvdr+ozLGCtcCX2ijcD4TRokIh Zn+orZwmMQdAyZKZWt2vQKJ65Mqx3MmkuKDgQFabEMNxKcmByazuPlr+YF3NCz6taGgmwowY GsnXSL15WiUTqPVcepIZAU3KXaRTSKySSWPV6RmsNuW49rSG5czIk6bkbtKIjoFoGROn1rGJ LJvKav+rBC32yEROoWIkjhQduqTrTvPtogtnf1Xdct7//lS6/sCjeJ0nb1OqQzz6hsyDJoPm SyqvsrS63q0KqlyfFtU5aYm56R0d4hN8xCmk5Jyhe3b+TH3os4NRmvCOAMpEpGdvn160+mY9 zOL9+sKNGS36SWvd2YN3XjVIr47dcA8JG/gUed5dTnHx6s1+pJZT/wPCXsKoXAMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/HFw2ZBVvJjQuczA0amFPERkk1e4>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 May 2017 22:29:15 -0000

Resending with the right exploder.

BR
Daniele

From: Daniele Ceccarelli
Sent: mercoledì 3 maggio 2017 00:22
To: draft-ietf-rtgwg-device-model-02@ietf.org; rtgwg-chairs@ietf.org
Cc: <rtg-ads@ietf.org> (rtg-ads@ietf.org) <rtg-ads@ietf.org>; rtgwg@ietf.org; Jonathan Hardwick (Jonathan.Hardwick@metaswitch.com) <Jonathan.Hardwick@metaswitch.com>; Yemin (Amy) <amy.yemin@huawei.com>
Subject: QA review of draft-ietf-rtgwg-device-model-02

Hello,

i've been selected as the QA reviewer for draft-ietf-rtgwg-device-model-02.

I believe the draft is well written and quite easy to understand, I just have some minor suggestion that might be help improving the readability (mostly for non subject experts).


-          Title: the title is not very clear, while the abstract explains very well in the first sentence what the goal of the draft is, what about changing it into: "A logical organization for network device YANG models" ?

-          Introduction: You are referencing an individual draft. This could be a block for the draft, but most of all does it make sense to have two separate drafts (in two different WGs), one to say the value of organizing YANG models  and the other one defining a logical organization for the models? (maybe too late for such change)

-          Introduction: this sentence is a bit confusing:

"  This document refers to two new modules that are expected to be  implemented.  These models are defined to support the configuration  and operation of network-devices that allow for the partitioning of  resources from both, or either, management and networking   perspectives.  Two forms of resource partitioning are referenced:"
                Maybe a modules/models mismatch? You start saying that the doc refers to two MODULES, then you say that MODELS are defined and the list two FORMS OF RESOURCE PARTITIONING.

-          Intro: "    Should structural-mount/YSDL not be available, the more explicit tree structure presented in earlier versions of this document will need to  be utilized." If it was described in previous versions of the document it is no longer available, or ?

-          Scope: as I got it while reading and as it is confirmed in the draft, the scope is "limited"  to physical and virtual switches and routers and not devices operating at the lower layers. Since you say "we consider network devices that support protocols  and functions defined within the IETF Routing Area" I would expect it to cover also lower layer devices.

-          Section 2: Section 2 and its subsection are very clear and explain well the concepts but it is not clear where the list comes from. It partially overlaps with the "overall structure" example above but at least having all of them in the overall structure plus some others (provided as example and not analyzed in the details with dedicated subsection ) would help.

BR
Daniele