Re: Mail regarding draft-litkowski-rtgwg-spf-uloop-pb-statement

Mike Shand <imc.shand@gmail.com> Thu, 07 May 2015 10:14 UTC

Return-Path: <imc.shand@gmail.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 904F01A01C6 for <rtgwg@ietfa.amsl.com>; Thu, 7 May 2015 03:14:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a33pVzth1qb0 for <rtgwg@ietfa.amsl.com>; Thu, 7 May 2015 03:14:55 -0700 (PDT)
Received: from mail-wg0-x229.google.com (mail-wg0-x229.google.com [IPv6:2a00:1450:400c:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A80BA1A0141 for <rtgwg@ietf.org>; Thu, 7 May 2015 03:14:54 -0700 (PDT)
Received: by wgiu9 with SMTP id u9so38470817wgi.3 for <rtgwg@ietf.org>; Thu, 07 May 2015 03:14:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=r+Zg94RvrtByZIJqxTeqYxS8Nfe2xP9hOispgqc/Jtw=; b=baD8jI7VSoNDZWbgcU6qswzhTtcXLr85N7OjmFfOMNrG3wr1Ghizu28X6Nx6u7Rat2 aolGFgro0+AnGEjTqpYpx39gYP0qMGRgisoRrtCRZPX9Tq7rpZ4g0I7DOTt3W/j1V+Em r6pHrO1VVoYlxJznCGaeIAohDbgNh1W2fWIGY2kyS4Ic+osEoD0suHu0sSboHaGx771q d6Q/qPKePljqGKJuQrm2zzHbtnIQTV580QAAOhsFeFptvXAqvwvn/BNjM5X6ztDFos9v QobMiMLDCwqsTu5CIiSaZpt/FR7CBIIQYBr/oVkw6F87t31tlFi6l0dibMIcs3Mj4Vst kpdQ==
X-Received: by 10.180.106.226 with SMTP id gx2mr3515933wib.48.1430993693326; Thu, 07 May 2015 03:14:53 -0700 (PDT)
Received: from [192.168.1.67] (host86-173-151-11.range86-173.btcentralplus.com. [86.173.151.11]) by mx.google.com with ESMTPSA id bm9sm2623419wjc.21.2015.05.07.03.14.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2015 03:14:52 -0700 (PDT)
Message-ID: <554B3B19.3000700@gmail.com>
Date: Thu, 07 May 2015 11:14:49 +0100
From: Mike Shand <imc.shand@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: draft-litkowski-rtgwg-spf-uloop-pb-statement@tools.ietf.org
Subject: Re: Mail regarding draft-litkowski-rtgwg-spf-uloop-pb-statement
References: <554B3A72.4000807@mshand.org.uk>
In-Reply-To: <554B3A72.4000807@mshand.org.uk>
Content-Type: multipart/alternative; boundary="------------070807020408030102010005"
Archived-At: <http://mailarchive.ietf.org/arch/msg/rtgwg/K5fXbTfbTWhBXAZArNRmG2s0IcA>
Cc: rtgwg@ietf.org
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 May 2015 10:14:57 -0000

I have been assigned as Routing Directorate QA reviewer for this document.

The following web page contains a briefing on the QA process.

​https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDirDocQa


The document provides a useful summary of the issues leading to 
micro-loop formation, especially in mixed vendor networks and provides 
examples of the possibilities to adversely affect the the micro-loop 
behaviour by inconsistent choices of parameters and algorithms among the 
routers in the network.

I confess that I find the timing diagrams quite hard to follow. One of 
the penalties of being constrained by the need to use ASCII art. But I 
wonder if something could be done to make them a little easier to follow 
without losing the essential information?

There are some very simple mitigation techniques, such as delaying the 
locally triggered  SPF/FIB installation more than a remotely triggered 
one, which it may be helpful to mention.

The document goes on to propose future work to standardise some behaviours.

Clearly this work is at an early stage and the trade-offs between 
standardisation and allowing vendors freedom to innovate for the benefit 
of their customers must be carefully considered.

The document seems like a good starting point for this work.


In reading the document I spotted a few items which it would be as well 
to address.

General:

1. micro-loop or microloop. The terminology is used inconsistently. RFC 
5715 uses micro-loop
2. There are numerous instances of awkward usage of english. It would be 
helpful to address these at some stage.

Nits:

3. "   We will call SPF delay, the delay timer that exists in most
    implementations that makes codes to wait before running SPF
    computation after a SPF trigger is received."

The phrase "makes codes to wait" is somewhat contrived. How about "that 
specifies the required delay"?

4. "   Routers have more and more powerful controlplane and dataplane that
    reduce the Control plane to Forwarding plane overhead during the
    convergence process.  Even if FIB update is still reasonably the
    highest contributor in the convergence time for large network, its
    duration is reducing more and more and may become comparable to
    protocol timers.  This is particular true in small and medium
    networks."

I don't understand what is meant by "may become comparable to protocol 
timers"? Are you suggesting that the FIB update latency WAS greater than 
the protocol timers, but has now been reduced to a comparable value?

The reference to small and medium networks is also confusing, since in 
my experience it is actually the small and medium networks which are 
subject to the LARGEST FIB update times as a result of the deployment of 
under powered hardware.


5. "   In multi vendor networks, using different implementations of a link
    state protocol may favor micro-loops creation during convergence time
    due to deprecancies of timers."

deprecancies? Do you mean discrepancies?

6. "4.2 Exponential Backoff"

"   o  First delay : amount of time to wait before running SPF. This
       delay is used on when SPF is in fast mode."

I assume "is used only when SPF" is what you mean.

and similarly in the next bullet



Mike