IETF Logo Mail Archive

Re: Opsdir telechat review of draft-ietf-rtgwg-yang-rib-extend-21

Acee Lindem <acee.ietf@gmail.com> Tue, 06 June 2023 18:26 UTC

Return-Path: <acee.ietf@gmail.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 168F7C151995; Tue, 6 Jun 2023 11:26:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.098
X-Spam-Level:
X-Spam-Status: No, score=-7.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E01wRsa3MH5h; Tue, 6 Jun 2023 11:26:31 -0700 (PDT)
Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A10B0C151990; Tue, 6 Jun 2023 11:26:31 -0700 (PDT)
Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-3f6a494810fso56282821cf.1; Tue, 06 Jun 2023 11:26:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686075990; x=1688667990; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lIJHpcLzu1htENRqcXPCypAI1lgzFdGe+VmLRMUvZqg=; b=rSjVv2XPflyO+chcj7oMfIihYXeiYZG3Mf6zHI8cpIm/cCIH6WwPmYP2LLT8mNxrhY fPmyH392w4tENFysnI8jS3DNHpkWl35dBRANDf5Acp6VHicwJ17I3Z56mR7NxMIT9gs2 tp/hBcyhs6HkOeY8/6OPkqA6ZZN778VYQI3Kqe0bx20MFVEGy1G5P66D0woR1zwOYRw0 dESSYGHGRdOuT54Evvq6V8udLAeke1M4cRtBoE4UNF3QuV23JVyQdKr90toxm0X+BFoR mGZT9RYztoZzo9uqDh1+RAHeHpnb5teA58aFGToSVltJy8GFK2y/Tr2ijYkk/twkDwid oeyQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686075990; x=1688667990; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lIJHpcLzu1htENRqcXPCypAI1lgzFdGe+VmLRMUvZqg=; b=IsADRTZV8H0b3Iw4BK9UEVVxsHWFaU/A+DyiJDGOw+3Ij+Y5oE5PAr8TdnNn/2f9u3 tp8MvGuasywSq1+laIZKAL+qUBh0mZjtpXNCT2fswFO/uWiXG2m8n/lZcwcaTnA8rJwu 05sPmz5MmQPSBjXAHlyeX6Ksq00btAi21Y2PPn6yPUHfD9o+uYdYEM8Aa+7sXKhORNZ8 4M69IoudtColbuXmmXcinzuEPZalnZTalyOA4ZPjHWufPyv3zBtBOnaKICupOnQmUHA6 MwRWKDV00ElNdrCMFweBVBJn781gu0tqaszywL5DfrNnV1Wg6nVGRVQDOqesA5eTgpk1 ROVg==
X-Gm-Message-State: AC+VfDyaiXVFEbPBDa4rH3sSb0/cW+vbHrSxFYiWAUOYpQSRNQMxBHUM 2TMsmkxI3H6KTXaIgX8laxc=
X-Google-Smtp-Source: ACHHUZ6sFh0R4BvsEvrDEeHFp4r8v98vBd4aGyYSF0Ny/Bzmt32jjFFHideUpDpjR5ifYXoet4TgCg==
X-Received: by 2002:ac8:7f14:0:b0:3f3:96a3:c753 with SMTP id f20-20020ac87f14000000b003f396a3c753mr790903qtk.11.1686075990643; Tue, 06 Jun 2023 11:26:30 -0700 (PDT)
Received: from smtpclient.apple ([136.56.20.4]) by smtp.gmail.com with ESMTPSA id o6-20020ac872c6000000b003f6bdc221e6sm5760437qtp.53.2023.06.06.11.26.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jun 2023 11:26:30 -0700 (PDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Subject: Re: Opsdir telechat review of draft-ietf-rtgwg-yang-rib-extend-21
From: Acee Lindem <acee.ietf@gmail.com>
In-Reply-To: <168605862863.33015.15725340062807869584@ietfa.amsl.com>
Date: Tue, 06 Jun 2023 14:26:19 -0400
Cc: ops-dir@ietf.org, draft-ietf-rtgwg-yang-rib-extend.all@ietf.org, last-call@ietf.org, rtgwg@ietf.org
Content-Transfer-Encoding: 7bit
Message-Id: <30766A1A-E876-4517-923F-99209A7AEA4C@gmail.com>
References: <168605862863.33015.15725340062807869584@ietfa.amsl.com>
To: Bo Wu <lana.wubo@huawei.com>
X-Mailer: Apple Mail (2.3731.600.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/aunnmWYODJGlXLT14g1z3d5f_Y4>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2023 18:26:32 -0000

Hi Bo, 


> On Jun 6, 2023, at 09:37, Bo Wu via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Bo Wu
> Review result: Has Nits
> 
> Hi,
> 
> I have reviewed the document and it is clear written.
> 
> Here are two nits commments:
> 
> In Section 5. RIB Extension YANG Model
> 1)
> OLD:
>    description
>       "This YANG module extends the RIB defined in the ietf-routing
>        YANG module with additionalroute attributes.
> NEW:
>    description
>       "This YANG module extends the RIB defined in the ietf-routing
>        YANG module with additional route attributes.

Fixed. 

> 
> 2) grouping next-hop is defined but not used, is this intentional?

I think this is a remnant of a previous iteration. Removed. 

These are reflected in the -22 version. 

Thanks,
Acee


> 
> Thanks,
> Bo Wu
> 
> 
> 
> 
>

v2.23.0 | Report a Bug | By Email