Opsdir telechat review of draft-ietf-rtgwg-yang-rib-extend-21

Bo Wu via Datatracker <noreply@ietf.org> Tue, 06 June 2023 13:37 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: rtgwg@ietf.org
Delivered-To: rtgwg@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E4EAC15199F; Tue, 6 Jun 2023 06:37:08 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Bo Wu via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: draft-ietf-rtgwg-yang-rib-extend.all@ietf.org, last-call@ietf.org, rtgwg@ietf.org
Subject: Opsdir telechat review of draft-ietf-rtgwg-yang-rib-extend-21
X-Test-IDTracker: no
X-IETF-IDTracker: 10.5.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168605862863.33015.15725340062807869584@ietfa.amsl.com>
Reply-To: Bo Wu <lana.wubo@huawei.com>
Date: Tue, 06 Jun 2023 06:37:08 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/ntZafkngVSNnV-nSK1KoNb_EgN4>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2023 13:37:08 -0000

Reviewer: Bo Wu
Review result: Has Nits

Hi,

I have reviewed the document and it is clear written.

Here are two nits commments:

In Section 5. RIB Extension YANG Model
1)
 OLD:
    description
       "This YANG module extends the RIB defined in the ietf-routing
        YANG module with additionalroute attributes.
NEW:
    description
       "This YANG module extends the RIB defined in the ietf-routing
        YANG module with additional route attributes.

2) grouping next-hop is defined but not used, is this intentional?

Thanks,
Bo Wu