RE: Routing directorate QA review of draft-ietf-rtgwg-yang-vrrp

Xufeng Liu <Xufeng_Liu@jabil.com> Thu, 04 May 2017 13:47 UTC

Return-Path: <Xufeng_Liu@jabil.com>
X-Original-To: rtgwg@ietfa.amsl.com
Delivered-To: rtgwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 01347129601 for <rtgwg@ietfa.amsl.com>; Thu, 4 May 2017 06:47:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.922
X-Spam-Level:
X-Spam-Status: No, score=-1.922 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=jabil.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hCy9fIHAjHJe for <rtgwg@ietfa.amsl.com>; Thu, 4 May 2017 06:47:40 -0700 (PDT)
Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0119.outbound.protection.outlook.com [104.47.42.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5A12912954D for <rtgwg@ietf.org>; Thu, 4 May 2017 06:47:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jabil.onmicrosoft.com; s=selector1-jabil-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ttB6ljbqd3fj5Voc2GNcpWpzrTB0Y6IHlryOST8XooA=; b=mfZieKo2O9Dzmv2y1BpXdicNtdHB53W/AvDXGZFktzQxEnQmHTH9X/5jf7U63VxoqO2mvb1s1oZQavPe6uEUsFGZNTfCKNT2V/aLLl2y8Ent3uz8yeQ407QmUCdLhWW/dPSHcqBntXxOz86pK2JjQKBrWcS2SRDWsCJJtz/1E/k=
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com (10.160.154.13) by BY2PR02MB1363.namprd02.prod.outlook.com (10.162.80.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Thu, 4 May 2017 13:47:38 +0000
Received: from BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) by BN3PR0201MB0867.namprd02.prod.outlook.com ([10.160.154.13]) with mapi id 15.01.1061.021; Thu, 4 May 2017 13:47:36 +0000
From: Xufeng Liu <Xufeng_Liu@jabil.com>
To: "t.petch" <ietfa@btconnect.com>, Henning Rogge <hrogge@gmail.com>
CC: Athanasios Kyparlis <Athanasios_Kyparlis@jabil.com>, "parikhr@vmware.com" <parikhr@vmware.com>, Routing WG <rtgwg@ietf.org>
Subject: RE: Routing directorate QA review of draft-ietf-rtgwg-yang-vrrp
Thread-Topic: Routing directorate QA review of draft-ietf-rtgwg-yang-vrrp
Thread-Index: AQHSvM5DkWzkWiy5OUyGyrzZT7T+E6HWF3bAgAAEdICAAYkXIIADoFyAgAVhdACAAkY31oABUfSA
Date: Thu, 04 May 2017 13:47:36 +0000
Message-ID: <BN3PR0201MB0867F04103F86E827A62694CF1EA0@BN3PR0201MB0867.namprd02.prod.outlook.com>
References: <BY2PR0201MB19108C572D4B977A53188CEE84330@BY2PR0201MB1910.namprd02.prod.outlook.com> <CAGnRvuraegGUtHE++VN2nMv7O1Li-GZ4Acb536PZHJvWrmE0ng@mail.gmail.com> <BN3PR0201MB0867B806559292BC571E76DBF11E0@BN3PR0201MB0867.namprd02.prod.outlook.com> <CAGnRvuppKKmgdVCMvOjxXF5MDxsEozzG-uWruAqCrAYcJg5eFQ@mail.gmail.com> <BN3PR0201MB08673C6095244722CDAFB26DF1110@BN3PR0201MB0867.namprd02.prod.outlook.com> <BN3PR0201MB0867C158109E11A94E820227F1130@BN3PR0201MB0867.namprd02.prod.outlook.com> <CAGnRvupOreTNMrCtx+9a9dmsqq0RZe5aFqGSOS_7Gvas7UjixA@mail.gmail.com> <017201d2c432$f3eefb60$4001a8c0@gateway.2wire.net>
In-Reply-To: <017201d2c432$f3eefb60$4001a8c0@gateway.2wire.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: btconnect.com; dkim=none (message not signed) header.d=none;btconnect.com; dmarc=none action=none header.from=jabil.com;
x-originating-ip: [98.191.72.170]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BY2PR02MB1363; 7:UmI3KJ+MooGW6gR/25uJO/3jIf4qnxu3m2bf5qqVDDHtWdoA9G4C3rdOwrjabvrndEQCE/SzGPlCc/DgHMCQ0ft7HatIb/+j1f6A8pCuJdkeoRdtmFGR1mH5/turYtV2Kl1UtwOo62Lhicg46TfdYONZfMhn1cyaw/dY2mn20X6HqGF1pXaVpdK5XjqgWC21B1oG1ZR3fNEx+zZpyVmFoi7QqelU1jezryyKwg1R9uEurukXPFIlG0E4fszlK+oNLC0sZe86issPbTnU6wX9tRQnt0VKTc32UMcsLP/6xSPT1oSX6vqRrWcOsi6ClOAplGaptqmneP9twd9rNbPv7w==
x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10019020)(6009001)(39450400003)(39860400002)(39400400002)(39850400002)(39410400002)(39840400002)(13464003)(377454003)(24454002)(66654002)(54094003)(4326008)(5660300001)(5890100001)(74316002)(6506006)(33656002)(77096006)(189998001)(39060400002)(230783001)(53936002)(93886004)(80792005)(8936002)(38730400002)(3660700001)(66066001)(305945005)(2950100002)(102836003)(561944003)(3846002)(7736002)(99286003)(54906002)(55016002)(6246003)(6306002)(6436002)(6116002)(2906002)(7696004)(86362001)(81166006)(50986999)(122556002)(53546009)(76176999)(9686003)(25786009)(508600001)(54356999)(229853002)(3280700002)(8666007)(2900100001)(8676002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR02MB1363; H:BN3PR0201MB0867.namprd02.prod.outlook.com; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en;
x-ms-office365-filtering-correlation-id: eab3b975-f1c9-4b0e-799e-08d492f41fd6
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:BY2PR02MB1363;
x-microsoft-antispam-prvs: <BY2PR02MB1363C03EF25FB5F205E96CA8F1EA0@BY2PR02MB1363.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(61668805478150)(178726229863574)(120809045254105)(50582790962513)(100405760836317)(21534305686606);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148); SRVR:BY2PR02MB1363; BCL:0; PCL:0; RULEID:; SRVR:BY2PR02MB1363;
x-forefront-prvs: 02973C87BC
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: jabil.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2017 13:47:36.7886 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bc876b21-f134-4c12-a265-8ed26b7f0f3b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB1363
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtgwg/mqN0OuHDTCnS_k7YY9k1esOsI8g>
X-BeenThere: rtgwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Routing Area Working Group <rtgwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtgwg/>
List-Post: <mailto:rtgwg@ietf.org>
List-Help: <mailto:rtgwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtgwg>, <mailto:rtgwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 May 2017 13:47:44 -0000

The Revised Datastore Draft (https://tools.ietf.org/html/draft-ietf-netmod-revised-datastores-01) is the latest approach to address this issue. Before the solution is finalized, NETCONF/RESTCONF protocols are updated, and implementations are available, we still have the field duplications meanwhile.

Thanks,
- Xufeng


> -----Original Message-----
> From: t.petch [mailto:ietfa@btconnect.com]
> Sent: Wednesday, May 3, 2017 1:30 PM
> To: Henning Rogge <hrogge@gmail.com>; Xufeng Liu <Xufeng_Liu@jabil.com>
> Cc: Athanasios Kyparlis <Athanasios_Kyparlis@jabil.com>;
> parikhr@vmware.com; Routing WG <rtgwg@ietf.org>
> Subject: Re: Routing directorate QA review of draft-ietf-rtgwg-yang-vrrp
> 
> ----- Original Message -----
> From: "Henning Rogge" <hrogge@gmail.com>
> Sent: Tuesday, May 02, 2017 7:49 AM
> >
> > yes I think the new changes improve the draft and make it easier to
> understand.
> >
> > I wonder if there is a way in YANG to prevent the duplication of all
> > the fields between "interface" and "interface-state"... putting the
> > common fields into a section of their own and refer to them twice,
> > once as "read only" and once "read-writeable".
> 
> No:-(
> 
> This has become a thorny and vexed question with lots of solutions whose
> benefits depend on where you are coming from with no consensus among the
> interested parties. NETCONF/YANG set out to support configuration which is
> defined as something writeable. Read only, well it was not ignored but it did
> take a back seat since SNMP was already handling that part of network
> management.  A requirement emerged to know what the results were of a
> configuration change.  I enable an interface; is it now enabled?  I set an
> interface card to auto; what speed is it running at?  Clearly there are 'twin'
> objects, sometimes triads or more.  Rather late in the day it emerged that in
> YANG read-only objects that are below a read-write object that has not been
> written do not exist.  This led to the twin trees approach that is widely used, one
> tree for read-only, one for read-write.
> 
> Other dimensions of this problem are the need either for configuration to come
> first and a hot-plugged card to pick up the configuration or for hot-plugging to
> come first and then the card be configured; and for the box to provide default
> values to minimise the configuration needed and for the NMS to know what the
> defaults are but not to have to read them all.
> 
> Discussions on this go back to 2008 and continue; meanwhile the number of
> YANG modules ever increases making changes ever more expensive.
> 
> I like your idea but suspect that it will not gain traction.
> 
> Tom Petch
> 
> > Henning Rogge
> >
> > On Fri, Apr 28, 2017 at 10:41 PM, Xufeng Liu <Xufeng_Liu@jabil.com>
> wrote:
> > > Hi Henning,
> > >
> > > Please review if the attached change proposal is ok.
> > > Thanks,
> > > - Xufeng
> > >
> > >> -----Original Message-----
> > >> From: Xufeng Liu
> > >> Sent: Wednesday, April 26, 2017 9:18 AM
> > >> To: 'Henning Rogge' <hrogge@gmail.com>
> > >> Cc: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>;
> Athanasios
> > >> Kyparlis <Athanasios_Kyparlis@jabil.com>; parikhr@vmware.com;
> > >> zhangmingui@huawei.com; Routing WG <rtgwg@ietf.org>
> > >> Subject: RE: Routing directorate QA review of
> draft-ietf-rtgwg-yang-vrrp
> > >>
> > >> Hi Henning,
> > >>
> > >> Yes. We will add some explanations.
> > >> Thanks,
> > >> - Xufeng
> > >>
> > >> > -----Original Message-----
> > >> > From: Henning Rogge [mailto:hrogge@gmail.com]
> > >> > Sent: Tuesday, April 25, 2017 9:50 AM
> > >> > To: Xufeng Liu <Xufeng_Liu@jabil.com>
> > >> > Cc: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>;
> Athanasios
> > >> > Kyparlis <Athanasios_Kyparlis@jabil.com>; parikhr@vmware.com;
> > >> > zhangmingui@huawei.com; Routing WG <rtgwg@ietf.org>
> > >> > Subject: Re: Routing directorate QA review of
> > >> > draft-ietf-rtgwg-yang-vrrp
> > >> >
> > >> > On Tue, Apr 25, 2017 at 3:47 PM, Xufeng Liu
> <Xufeng_Liu@jabil.com> wrote:
> > >> > >
> > >> > > Hi Henning,
> > >> > >
> > >> > >
> > >> > >
> > >> > > Thank you much for the review.
> > >> > >
> > >> > >
> > >> > >
> > >> > > You are right about the mapping for "address of the virtual
> router".
> > >> > > The
> > >> > existing YANG data model for configuring and managing IP
> addresses is
> > >> > RFC7277, which augments the ietf-interfaces model specified by
> > >> > RFC7223. This VRRP model follows the same paradigm. Such a
> structure
> > >> > is also VRRP protocols are usually implemented.
> > >> >
> > >> > Maybe the naming of the variables or the explanation of them
> could be
> > >> > improved to explicitly state this.
> > >> >
> > >> > Henning
> > >> >
> > >> > >
> > >> > >
> > >> > >
> > >> > > We will fix the error in  Appendix A. in the next revision.
> > >> > >
> > >> > >
> > >> > >
> > >> > > Regards,
> > >> > >
> > >> > > - Xufeng
> > >> > >
> > >> > >
> > >> > >
> > >> > > From: Henning Rogge [mailto:hrogge@gmail.com]
> > >> > > Sent: Monday, April 24, 2017 3:41 AM
> > >> > > To: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>;
> Xufeng Liu
> > >> > > <Xufeng_Liu@jabil.com>; Athanasios Kyparlis
> > >> > > <Athanasios_Kyparlis@jabil.com>; parikhr@vmware.com;
> > >> > > zhangmingui@huawei.com
> > >> > > Cc: Routing WG <rtgwg@ietf.org>
> > >> > > Subject: Re: Routing directorate QA review of
> > >> > > draft-ietf-rtgwg-yang-vrrp
> > >> > >
> > >> > >
> > >> > >
> > >> > > Hi,
> > >> > >
> > >> > >
> > >> > >
> > >> > > Jonathan Hardwick asked me to do an early review of the
> > >> > > draft-ietf-rtgwg-
> > >> > yang-vrrp document (currently revision 02) for the routing
> directorate.
> > >> > >
> > >> > >
> > >> > >
> > >> > > The draft itself is pretty straight forward and compact,
> especially
> > >> > > when you
> > >> > consider that a lot of text has to be repeated two or four times
> > >> > (IPv4/IPv6, config vs. read-only state).
> > >> > >
> > >> > >
> > >> > >
> > >> > > But I had quite a bit of trouble mapping the phrases from the
> new
> > >> > > draft-ietf-
> > >> > rtgwg-yang-vrrp-02 document to the existing VRRP documents (e.g.
> RFC5798).
> > >> > This might come from my unfamilarity with VRRP.
> > >> > >
> > >> > >
> > >> > >
> > >> > > The draft YANG model allows to read (if:interfaces-state) and
> > >> > > configure
> > >> > (if:interfaces) virtual IP addresses, but this does not seem to
> be a
> > >> > common phrase from the RFCs. Is it the same as "address of the
> virtual
> > >> > router" often mentioned in RFC5798?
> > >> > >
> > >> > >
> > >> > >
> > >> > > In addition to this, I found (I think) a typo or inconsistency
> in Appendix A:
> > >> > >
> > >> > > the ascii art says "eth0" but tree says "eth1".
> > >> > >
> > >> > >
> > >> > >
> > >> > > Henning Rogge
> > >> > >
> > >> > >
> > >> > >
> > >> > > On Mon, Mar 27, 2017 at 5:43 PM, Jonathan Hardwick
> > >> > <Jonathan.Hardwick@metaswitch.com> wrote:
> > >> > >
> > >> > > Hi Henning
> > >> > >
> > >> > >
> > >> > >
> > >> > > Please would you do a routing directorate early review of this
> > >> > > draft?  Would
> > >> > you be able to do it in 2 to 3 weeks?
> > >> > >
> > >> > >
> > >> > >
> > >> > > Many thanks
> > >> > >
> > >> > > Jon
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> > > Please would you do a routing directorate QA review of this
> draft?
> > >> > >
> > >> > > https://datatracker.ietf.org/doc/draft-ietf-rtgwg-yang-vrrp/
> > >> > >
> > >> > >
> > >> > >
> > >> > > The draft is still in the RTGWG and is ready for WG last call.
> The
> > >> > > WG chairs
> > >> > have asked for a QA review from the directorate.  The following
> link
> > >> > provides guidance on QA reviews.
> > >> > >
> > >> > > https://trac.ietf.org/trac/rtg/wiki/RtgDirDocQa
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> >
> > _______________________________________________
> > rtgwg mailing list
> > rtgwg@ietf.org
> > https://www.ietf.org/mailman/listinfo/rtgwg