Re: [secdir] Secdir early review of draft-ietf-lamps-rfc7030-csrattrs-08

Michael Richardson <mcr+ietf@sandelman.ca> Wed, 03 April 2024 13:21 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FFCBC151531; Wed, 3 Apr 2024 06:21:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.097
X-Spam-Level:
X-Spam-Status: No, score=-7.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=sandelman.ca
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qDfjR8LYWbXs; Wed, 3 Apr 2024 06:21:42 -0700 (PDT)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [IPv6:2607:f0b0:f:3:216:3eff:fe7c:d1f3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4AFE8C14F682; Wed, 3 Apr 2024 06:21:37 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by tuna.sandelman.ca (Postfix) with ESMTP id 0CB273898B; Wed, 3 Apr 2024 09:21:36 -0400 (EDT)
Received: from tuna.sandelman.ca ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5azRvBrbBNFH; Wed, 3 Apr 2024 09:21:34 -0400 (EDT)
Received: from sandelman.ca (obiwan.sandelman.ca [IPv6:2607:f0b0:f:2::247]) by tuna.sandelman.ca (Postfix) with ESMTP id A1DF338988; Wed, 3 Apr 2024 09:21:34 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandelman.ca; s=mail; t=1712150494; bh=z5WZG6hbUfzadMDi7oIKmv0Y5JEtPITvim0sk9riuKo=; h=From:To:Subject:In-Reply-To:References:Date:From; b=ieYvhLkFjFF8g8AT3hAt0+VEd8mq67HmlZscx3QtduJy65cyRHsn5D1X9NwlimPra TTHLKygmWvX8dcK+PgeYimGmoC53+VoBGOiw9cuJ8+Yw8yHiJUs0RI6YcKzZt1vegN LkGNaQVNcKS6+iYOtWlSMd8YUis2c/VPmseGEWq8QUTQ4Wy6hugRFBt0CPsaT2KFiA lU5oYl6DFGNkh03sDRed5d/dQqpI/9kPzr+6f2HLOvdKrgLpsxI9+YoUwyhnYyxlX6 rnUQeP4VZNYIk9edHmq2wLHVaVNkZ/kI1tnFS2Ew38rM9wcjhRWNp1Uj7aXW4MQvT5 nQCunthocZlWA==
Received: from obiwan.sandelman.ca (localhost [IPv6:::1]) by sandelman.ca (Postfix) with ESMTP id 9AA17130; Wed, 3 Apr 2024 09:21:34 -0400 (EDT)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: Valery Smyslov <valery@smyslov.net>, secdir@ietf.org, draft-ietf-lamps-rfc7030-csrattrs.all@ietf.org, spasm@ietf.org
In-Reply-To: <171214769605.4394.3756625912941164021@ietfa.amsl.com>
References: <171214769605.4394.3756625912941164021@ietfa.amsl.com>
X-Mailer: MH-E 8.6+git; nmh 1.8+dev; GNU Emacs 28.2
X-Face: $\n1pF)h^`}$H>Hk{L"x@)JS7<%Az}5RyS@k9X%29-lHB$Ti.V>2bi.~ehC0; <'$9xN5Ub# z!G,p`nR&p7Fz@^UXIn156S8.~^@MJ*mMsD7=QFeq%AL4m<nPbLgmtKK-5dC@#:k
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Date: Wed, 03 Apr 2024 09:21:34 -0400
Message-ID: <15325.1712150494@obiwan.sandelman.ca>
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/YGNo08BGnEoGndv9YXDvW3UgOog>
Subject: Re: [secdir] Secdir early review of draft-ietf-lamps-rfc7030-csrattrs-08
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2024 13:21:46 -0000

Valery Smyslov via Datatracker <noreply@ietf.org> wrote:
> I have reviewed this document as part of the security directorate's

Thank you.

    > Nits: 1. This draft updates RFC 7030, but this is not indicated in its
    > header.

fixed.

    > 2. It seems to me that definition of
    > id-aa-certificationRequestInfoTemplate in the Section 3.3 and in the
    > Appendix A lacks the name of the new element in OID (only value "TBD2"
    > is present).

I see, we didn't really give it a clear name.
I think that we should also link in the IANA Considerations TBD1/TBD2.
I'm not sure what name we should give to TBD2.  Sean?

    > 3. Section 3.2, typo: s/MUST by/MUST be
    > 4. Section 3.3, typo, perhaps: s/The avoid this drawback/To avoid this
    > drawback
    > 5. Section 3.3, possible typo: s/The SubjectPublicKeyInfo field must be
    > present/The SubjectPublicKeyInfo field MUST be present

Thank you, updated.



--
Michael Richardson <mcr+IETF@sandelman.ca>   . o O ( IPv6 IøT consulting )
           Sandelman Software Works Inc, Ottawa and Worldwide