Re: [secdir] secdir review of draft-ietf-dime-priority-avps-04

<lionel.morand@orange-ftgroup.com> Tue, 26 July 2011 18:26 UTC

Return-Path: <lionel.morand@orange-ftgroup.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 94EFD21F873D; Tue, 26 Jul 2011 11:26:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -103.249
X-Spam-Level:
X-Spam-Status: No, score=-103.249 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, HELO_EQ_FR=0.35, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3Gqk1aHxmlkJ; Tue, 26 Jul 2011 11:26:11 -0700 (PDT)
Received: from p-mail1.rd.francetelecom.com (p-mail1.rd.francetelecom.com [195.101.245.15]) by ietfa.amsl.com (Postfix) with ESMTP id 625A721F86BE; Tue, 26 Jul 2011 11:26:11 -0700 (PDT)
Received: from p-mail1.rd.francetelecom.com (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id 55C598B8007; Tue, 26 Jul 2011 20:26:59 +0200 (CEST)
Received: from ftrdsmtp2.rd.francetelecom.fr (unknown [10.192.128.47]) by p-mail1.rd.francetelecom.com (Postfix) with ESMTP id 49BF48B8003; Tue, 26 Jul 2011 20:26:59 +0200 (CEST)
Received: from ftrdmel1.rd.francetelecom.fr ([10.192.128.40]) by ftrdsmtp2.rd.francetelecom.fr with Microsoft SMTPSVC(6.0.3790.4675); Tue, 26 Jul 2011 20:26:10 +0200
X-MIMEOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 26 Jul 2011 20:26:08 +0200
Message-ID: <B11765B89737A7498AF63EA84EC9F577BB648C@ftrdmel1>
In-reply-to: <AC6674AB7BC78549BB231821ABF7A9AEB674517339@EMBX01-WF.jnpr.net>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-topic: secdir review of draft-ietf-dime-priority-avps-04
Thread-index: AcxLhoMMZuNcnDQsSYq5r0pigpKbWQAApa0wAA115aA=
References: <20110726104135.13472eudbij0eaqs@portland.eukhosting.net> <AC6674AB7BC78549BB231821ABF7A9AEB674516F2B@EMBX01-WF.jnpr.net> <20110726112346.35893ibie0kwerqc@portland.eukhosting.net> <AC6674AB7BC78549BB231821ABF7A9AEB674517339@EMBX01-WF.jnpr.net>
From: lionel.morand@orange-ftgroup.com
To: shanna@juniper.net, carlberg@g11.org.uk
X-OriginalArrivalTime: 26 Jul 2011 18:26:10.0449 (UTC) FILETIME=[7E2C1010:01CC4BC1]
X-Mailman-Approved-At: Wed, 27 Jul 2011 08:21:51 -0700
Cc: draft-ietf-dime-priority-avps.all@tools.ietf.org, ietf@ietf.org, secdir@ietf.org
Subject: Re: [secdir] secdir review of draft-ietf-dime-priority-avps-04
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jul 2011 18:26:12 -0000

Hi Stephen,

The example given below illustrates also what I'm thinking. And please forgive me if I miss something below.

IMHO, what you are saying about the SIP-Resource-Priority is true for any other QoS parameters carried over the Diameter QoS application. It is therefore why I'm assuming that the security considerations (http://tools.ietf.org/html/rfc5866#section-11) provided in the RFC 5866 is valid for any QoS related AVP, including the new set of AVPs defined in this document.

Would it make sense to refer to this section (instead of a copy/paste)? Would it solve the current issue?

Regards,

Lionel

-----Message d'origine-----
De : Stephen Hanna [mailto:shanna@juniper.net] 
Envoyé : mardi 26 juillet 2011 17:34
À : carlberg@g11.org.uk
Cc : ietf@ietf.org; secdir@ietf.org; draft-ietf-dime-priority-avps.all@tools.ietf.org; MORAND Lionel RD-CORE-ISS
Objet : RE: secdir review of draft-ietf-dime-priority-avps-04

Every RFC author has an obligation to explain in the Security Considerations
section what security issues are likely to arise when this specification is
used and how those issues may be addressed. You can refer to other RFCs if
you like but you cannot ignore the issues or just give a hand wave.

Let me give a specific example. If a user is able to ensure that their phone
calls always get the highest SIP-Resource-Priority, their calls will always
go through, even during a disaster. This will benefit the user so they have
an incentive to do it. However, it may damage the collective if calls from
emergency responders are overridden. For this reason, protection against
active MITM attacks SHOULD be employed when using Priority AVPs.

If you can find an extant RFC that covers the relevant Security Considerations
for your document, you can point to it and say that readers should review it
because the security considerations for this draft are contained there. But
you must perform a serious security analysis for your document if you want
it to be accepted as an RFC. If the answer is that there are no security
considerations, that's fine. You can say that. But in this case, that's
clearly not the case.

You raised the concern that documents may need to highlight security issues
with underlying protocols upon which they depend. That is true. If you're
depending on a protocol that has a serious security problem that's relevant
to your document, you should explain that problem or point to a document
that does so. If the problem is not relevant to your document, no problem.
One need not consider every possible security issue, just the ones that
are most relevant to your document. In your case, there are real security
issues particular to conveying priority AVPs over Diameter. You should
explain what those considerations are or point to documents that do so.
As for MIBs, take a look at some recent ones and you will see that they
do contain good Security Considerations sections. For example, see
RFC 5834 and RFC 6240.

If you'd like to learn more about how to write a good Security
Considerations section, read RFC 3552. Or ask a security expert
to help you. If you can't be bothered to think about security,
you might as well withdraw your draft from consideration.

Thanks,

Steve

> -----Original Message-----
> From: carlberg@g11.org.uk [mailto:carlberg@g11.org.uk]
> Sent: Tuesday, July 26, 2011 7:24 AM
> To: Stephen Hanna
> Cc: ietf@ietf.org; secdir@ietf.org; draft-ietf-dime-priority-
> avps.all@tools.ietf.org; lionel.morand@orange-ftgroup.com
> Subject: RE: secdir review of draft-ietf-dime-priority-avps-04
> 
> Steve,
> 
> 
> Quoting Stephen Hanna <shanna@juniper.net>:
> 
> > Thanks for your response, Ken.
> >
> > Removing the last sentence that you quoted would make things worse.
> > Readers of this draft should definitely familiarize themselves with
> > the security considerations related to priority. We should make that
> > easier, not harder. The fact that those considerations also apply to
> > other RFCs does not remove the fact that they apply to this one also.
> 
> but those considerations do not directly apply to DIAMETER.
> 
> > You cannot publish a document whose security considerations section
> > says (as this one effectively does today), "There are lots of
> security
> > considerations related to this document. To understand them, please
> > dig through all the referenced documents and figure it out yourself."
> > Doing that digging and analysis is the job of the document editors.
> 
> agreed, speaking in the general sense.  But again, the security
> considerations of these other protocols do not apply to the operation
> of Diameter.
> 
> > In order to ease the burden on you, I think a reasonable compromise
> > would be for YOU to review the documents referenced and decide which
> > have the most relevant security considerations. Then you could list
> > those explicitly in the last paragraph of the Security
> Considerations.
> 
> I'm concerned about the implications of your recommendation.  If we
> extend this position to other work in the IETF, then efforts like
> defining MIBs would mean that each MIB draft would need to perform a
> security considerations analysis of each protocol that an objects
> refers to in the context of SNMP.  And one can extend the argument
> that each protocol operating on top of TCP (and/or UDP) and IP would
> need to perform an analysis on how TCP/UDP and IP may affect the upper
> layer protocol.  We don't do that today.
> 
> cheers,
> 
> -ken
>