Re: [secdir] Secdir last call review of draft-ietf-emu-eap-session-id-03
Benjamin Kaduk <kaduk@mit.edu> Sun, 14 June 2020 04:56 UTC
Return-Path: <kaduk@mit.edu>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 443493A0A51 for <secdir@ietfa.amsl.com>; Sat, 13 Jun 2020 21:56:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.002
X-Spam-Level:
X-Spam-Status: No, score=0.002 tagged_above=-999 required=5 tests=[RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mj1CZiciyUqs for <secdir@ietfa.amsl.com>; Sat, 13 Jun 2020 21:56:38 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28EF23A0A4F for <secdir@ietf.org>; Sat, 13 Jun 2020 21:56:37 -0700 (PDT)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 05E4uX6C024143 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 14 Jun 2020 00:56:36 -0400
Date: Sat, 13 Jun 2020 21:56:33 -0700
From: Benjamin Kaduk <kaduk@mit.edu>
To: Mališa Vučinić <malisa.vucinic@inria.fr>
Cc: secdir@ietf.org
Message-ID: <20200614045633.GF11992@kduck.mit.edu>
References: <159050117661.11337.1336987637854906717@ietfa.amsl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <159050117661.11337.1336987637854906717@ietfa.amsl.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/lZ7TppkGi6dkrOweozaqhBKVt6o>
Subject: Re: [secdir] Secdir last call review of draft-ietf-emu-eap-session-id-03
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jun 2020 04:56:39 -0000
Hi Mališa, Thanks for the review! I ended up putting a Discuss ballot on, for a (presumably) copy/paste error in one of the message names, and wanting a reference for PEAP (which may be challenging, as it seems to be a Microsoft proprietary protocol). It would be nice if some cryptographic review of the new Session-Id constructions was done, but I don't think either of us is the right person to do it, so we're limited to just asking the authors what has already been done. -Ben On Tue, May 26, 2020 at 06:52:56AM -0700, Mališa Vučinić via Datatracker wrote: > Reviewer: Mališa Vučinić > Review result: Has Nits > > I have reviewed this document as part of the security directorate's ongoing > effort to review all IETF documents being processed by the IESG. These > comments were written primarily for the benefit of the security area directors. > Document editors and WG chairs should treat these comments just like any other > last call comments. > > The document updates RFC5247 to specify EAP Session-ID definition in case fast > re-authentication is used with EAP-AKA and EAP-SIM. The Session-ID definition > is based on a server-generated nonce and a MAC. The document also specifies the > Session-ID definition for the PEAP method, following the definition of EAP-TLS. > > The document is clear and well written. Security considerations section is > clear and states no known security issues in the definitions used. A reference > to PEAP is missing. > > Nits: > Section 3: s/to not modify/do not modify > >
- [secdir] Secdir last call review of draft-ietf-em… Mališa Vučinić via Datatracker
- Re: [secdir] Secdir last call review of draft-iet… Benjamin Kaduk