Re: [sfc] Additional AD review comments on draft-ietf-sfc-nsh-20

"Carlos Pignataro (cpignata)" <cpignata@cisco.com> Fri, 22 September 2017 21:16 UTC

Return-Path: <cpignata@cisco.com>
X-Original-To: sfc@ietfa.amsl.com
Delivered-To: sfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE4CA13301F; Fri, 22 Sep 2017 14:16:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.52
X-Spam-Level:
X-Spam-Status: No, score=-14.52 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9klp73Z1xxBo; Fri, 22 Sep 2017 14:16:02 -0700 (PDT)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 89C0813219B; Fri, 22 Sep 2017 14:16:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=22614; q=dns/txt; s=iport; t=1506114962; x=1507324562; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=wcsIRrMdkP6HCzmLvpUE0w403NGL91JiqUGO+gF6uMc=; b=En2+pjXF/WcatRe7fnYFNesKh1sdQaZFNs1bkUWVq1WrEMCoNNjiQDa3 ecSCDidKie3f15AlSuNKVZfhRa16waBXX7PI+OB8g94Wt+O9AxQJ5Ifxl lncJ+yM9Ig2gVEJtePj84OKHrCyJ2hg8jxKhEbx8Chs73WjnJZ5Vm3YXP w=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0C5AQDHfMVZ/51dJa1cGQEBAQEBAQEBAQEBBwEBAQEBg1qBUicHg2+aG4F0iD+IK4VMggQKhTsCGoQKVwECAQEBAQECayiFGAEBAQECASNIDgULAgEIDgonAwICAh8RFBECBA4FiU9MAw0IpyCCJ4c2DYNYAQEBAQEBAQEBAQEBAQEBAQEBAQEBHYMrgWEBIIFRgWQrgn2CWYFvARIBgzIvgjEFigcBiRiFKogRPAKIcIZxhHmCE4VuiwOMZYgyAhEZAYE4AVeBAwt4FUkSAYcKdod4gSOBEAEBAQ
X-IronPort-AV: E=Sophos;i="5.42,427,1500940800"; d="scan'208,217";a="6876579"
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Sep 2017 21:16:01 +0000
Received: from XCH-RTP-017.cisco.com (xch-rtp-017.cisco.com [64.101.220.157]) by rcdn-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id v8MLG1kE021178 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 22 Sep 2017 21:16:01 GMT
Received: from xch-rtp-020.cisco.com (64.101.220.160) by XCH-RTP-017.cisco.com (64.101.220.157) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Fri, 22 Sep 2017 17:16:00 -0400
Received: from xch-rtp-020.cisco.com ([64.101.220.160]) by XCH-RTP-020.cisco.com ([64.101.220.160]) with mapi id 15.00.1263.000; Fri, 22 Sep 2017 17:16:00 -0400
From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com>
To: Alia Atlas <akatlas@gmail.com>
CC: "sfc@ietf.org" <sfc@ietf.org>, "draft-ietf-sfc-nsh@ietf.org" <draft-ietf-sfc-nsh@ietf.org>
Thread-Topic: Additional AD review comments on draft-ietf-sfc-nsh-20
Thread-Index: AQHTKBEJ6j37PwZL1EeImcQxKOWXRaK7RsUAgAZuAYCAAA4ZAA==
Date: Fri, 22 Sep 2017 21:16:00 +0000
Message-ID: <9A9C0616-9B5E-42B5-9A03-F2833F28C105@cisco.com>
References: <CAG4d1rdTfPAD38u++W+OysGz7W76iaZQnzea0U7EFOLE9oHh5A@mail.gmail.com> <29A6B17C-F815-4A03-A63C-CB265F0175A2@cisco.com> <CAG4d1rfh5XQXqBjsUWkrGudSGCnaBAaaS1dO+GcfpX9Wig3f3w@mail.gmail.com>
In-Reply-To: <CAG4d1rfh5XQXqBjsUWkrGudSGCnaBAaaS1dO+GcfpX9Wig3f3w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.116.133]
Content-Type: multipart/alternative; boundary="_000_9A9C06169B5E42B59A03F2833F28C105ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/sfc/OG8GexpAWCnCOo5CZUPSDXyi83g>
Subject: Re: [sfc] Additional AD review comments on draft-ietf-sfc-nsh-20
X-BeenThere: sfc@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Network Service Chaining <sfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sfc>, <mailto:sfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sfc/>
List-Post: <mailto:sfc@ietf.org>
List-Help: <mailto:sfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sfc>, <mailto:sfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Sep 2017 21:16:05 -0000

Hi Alia,

First, thanks for the follow-up and dialogue.

-23 is out.

I am now convinced that specifying the behavior regarding the O and unassigned bits upon reclassification is not only harmless, not only useful, but potentially necessary. Thanks for pushing.

The IANA comment about signaling when half empty / half full is good — if IANA signs up for it. But, like Joel, I am not sure how to write to “give preference” to standard protocols.

Thanks!

—
Carlos Pignataro, carlos@cisco.com<mailto:carlos@cisco.com>

“Sometimes I use big words that I do not fully understand, to make myself sound more photosynthesis."

On Sep 22, 2017, at 4:25 PM, Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>> wrote:

Hi Carlos,

First, thanks for the updated version -21.

The rest is inline.

On Mon, Sep 18, 2017 at 2:14 PM, Carlos Pignataro (cpignata) <cpignata@cisco.com<mailto:cpignata@cisco.com>> wrote:
Hi, Alia,

You addressed this email to me, but I just noticed I failed to respond — apologies!

> On Sep 7, 2017, at 3:39 PM, Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>> wrote:
>
> Carlos,
>
> The draft is much improved.  Thank you for your hard work.  I still see the following three issues.
>

Thanks, let’s see those three, inline.

>
> 1) Sec 2.2: "The O bit MUST be set for OAM packets and MUST NOT be set for non-OAM
>    packets.  The O bit MUST NOT be modified along the SFP."
> What happens if the packet is reclassified - potentially to a different SFP?
>
> Sec 3 doesn't clarify this."When the logical classifier performs re-
>        classification that results in a change of service path, it MUST
>        replace the existing NSH with a new NSH with the Base Header and
>        Service Path Header reflecting the new service path information
>        and MUST set the initial SI.  Metadata MAY be preserved in the
>        new NSH."
>

I do not think Sec 3 needs to clarify it. Section 2.2 already says:

“O bit: […] The actual format and processing of SFC
   OAM packets is outside the scope of this specification”

So we should not attempt to specify the processing here.

If you believe it helps, we can add “The value of the O bit MUST be preserved in the new NSH”, but that would go against S2.2’s scope.

My concern is the following example.  Say that an operator wants to do the equivalent of a traceroute to see how a packet is put into an SFP and what SFs it goes through (or maybe just SFFs).  Assume that is done by setting the O bit in the first NSH and then the encapsulated packet has duplicated contents to be guided properly.  If that packet then is reclassified, is the O bit cleared?

I have a real hesitation here about the future interoperability of something like traceroute,  if the behavior for the treatment of the O bit isn't specified for (re)classifiers.  For instance, if an SF or SFF doesn't support this new NSH-traceroute, then a hop would be skipped in the report back - but if the (re)classifier does it wrong, then all the hops downstream of the (re)classifier will suffer.

Do you or others have data on what current implementations are doing as part of reclassification? My interest isn't in changing the behavior (hopefully it is being done consistently) but in clearly documenting the expectations.


> It would be good to specify the behavior for the unassigned flags as well; that way there will be consistent assumptions for future extensions, if needed.
>

Since they are Unassigned, the have no behavior specified, other than what’s already there:

“Unassigned bits MUST
   be set to zero upon origination, and MUST be ignored and preserved
   unmodified by other NSH supporting elements.  At reception, all
   elements MUST NOT modify their actions based on these unknown bits.”

What else is missing?

Survival through a reclassifier is what I am thinking about.
In one model, there is the ability to pass along flags with a packet from the initial classification until the end of the SFC.
In another model, the flags only survive until the first reclassifier.
What one can do with these flags is different.
IMHO, it'd be better to clarify that unassigned flags should be copied transparently from an old NSH to a new/updated NSH.
Then, when and if the flags are assigned meanings, that can inform and change what classifiers that understand the flag
meaning will do.

> 2) Sec 7.1: "For example, if the metadata conveys tenant information, that information may need to be authenticated and/or encrypted between the originator and the
>    intended recipients (which may include intended SFs only)."
> A reference to draft-reddy-sfc-nsh-encrypt, which defines how to encrypt the meta-data would be most helpful in making this sound less aspirational;

Sure. It’s already cited in the Security Considerations section, but we can add another citation. Done in the working copy.

> so would having that draft not be 2 years expired and ignored by the WG.
>
> 3) Sec 11.2.5: Guidance for the expert review is needed.

Good point. Thanks.

Here’s an attempt, please complete. I am hesitant to request discussion on the SFC list, do you think we should (and request in that document that the list is kept open)?

<t>
Expert Review requests MUST include a single code point per request.
   Designated Experts evaluating new allocation requests from this registry
   should consider the potential scarcity of code points for an 8-bit value,
   and check both for duplications as well as availability of documentation.
</t>

This is a good start.  I'd add that standardized protocols should have preference and
if the range goes over 50% allocated, then IANA should alert the responsible AD so
that a new policy can be considered.

Thanks,
Alia

>
> Regards,
> Alia

—
Carlos Pignataro, carlos@cisco.com<mailto:carlos@cisco.com>

“Sometimes I use big words that I do not fully understand, to make myself sound more photosynthesis."