Re: [Sframe] Feedback on draft-ietf-sframe-enc-04

Martin Thomson <mt@lowentropy.net> Fri, 17 November 2023 02:22 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: sframe@ietfa.amsl.com
Delivered-To: sframe@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7139EC14CE55 for <sframe@ietfa.amsl.com>; Thu, 16 Nov 2023 18:22:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b="EYfIVODu"; dkim=pass (2048-bit key) header.d=messagingengine.com header.b="jiIIOTwy"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18OCgWTWGmzp for <sframe@ietfa.amsl.com>; Thu, 16 Nov 2023 18:21:55 -0800 (PST)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 96DB0C14CE53 for <sframe@ietf.org>; Thu, 16 Nov 2023 18:21:55 -0800 (PST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 718CA320014C; Thu, 16 Nov 2023 21:21:54 -0500 (EST)
Received: from imap41 ([10.202.2.91]) by compute6.internal (MEProxy); Thu, 16 Nov 2023 21:21:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm2; t=1700187713; x=1700274113; bh=zlCQywE2A7Xi+Om9faZ4SbNmI tiYfqQaQKnCve+24hU=; b=EYfIVODuqQcsNU4SZaIT4zZFvC/NKwxD5DxuVoIfF kBhjmE+QoylKBsoF33AncX7LCv2nK5RI/HxRAUZklq8TnkcqFMNeckiyRkRaFf3x YZaabHkgbfdpWxcrt6GKD/OIl+f33iq95jDXFAkT+Co+tLDrmVSFjefRuUKIdxQM sC4C53JKPvGo2HOyDfEP00Xcz98EH64NLIZ2k76K5/4h86mCB7sXb1NPJaSHsrlp dBcvZQ5PjgMqN09VNcVlfbeH0nfbMsBthNQdiQeiqk8CJXe5lLShSHJ1MFVhqStG SgkbjMOyVdszuZ699zXhYheUP0SCHG8Ll3WgEsYfO0dZQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700187713; x=1700274113; bh=zlCQywE2A7Xi+Om9faZ4SbNmItiYfqQaQKn Cve+24hU=; b=jiIIOTwyveXMSLAcTX19oUmCIQ4KA+EY+StCPvh9ywNsXM9Oe5W AGQ0CHD1i6UlM1DFziDM0jy2V5PoZUww3NYHUKzFOP6L9RFdP1hLaplrtbmwGd0p ZwlG9Oj63kTPw++Rc7jfaxTiF+hFAowWgBbGqvqoVLMUGK59qa0zu9CeVRm0852Z sAI4OvZI64rLMijoETVHlv0KrWOAZw68DnGtHEx3C1olc0Xm8sM99MxngB4YLxQL z1gqo94gnw/zOk3EGGaTY/9s8XpTm/BEbrtotzjRBue4cdATjCr+VyhPasffDGgR TGHWWzbCrTeAy5Flfp+1JcR1EOQMGWA0bBQ==
X-ME-Sender: <xms:Qc5WZXjveBNWkp7GBxeBl5ZbwYIwKyZKm_BZw8-oTxnFcTwbZrjzRg> <xme:Qc5WZUDiOQwOiuKaCLeslD66Z-O6mT4oq_FGbITZwd5dbfLus4e80w9Y40DBhWeWN xp1xLp92cis12oq_Ds>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefledggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvvefutgfgse htqhertderreejnecuhfhrohhmpedfofgrrhhtihhnucfvhhhomhhsohhnfdcuoehmthes lhhofigvnhhtrhhophihrdhnvghtqeenucggtffrrghtthgvrhhnpeekuefgvdegtdeuff evjeeltedtheehjeehveefieeitefgudegleelffeihfdvteenucffohhmrghinhepghhi thhhuhgsrdgtohhmpdhivghtfhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmtheslhhofigvnhhtrhhophihrdhnvght
X-ME-Proxy: <xmx:Qc5WZXEtS0C5TVrjStuYqrk1s3FikKw92IoBiIIOZ0A_9pkoHm-Exg> <xmx:Qc5WZURL5RHwVCmxN7QMrbg2dkxjxKTj7fGSipPRiCcipwiowN0lqw> <xmx:Qc5WZUzoMzcb7KyuhhHI3uo3cqGsYUyumfs_FtKuuLYhaOa-j_Tz-g> <xmx:Qc5WZaYnjOPSQ8Evcg6XUf-CtK7oVPlKQdz4mlZZ_sAbMJicGcGklA>
Feedback-ID: ic129442d:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501) id AA09B2340080; Thu, 16 Nov 2023 21:21:53 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1108-g3a29173c6d-fm-20231031.005-g3a29173c
MIME-Version: 1.0
Message-Id: <f00e1a52-7d7a-4498-ac56-469db97acc1c@betaapp.fastmail.com>
In-Reply-To: <CAL02cgRrKPV+XC9LPXxwL7iKqZ8J_d42ubu5BjYM+c4yGPfpkA@mail.gmail.com>
References: <0703284B-8829-45E3-B39B-67D2BBD86DB5@heapingbits.net> <CAL02cgRrKPV+XC9LPXxwL7iKqZ8J_d42ubu5BjYM+c4yGPfpkA@mail.gmail.com>
Date: Fri, 17 Nov 2023 13:21:33 +1100
From: Martin Thomson <mt@lowentropy.net>
To: Richard Barnes <rlb@ipv.sx>, Christopher Wood <caw@heapingbits.net>
Cc: sframe@ietf.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/sframe/VctDV4nPRNq-8tkp-Iqm6cZMGEM>
Subject: Re: [Sframe] Feedback on draft-ietf-sframe-enc-04
X-BeenThere: sframe@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Secure Media Frames <sframe.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sframe>, <mailto:sframe-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sframe/>
List-Post: <mailto:sframe@ietf.org>
List-Help: <mailto:sframe-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sframe>, <mailto:sframe-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Nov 2023 02:22:00 -0000

Thanks Chris (and Richard).

I think that what we'll do is wait for these issues to be resolved, revise the draft, and ask for publication.  The feedback we've received is positive and the draft looks to be in a good shape, so it is just a matter of ensuring that we can be proud of what we send the IESG.

Cheers,
Martin

On Fri, Nov 17, 2023, at 04:29, Richard Barnes wrote:
> Hi Chris,
>
> Thanks for the detailed review.  I responded to the issues on GitHub.  
> It looks like the fixes should be fairly minor.  I will leave it to the 
> chairs whether we need any further process around things like changing 
> SHOULD NOT to MUST NOT.
>
> Re implementations: I made a PR with a few pointers:
> https://github.com/sframe-wg/sframe/pull/159
>
> --Richard
>
> On Thu, Nov 16, 2023 at 9:41 AM Christopher Wood <caw@heapingbits.net> wrote:
>> Hi folks,
>> 
>> I reviewed draft-ietf-sframe-enc-04 for the WGLC. Overall, I found the specification very well written. I submitted a couple of issues I think ought to be addressed [1], as well as an editorial PR that I think helps tidy up some things [2]. I think the document is ready to proceed when these issues are resolved.
>> 
>> I’d like to call out issues #158 [3] and #154 [4] specifically. Issue #158 seems like it can be resolved with a normative change or, alternatively, some motivating text. (I suppose another way would be to remove metadata, but I think SFrame should keep the metadata concept — it’s quite cheap and can help future extensibility). Issue #154 may also require a normative change to specify decryption failure behavior.
>> 
>> As an aside, out of curiosity, how many implementations of SFrame exist? Are they tracked anywhere?
>> 
>> Best,
>> Chris
>> 
>> [1] https://github.com/sframe-wg/sframe/issues/created_by/chris-wood
>> [2] https://github.com/sframe-wg/sframe/pull/153
>> [3] https://github.com/sframe-wg/sframe/issues/158
>> [4] https://github.com/sframe-wg/sframe/issues/154
>> -- 
>> Sframe mailing list
>> Sframe@ietf.org
>> https://www.ietf.org/mailman/listinfo/sframe
> -- 
> Sframe mailing list
> Sframe@ietf.org
> https://www.ietf.org/mailman/listinfo/sframe